[GitHub] flink pull request: [FLINK-3519] [core] Add warning about subclass...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1724


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3519] [core] Add warning about subclass...

[fhueske]

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1724#issuecomment-216896787
  
Merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3519] [core] Add warning about subclass...

[fhueske]

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1724#issuecomment-216378193
  
+1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3519] [core] Add warning about subclass...

[ggevay]

Github user ggevay commented on the pull request:

https://github.com/apache/flink/pull/1724#issuecomment-204682353
  
OK, no problem, I've updated the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3519] [core] Add warning about subclass...

[ggevay]

Github user ggevay commented on the pull request:

https://github.com/apache/flink/pull/1724#issuecomment-195743886
  
> What kind of exception do you get?

This is the code near TypeExtractor.java:1379, from where the exception is 
thrown:
```
// check for subclasses of Tuple
if (Tuple.class.isAssignableFrom(clazz)) {
if(clazz == Tuple0.class) {
return new TupleTypeInfo(Tuple0.class);
}
throw new InvalidTypesException("Type information 
extraction for tuples (except Tuple0) cannot be done based on the class.");
}
```

> Also, subclasses of tuples that do not have additional fields can need 
not be Pojos (even though Tuples by themselves should actually meet the Pojo 
rules)

OK, I've updated the comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3519] [core] Add warning about subclass...

[StephanEwen]

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1724#issuecomment-195490545
  
What kind of exception do you get?

Also, subclasses of tuples that do not have additional fields can need not 
be Pojos (even though Tuples by themselves should actually meet the Pojo rules)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3519] [core] Add warning about subclass...

[ggevay]

Github user ggevay commented on the pull request:

https://github.com/apache/flink/pull/1724#issuecomment-190143075
  
> I am not quite sure even, if Tuple subclasses have to be POJOs.

I wrote that based on the comment at TypeExtractor.java:1687. (I also tried 
adding a check there for the result of the analyzePojo call being null, and 
calling privateGetForClass in this case, but then I get an exception from 
TypeExtractor.java:1379.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3519] [core] Add warning about subclass...

[StephanEwen]

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1724#issuecomment-189400067
  
Good idea to update these comments.

I am not quite sure even, if Tuple subclasses have to be POJOs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3519] [core] Add warning about subclass...

[ggevay]

Github user ggevay commented on the pull request:

https://github.com/apache/flink/pull/1724#issuecomment-189326695
  
I have also added that a subclass of TupleN can only be a POJO. (see 
TypeExtractor.java:1686)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3519] [core] Add warning about subclass...

[ggevay]

GitHub user ggevay opened a pull request:

https://github.com/apache/flink/pull/1724

[FLINK-3519] [core] Add warning about subclasses to Tuple javadocs.

I went with option (2), that is, adding a warning to the javadocs.

The generated classes were out of sync with the TupleGenerator, so the 
first commit just brings the TupleGenerator up-to-date.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ggevay/flink tuple-subclass

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1724


commit dcd70fb46d7b5235dd246bc40528f48cae4590ba
Author: Gabor Gevay 
Date:   2016-02-26T15:09:56Z

[core] Bring TupleGenerator up to date with the Tuple classes.

commit 3c96f85c8fec39d13ebc97b1e7761ee76cf23086
Author: Gabor Gevay 
Date:   2016-02-26T15:16:06Z

[FLINK-3519] [core] Add warning about subclasses to Tuple javadocs.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---