[GitHub] flink pull request: [FLINK-3632][TableAPI]Clean up Table API excep...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2015


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3632][TableAPI]Clean up Table API excep...

[fhueske]

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/2015#issuecomment-220956222
  
Will merge this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3632][TableAPI]Clean up Table API excep...

[fhueske]

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/2015#issuecomment-220829100
  
Thanks for the PR @yjshen. The changes look good.
+1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3632][TableAPI]Clean up Table API excep...

[yjshen]

GitHub user yjshen opened a pull request:

https://github.com/apache/flink/pull/2015

[FLINK-3632][TableAPI]Clean up Table API exceptions

As suggested by @fhueske in 
https://github.com/apache/flink/pull/1958#discussion_r62680699, we should use 
`TableException` in the following cases:
- General invalid use of Table API
- registering a table with invalid field types and/or 
- registering a table with already exist name
- Current limitations
- Unsupported types
- Unsupported features (Aggregate on stream table, etc.)

This PR tries to eliminate most of the `IllegalArgumentException` in Table 
API.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yjshen/flink table_exception_cleanup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2015.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2015


commit b54c0cfff6a275ab7eae8c516aa67572be237563
Author: Yijie Shen 
Date:   2016-05-18T15:57:42Z

clean up exceptions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---