[GitHub] flink pull request: [FLINK-3887] improve dependency management for...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2033 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3887] improve dependency management for...
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2033#issuecomment-222634611 Thanks for reviewing. Merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3887] improve dependency management for...
Github user uce commented on the pull request: https://github.com/apache/flink/pull/2033#issuecomment-222557049 Just retried this. Works as expected. +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3887] improve dependency management for...
Github user uce commented on the pull request: https://github.com/apache/flink/pull/2033#issuecomment-222171685 `-p` didn't work, talked to Max offline. After the fix +1 to merge. Very nice change! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3887] improve dependency management for...
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2033 [FLINK-3887] improve dependency management for building docs The Flink documentation build process is currently quite messy. These changes move us to a new build process with proper dependency handling. It assures that we all use the same dependency versions for consistent build output. Also, it eases the automated building process on other systems (like the ASF Buildbot). The goal was to make the documentation build process easier and self-contained. I would like to merge these changes to all `release-x.x` branches because it avoids to have special per-release documentation build rules. - use Ruby's Bundler Gem to install dependencies - update README - adapt Dockerfile - add additional rules to .gitignore - change default doc output path from /target to /content (default path of the flink-web repository) You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink FLINK-3887 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2033.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2033 commit 929d75b3dfaf8e55fb1af47e4fdeecd9101855ed Author: Maximilian MichelsDate: 2016-05-12T13:02:59Z [FLINK-3887] improve dependency management for building docs The Flink documentation build process is currently quite messy. These changes move us to a new build process with proper dependency handling. It assures that we all use the same dependency versions for consistent build output. Also, it eases the automated building process on other systems (like the ASF Buildbot). The goal was to make the documentation build process easier and self-contained. - use Ruby's Bundler Gem to install dependencies - update README - adapt Dockerfile - add additional rules to .gitignore - change default doc output path from /target to /content (default path of the flink-web repository) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3887] improve dependency management for...
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2033#issuecomment-221561008 @uce Would you like to check out the changes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---