[GitHub] flink pull request: Added addition, subtraction and multiply by sc...

[chiwanpark]

Github user chiwanpark commented on the pull request:

https://github.com/apache/flink/pull/2052#issuecomment-222644723
  
Hi @danielblazevski, thanks for opening pull request. But we need a related 
JIRA issue for this. Could you create an issue and change title of this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Added addition, subtraction and multiply by sc...

[danielblazevski]

GitHub user danielblazevski opened a pull request:

https://github.com/apache/flink/pull/2052

Added addition, subtraction and multiply by scalar to DenseVector.scala and 
SparseVector.scala

Small change to add vector operations.  With this small change, can now do 
things like:

```scala
val v1 = DenseVector(0.1, 0.1)
val v2 = DenseVector(0.2, 0.2)
val v3 = v1 + v2
```
instead of what is now has to be done:
```scala
val v1 = DenseVector(0.1, 0.1)
val v2 = DenseVector(0.2, 0.2)
val v3 = (v1.asBreeze + v2.asBreeze).fromBreeze
```
Did not add a test, not sure if I should add a test to any Suite for such a 
small change?  There is no JIRA issue on this. @chiwanpark 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danielblazevski/flink vectorOps

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2052.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2052


commit 44fc80b67c6e2fb85fb2bddfece44b34c9061e1d
Author: danielblazevski 
Date:   2016-05-30T16:34:58Z

added addition/subtraction and mult by scalar to Vector.scala

commit bac684c19e2427b7db41f3430378ef050e660b03
Author: danielblazevski 
Date:   2016-05-30T16:41:19Z

moved to only DenseVector.scala

commit 073149403253a4891223ea46bfc3d8455382703b
Author: danielblazevski 
Date:   2016-05-30T17:08:10Z

added ops to SparseVector.scala




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---