[GitHub] flink pull request: Getter for wrapped StreamExecutionEnvironment ...

2015-09-18 Thread StephanEwen
Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1120#issuecomment-141390831
  
+1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: Getter for wrapped StreamExecutionEnvironment ...

2015-09-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1120


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: Getter for wrapped StreamExecutionEnvironment ...

2015-09-15 Thread lofifnc
Github user lofifnc commented on the pull request:

https://github.com/apache/flink/pull/1120#issuecomment-140301283
  
Hey,

This is mostly for testing purposes. I'm working on some Tooling, which 
takes a  `StreamExectutionEnvironment` and performs integration Tests. In the 
current state I'm not able to work with a `StreamExecutionEnvironment` defined 
with the Scala api.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: Getter for wrapped StreamExecutionEnvironment ...

2015-09-15 Thread StephanEwen
Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1120#issuecomment-140326566
  
I think adding this accessor is fine.

Also, in case someone goes crazy and wants to mix the Java and Scala-style 
functions in one program ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: Getter for wrapped StreamExecutionEnvironment ...

2015-09-14 Thread mbalassi
Github user mbalassi commented on the pull request:

https://github.com/apache/flink/pull/1120#issuecomment-140046200
  
Hey @lofifnc,

Thanks for your interest in Flink. Could you explain why do you need access 
to the wrapped Java `StreamExecutionEnvironment`? I think all the functionality 
can be already accessed from the Scala version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: Getter for wrapped StreamExecutionEnvironment ...

2015-09-11 Thread lofifnc
Github user lofifnc closed the pull request at:

https://github.com/apache/flink/pull/1061


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: Getter for wrapped StreamExecutionEnvironment ...

2015-09-11 Thread lofifnc
GitHub user lofifnc reopened a pull request:

https://github.com/apache/flink/pull/1061

Getter for wrapped StreamExecutionEnvironment by scala api

Currently it is not possible to pass an ExecutionEnvironment defined with 
the scala api to a method written in java that works with the 
org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.
Added a getter to the scala api StreamExecutionEnvironment for java scala 
interoperability.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lofifnc/flink master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1061.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1061


commit dda4ad1784e5600800e7d0f9a05383bba988
Author: Alexander Kolb 
Date:   2015-08-26T15:02:46Z

added getter for wrapped StreamExecutionEnvironment by scala api

commit c3532186d44f6a7f3c2086faf8ae5f47b82e354d
Author: Alexander Kolb 
Date:   2015-09-02T11:24:42Z

Merge branch 'master' of https://github.com/apache/flink

commit 9ad598e45708cf36c1356e176545f21109724c90
Author: Alexander Kolb 
Date:   2015-09-09T07:38:50Z

Merge https://github.com/apache/flink




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: Getter for wrapped StreamExecutionEnvironment ...

2015-09-11 Thread lofifnc
GitHub user lofifnc opened a pull request:

https://github.com/apache/flink/pull/1120

Getter for wrapped StreamExecutionEnvironment by scala api

Currently it is not possible to pass an ExecutionEnvironment defined with 
the scala api to a method working with the 
org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.
Added a getter to the scala api StreamExecutionEnvironment for java scala 
interoperability.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lofifnc/flink getter-for-stream-environment

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1120


commit 6d2f16a1ce34f720f4a26ce99deb6480e29afe80
Author: Alexander Kolb 
Date:   2015-09-11T09:23:27Z

added getter for wrapped environment

commit a11249c66b3995083a0c91af8ba4bd168fcf0ac5
Author: Alexander Kolb 
Date:   2015-09-11T09:31:48Z

renamed method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: Getter for wrapped StreamExecutionEnvironment ...

2015-08-27 Thread lofifnc
Github user lofifnc closed the pull request at:

https://github.com/apache/flink/pull/1061


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: Getter for wrapped StreamExecutionEnvironment ...

2015-08-26 Thread lofifnc
GitHub user lofifnc opened a pull request:

https://github.com/apache/flink/pull/1061

Getter for wrapped StreamExecutionEnvironment by scala api

Currently it is not possible to pass an ExecutionEnvironment defined with 
the scala api to a method written in java that works with the 
org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.
Added a getter to the scala api StreamExecutionEnvironment for java scala 
interoperability.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lofifnc/flink master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1061.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1061


commit dda4ad1784e5600800e7d0f9a05383bba988
Author: Alexander Kolb alexander.k...@ottogroup.com
Date:   2015-08-26T15:02:46Z

added getter for wrapped StreamExecutionEnvironment by scala api




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---