[GitHub] flink pull request: Some fixes for Scala type analysis
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/669#issuecomment-104174485 Hey @aljoscha, it seems this is one needed for the Gelly Scala API :-) Shall I go ahead and merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Some fixes for Scala type analysis
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/669#issuecomment-104182293 I didn't want to merge it without any comments. But please, go ahead. :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Some fixes for Scala type analysis
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/669#issuecomment-104204248 It would be good to share a bit of information beyond `Some fixes for Scala type analysis` about what is actually changed. Then others could think about possible implications and give comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Some fixes for Scala type analysis
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/669#issuecomment-104207389 This excludes static fields in Scala Pojo analysis (because static fields should not be serialised/deserializerd), removes legacy code from Scala Type Descriptors and makes Scala Type Analysis work with Java Tuples (because several people complained about them not being supported in the Scala API, most prominently they are needed to port Gelly to Scala.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Some fixes for Scala type analysis
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/669 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Some fixes for Scala type analysis
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/669#issuecomment-103036619 Any comments? Do we want this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Some fixes for Scala type analysis
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/669 Some fixes for Scala type analysis You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink scala-type-analysis-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/669.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #669 commit ccfe5dec6b110ce0e823378b53001a82af756678 Author: Aljoscha Krettek aljoscha.kret...@gmail.com Date: 2015-05-12T08:42:59Z [hotfix][scala] Exclude static fields in Scala Pojo analysis (And also make one of the field type retrieval methods nicer) commit 9c98464c3358dd84bdd2814861fb76cc9a95ef7a Author: Aljoscha Krettek aljoscha.kret...@gmail.com Date: 2015-05-12T08:48:14Z [hotfix][scala] Remove legacy code from Scala Type Descriptors commit d4560802f92474dea426015e1ecb717aa6c8224f Author: Aljoscha Krettek aljoscha.kret...@gmail.com Date: 2015-05-12T08:49:53Z [hotfix][scala] Make Scala Type Analysis work with Java Tuples --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
