[GitHub] flink pull request: Updates the AssignerWithPunctuatedWatermarks a...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1811


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Updates the AssignerWithPunctuatedWatermarks a...

[kl0u]

Github user kl0u commented on the pull request:

https://github.com/apache/flink/pull/1811#issuecomment-205341434
  
No problem @StephanEwen ! 
Thanks for merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Updates the AssignerWithPunctuatedWatermarks a...

[StephanEwen]

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1811#issuecomment-205282506
  
Looks good, merging this...

Thanks for updating these docs!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Updates the AssignerWithPunctuatedWatermarks a...

[kl0u]

Github user kl0u commented on the pull request:

https://github.com/apache/flink/pull/1811#issuecomment-205202812
  
Hello! This PR simply updates the documentation to reflect recent changes 
to the code. 
Could somebody review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Updates the AssignerWithPunctuatedWatermarks a...

[kl0u]

Github user kl0u commented on the pull request:

https://github.com/apache/flink/pull/1811#issuecomment-203351512
  
This PR just updates documentation. 
Please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Updates the AssignerWithPunctuatedWatermarks a...

[kl0u]

Github user kl0u commented on the pull request:

https://github.com/apache/flink/pull/1811#issuecomment-201736998
  
This just updates the javadocs of the assigners. 

Please review!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Updates the AssignerWithPunctuatedWatermarks a...

[kl0u]

GitHub user kl0u opened a pull request:

https://github.com/apache/flink/pull/1811

Updates the AssignerWithPunctuatedWatermarks and the 
AssignerWithPeriodicWatermarks javadocs.

This PR is just to update the documentation of the aforementioned classes 
to reflect how they are actually used in the runtime code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kl0u/flink assignerDocs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1811.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1811


commit e6f667005d98a9d34e9901c7f101b60da044a9f5
Author: kl0u 
Date:   2016-03-17T11:37:30Z

Updates the AssignerWithPunctuatedWatermarks and the 
AssignerWithPeriodicWatermarks javadocs.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---