[GitHub] flink pull request #2503: [FLINK-4625] [core] Add a safety net to forcibly t...

2016-09-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2503


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request #2503: [FLINK-4625] [core] Add a safety net to forcibly t...

2016-09-15 Thread StephanEwen
GitHub user StephanEwen opened a pull request:

https://github.com/apache/flink/pull/2503

[FLINK-4625] [core] Add a safety net to forcibly terminate JVM if clean 
shutdown freezed.

Resource managers like YARN send the JVM the `SIGTERM` signal to kill the 
process.

With `SIGTERM`, the JVM shutdown hooks run, and may cause the process to 
freeze up during shutdown. Especially since all dependencies (like Hadoop) may 
install shutdown hooks (and do so), it is not in Flink's control to make sure 
all shutdown hooks are well behaved and never lock the JVM shutdown.

This pull requests adds a shutdown hook that calls `Runtime.halt()` after a 
delay. This forcibly terminates the JVM if clean shutdown does not succeed 
within a certain time (default is five seconds).

The pull request also adds tests that validate the behavior of JVM shutdown 
lockups and that the safety net ensures the process really shuts down.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/StephanEwen/incubator-flink process_self_kill

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2503.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2503


commit d5b9860773ec7aaf0b238544b794a10012d8dda5
Author: Stephan Ewen 
Date:   2016-09-15T17:27:06Z

[FLINK-4625] [core] Add a safety net to forcibly terminate JVM is clean 
shutdown freezed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---