[GitHub] flink pull request #2886: [FLINK-5179] Correct TM MetricRegistry and TmMG li...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2886


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2886: [FLINK-5179] Correct TM MetricRegistry and TmMG li...

[zentol]

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/2886#discussion_r90653350
  
--- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
 ---
@@ -1046,11 +1046,10 @@ class TaskManager(
   network.getKvStateRegistry.unregisterListener()
 }
 
-// failsafe shutdown of the metrics registry
 try {
-  metricsRegistry.shutdown()
+  taskManagerMetricGroup.close()
--- End diff --

That was already the case before this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2886: [FLINK-5179] Correct TM MetricRegistry and TmMG li...

[zentol]

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/2886#discussion_r90652945
  
--- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
 ---
@@ -1046,11 +1046,10 @@ class TaskManager(
   network.getKvStateRegistry.unregisterListener()
 }
 
-// failsafe shutdown of the metrics registry
 try {
-  metricsRegistry.shutdown()
+  taskManagerMetricGroup.close()
--- End diff --

When the taskmanager is shutdown, in postStop().


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2886: [FLINK-5179] Correct TM MetricRegistry and TmMG li...

[uce]

Github user uce commented on a diff in the pull request:

https://github.com/apache/flink/pull/2886#discussion_r90651728
  
--- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
 ---
@@ -1046,11 +1046,10 @@ class TaskManager(
   network.getKvStateRegistry.unregisterListener()
 }
 
-// failsafe shutdown of the metrics registry
 try {
-  metricsRegistry.shutdown()
+  taskManagerMetricGroup.close()
--- End diff --

When is this shut down then?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2886: [FLINK-5179] Correct TM MetricRegistry and TmMG li...

[zentol]

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/2886

[FLINK-5179] Correct TM MetricRegistry and TmMG lifecycle

This PR corrects the life-cycle of the MetricRegistry and 
TaskManagerMetricGroup of the TaskManager.

The MetricRegistry is no longer shutdown when the TaskManager disassociates 
from the JobManager; the registry, and by extension the reporters, will now 
live and be active as long as the TaskManager is running.

The TaskManagerMetricGroup is now properly closed when disassociating from 
the JobManager.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 5179_registry_lifecycle

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2886.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2886


commit 32ee9b30f6cff3b17d30ad9b1920afb711c5263c
Author: zentol 
Date:   2016-11-28T15:10:33Z

[FLINK-5179] Correct TM MetricRegistry and TmMG lifecycle




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---