[GitHub] flink pull request #2944: [FLINK-5261] Clean up meters in ScheduledDropwizar...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2944


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2944: [FLINK-5261] Clean up meters in ScheduledDropwizar...

[uce]

Github user uce commented on a diff in the pull request:

https://github.com/apache/flink/pull/2944#discussion_r90864551
  
--- Diff: 
flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java
 ---
@@ -91,6 +91,10 @@ protected ScheduledDropwizardReporter() {
return meters;
}
 
+   Map getGauges() { return gauges; }
--- End diff --

Can you do a new line for the return and add a annotation like 
`@VisibleForTesting`? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2944: [FLINK-5261] Clean up meters in ScheduledDropwizar...

[uce]

Github user uce commented on a diff in the pull request:

https://github.com/apache/flink/pull/2944#discussion_r90864749
  
--- Diff: 
flink-metrics/flink-metrics-dropwizard/src/test/java/org/apache/flink/dropwizard/ScheduledDropwizardReporterTest.java
 ---
@@ -124,6 +129,89 @@ public void testAddingMetrics() throws 
NoSuchFieldException, IllegalAccessExcept
metricRegistry.shutdown();
}
 
+   @Test
--- End diff --

Can you add a high level description about what this test does please? 
Otherwise this looks good. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2944: [FLINK-5261] Clean up meters in ScheduledDropwizar...

[uce]

Github user uce commented on a diff in the pull request:

https://github.com/apache/flink/pull/2944#discussion_r90864577
  
--- Diff: 
flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java
 ---
@@ -91,6 +91,10 @@ protected ScheduledDropwizardReporter() {
return meters;
}
 
+   Map getGauges() { return gauges; }
+
+   Map getHistograms() { return histograms; }
--- End diff --

Same here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2944: [FLINK-5261] Clean up meters in ScheduledDropwizar...

[zentol]

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/2944

[FLINK-5261] Clean up meters in ScheduledDropwizardReporter

This PR fixes the metric-cleanup in the `ScheduledDropwizardReporter`. We 
were missing a separate branch for meters within `notifyOfRemovedMetric`.

I've also added a test case to make sure that all metric types are properly 
cleaned up, both on our and and from the Dropwizard registry.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 5261_meter_cleanup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2944.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2944


commit b45795a7cfd0a27699f0a5e23d1b966b154afdf1
Author: zentol 
Date:   2016-12-05T13:00:10Z

[FLINK-5261] Clean up meters in ScheduledDropwizardReporter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---