[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...

2016-12-07 Thread mindprince
Github user mindprince closed the pull request at:

https://github.com/apache/flink/pull/2954


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...

2016-12-06 Thread mindprince
Github user mindprince commented on a diff in the pull request:

https://github.com/apache/flink/pull/2954#discussion_r91163739
  
--- Diff: docs/setup/fault_tolerance.md ---
@@ -45,9 +45,6 @@ To enable checkpointing, call `enableCheckpointing(n)` on 
the `StreamExecutionEn
 
 Other parameters for checkpointing include:
 
-- *Number of retries*: The `setNumberOfExecutionRerties()` method defines 
how many times the job is restarted after a failure.
--- End diff --

Removing from here because it will be taken care in 
https://github.com/apache/flink/pull/2951/files


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...

2016-12-06 Thread mindprince
Github user mindprince commented on a diff in the pull request:

https://github.com/apache/flink/pull/2954#discussion_r91163826
  
--- Diff: docs/setup/fault_tolerance.md ---
@@ -345,20 +342,6 @@ 
env.setRestartStrategy(RestartStrategies.fixedDelayRestart(
 
 
 
- Restart Attempts
--- End diff --

These were mostly the same content as above and made it very harder to read.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...

2016-12-06 Thread mindprince
GitHub user mindprince opened a pull request:

https://github.com/apache/flink/pull/2954

[docs] Note that numberOfExecutionRetries and executionRetryDelay are 
deprecated

And some other minor fixes and deduplication.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mindprince/flink docs-fix-3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2954.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2954


commit dbd08ea10e2261b060584d1dd8059f97bbac35ae
Author: Rohit Agarwal 
Date:   2016-12-06T20:21:38Z

[docs] Note that numberOfExecutionRetries and executionRetryDelay are 
deprecated.

And some other minor fixes and deduplication.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---