[GitHub] flink pull request #3037: Flink-4450 update storm version to 1.0

[liuyuzhong7]

Github user liuyuzhong7 commented on a diff in the pull request:

https://github.com/apache/flink/pull/3037#discussion_r96388944
  
--- Diff: 
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
 ---
@@ -186,15 +186,15 @@ public void testCreateTopologyContext() {
.shuffleGrouping("bolt2", 
TestDummyBolt.groupingStreamId)
.shuffleGrouping("bolt2", 
TestDummyBolt.shuffleStreamId);
 
-   LocalCluster cluster = new LocalCluster();
-   Config c = new Config();
-   c.setNumAckers(0);
-   cluster.submitTopology("test", c, builder.createTopology());
-
-   while (TestSink.result.size() != 8) {
-   Utils.sleep(100);
-   }
-   cluster.shutdown();
+// LocalCluster cluster = new LocalCluster();
--- End diff --

OK, I open new issue in 
[FLINK-5522](https://issues.apache.org/jira/browse/FLINK-5522)

The reason is: Local Cluster can't run with powermock.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3037: Flink-4450 update storm version to 1.0

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/3037


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3037: Flink-4450 update storm version to 1.0

[StephanEwen]

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/3037#discussion_r96221118
  
--- Diff: 
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
 ---
@@ -186,15 +186,15 @@ public void testCreateTopologyContext() {
.shuffleGrouping("bolt2", 
TestDummyBolt.groupingStreamId)
.shuffleGrouping("bolt2", 
TestDummyBolt.shuffleStreamId);
 
-   LocalCluster cluster = new LocalCluster();
-   Config c = new Config();
-   c.setNumAckers(0);
-   cluster.submitTopology("test", c, builder.createTopology());
-
-   while (TestSink.result.size() != 8) {
-   Utils.sleep(100);
-   }
-   cluster.shutdown();
+// LocalCluster cluster = new LocalCluster();
--- End diff --

That's okay. Can you open a JIRA issue for that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3037: Flink-4450 update storm version to 1.0

[liuyuzhong7]

Github user liuyuzhong7 commented on a diff in the pull request:

https://github.com/apache/flink/pull/3037#discussion_r96218769
  
--- Diff: 
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
 ---
@@ -186,15 +186,15 @@ public void testCreateTopologyContext() {
.shuffleGrouping("bolt2", 
TestDummyBolt.groupingStreamId)
.shuffleGrouping("bolt2", 
TestDummyBolt.shuffleStreamId);
 
-   LocalCluster cluster = new LocalCluster();
-   Config c = new Config();
-   c.setNumAckers(0);
-   cluster.submitTopology("test", c, builder.createTopology());
-
-   while (TestSink.result.size() != 8) {
-   Utils.sleep(100);
-   }
-   cluster.shutdown();
+// LocalCluster cluster = new LocalCluster();
--- End diff --

Local Cluster still work in Storm post 1.0, but It can't work in this 
version by this code, and I didn't find the solution. 

How about I solve it later in new pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3037: Flink-4450 update storm version to 1.0

[StephanEwen]

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/3037#discussion_r95967912
  
--- Diff: 
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
 ---
@@ -186,15 +186,15 @@ public void testCreateTopologyContext() {
.shuffleGrouping("bolt2", 
TestDummyBolt.groupingStreamId)
.shuffleGrouping("bolt2", 
TestDummyBolt.shuffleStreamId);
 
-   LocalCluster cluster = new LocalCluster();
-   Config c = new Config();
-   c.setNumAckers(0);
-   cluster.submitTopology("test", c, builder.createTopology());
-
-   while (TestSink.result.size() != 8) {
-   Utils.sleep(100);
-   }
-   cluster.shutdown();
+// LocalCluster cluster = new LocalCluster();
--- End diff --

Is there an alternative way to do this, or is there no local cluster in 
Storm 1.0 any more?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3037: Flink-4450 update storm version to 1.0

[liuyuzhong7]

Github user liuyuzhong7 commented on a diff in the pull request:

https://github.com/apache/flink/pull/3037#discussion_r95098787
  
--- Diff: 
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
 ---
@@ -186,15 +186,15 @@ public void testCreateTopologyContext() {
.shuffleGrouping("bolt2", 
TestDummyBolt.groupingStreamId)
.shuffleGrouping("bolt2", 
TestDummyBolt.shuffleStreamId);
 
-   LocalCluster cluster = new LocalCluster();
-   Config c = new Config();
-   c.setNumAckers(0);
-   cluster.submitTopology("test", c, builder.createTopology());
-
-   while (TestSink.result.size() != 8) {
-   Utils.sleep(100);
-   }
-   cluster.shutdown();
+// LocalCluster cluster = new LocalCluster();
--- End diff --

Yes , It can't work with Strom 1.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3037: Flink-4450 update storm version to 1.0

[StephanEwen]

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/3037#discussion_r9492
  
--- Diff: 
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
 ---
@@ -186,15 +186,15 @@ public void testCreateTopologyContext() {
.shuffleGrouping("bolt2", 
TestDummyBolt.groupingStreamId)
.shuffleGrouping("bolt2", 
TestDummyBolt.shuffleStreamId);
 
-   LocalCluster cluster = new LocalCluster();
-   Config c = new Config();
-   c.setNumAckers(0);
-   cluster.submitTopology("test", c, builder.createTopology());
-
-   while (TestSink.result.size() != 8) {
-   Utils.sleep(100);
-   }
-   cluster.shutdown();
+// LocalCluster cluster = new LocalCluster();
--- End diff --

Are these lines accidentally commented out, or is this not working with 
Storm 1.0 any more?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3037: Flink-4450 update storm version to 1.0

[liuyuzhong7]

GitHub user liuyuzhong7 opened a pull request:

https://github.com/apache/flink/pull/3037

Flink-4450 update storm version to 1.0

@StephanEwen @mxm 
The old pull request #2439  was wrong , I use this account make a new pull 
request.

Please me to review this pull request.

Storm example Test:

![image](https://cloud.githubusercontent.com/assets/24708126/21415644/33789972-c847-11e6-9846-16bc623dce21.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liuyuzhong7/flink FLINK-4450

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3037.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3037


commit 02596f71f8c1ac77b0ade49113a80b07f15cd337
Author: yuzhongliu 
Date:   2016-12-22T03:36:37Z

#FLINK-4450 update storm version to 1.0

commit 2b15f5d4234c074c8764768a4f329363de077c09
Author: liuyuzhong7 
Date:   2016-12-22T04:52:28Z

#FLINK-4450 format pom.xml

commit 77f228041b5652dc1b2015e6ef4bcda3313c1ae6
Author: liuyuzhong7 
Date:   2016-12-22T05:09:49Z

#FLINK-4450 fix mvn clean verify error




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---