[GitHub] flink pull request #3563: [FLINK-2814] [optimizer] DualInputPlanNode cannot ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/3563


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3563: [FLINK-2814] [optimizer] DualInputPlanNode cannot ...

[greghogan]

GitHub user greghogan opened a pull request:

https://github.com/apache/flink/pull/3563

[FLINK-2814] [optimizer] DualInputPlanNode cannot be cast to 
SingleInputPlanNode

WorksetIterationNode#instantiate loops over all solution and work set 
candidates. Since the solution set reference is modified in place when the 
predecessor node can be used in its place, swith this variable to the inner 
loop.

@StephanEwen this is similar to #2029 but resets the reference in the loop. 
I believe my prior suggestion to immediately return upon adding a node was 
incorrect as the `instantiate` methods look to be compiling all valid 
combinations.

IntelliJ code coverage on `flink-optimizer` shows 105 hits through 
`WorksetIterationNode#instantiate` and it does fix this issue with my Katz 
Centrality algorithm (which should not be using delta iterations, but I was 
young and naive when I wrote it).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/greghogan/flink 
2814_deltaiteration_dualinputplannode_cannot_be_cast_to_singleinputplannode

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3563.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3563


commit 34f017834e17fa69e2b7c72bd95e1a819e4e6aa3
Author: Greg Hogan 
Date:   2017-03-17T16:09:34Z

[FLINK-2814] [optimizer] DualInputPlanNode cannot be cast to 
SingleInputPlanNode

WorksetIterationNode#instantiate loops over all solution and work set
candidates. Since the solution set reference is modified in place when
the predecessor node can be used in its place, swith this variable to
the inner loop.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---