[GitHub] flink pull request #3602: [FLINK-5715] Asynchronous snapshots for heap keyed...

[StefanRRichter]

Github user StefanRRichter closed the pull request at:

https://github.com/apache/flink/pull/3602


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3602: [FLINK-5715] Asynchronous snapshots for heap keyed...

[StefanRRichter]

Github user StefanRRichter commented on a diff in the pull request:

https://github.com/apache/flink/pull/3602#discussion_r107935639
  
--- Diff: 
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AbstractEventTimeWindowCheckpointingITCase.java
 ---
@@ -115,6 +117,14 @@ public static void stopTestCluster() {
@Before
public void initStateBackend() throws IOException {
switch (stateBackendEnum) {
+   case MEM_ASYNC:
+   this.stateBackend = new 
AsyncMemoryStateBackend(MAX_MEM_STATE_SIZE);
+   break;
+   case FILE_ASYNC: {
+   String backups = 
tempFolder.newFolder().getAbsolutePath();
+   this.stateBackend = new 
AsyncFsStateBackend("file://" + backups);
--- End diff --

That is true. This similar issue should have been there, because this is 
basically just copy-paste from the `case FILE`. I will fix both.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3602: [FLINK-5715] Asynchronous snapshots for heap keyed...

[StephanEwen]

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/3602#discussion_r107931282
  
--- Diff: 
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AbstractEventTimeWindowCheckpointingITCase.java
 ---
@@ -115,6 +117,14 @@ public static void stopTestCluster() {
@Before
public void initStateBackend() throws IOException {
switch (stateBackendEnum) {
+   case MEM_ASYNC:
+   this.stateBackend = new 
AsyncMemoryStateBackend(MAX_MEM_STATE_SIZE);
+   break;
+   case FILE_ASYNC: {
+   String backups = 
tempFolder.newFolder().getAbsolutePath();
+   this.stateBackend = new 
AsyncFsStateBackend("file://" + backups);
--- End diff --

To make this work cross platform, always use `file.toUri()` or `new 
Path(file.toUri())`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3602: [FLINK-5715] Asynchronous snapshots for heap keyed...

[StefanRRichter]

GitHub user StefanRRichter opened a pull request:

https://github.com/apache/flink/pull/3602

[FLINK-5715] Asynchronous snapshots for heap keyed state backend (BACKPORT)

Backport of PR #3466 from 1.3-snapshot to 1.2.  Introduces asynchronous 
snapshots for heap keyed state backend.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/StefanRRichter/flink async-backport

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3602.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3602


commit c40a8d18a5b1c9f3ccd84701bbe1bd7d4a00924c
Author: Stefan Richter 
Date:   2017-03-23T10:36:56Z

[FLINK-5715] Asynchronous snapshots for heap-based keyed state backend 
(backport from 1.3)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---