[GitHub] flink pull request #3855: [FLINK-6496] Port SSl config parameters to ConfigO...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/3855


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3855: [FLINK-6496] Port SSl config parameters to ConfigO...

[tzulitai]

Github user tzulitai commented on a diff in the pull request:

https://github.com/apache/flink/pull/3855#discussion_r124972967
  
--- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java
 ---
@@ -35,6 +35,7 @@
 import org.apache.flink.configuration.ConfigConstants;
--- End diff --

Ah wait, checkstyle isn't enabled for this module yet?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3855: [FLINK-6496] Port SSl config parameters to ConfigO...

[zentol]

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3855#discussion_r124973801
  
--- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java
 ---
@@ -35,6 +35,7 @@
 import org.apache.flink.configuration.ConfigConstants;
--- End diff --

Only small parts of flink-runtime are covered by checkstle.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3855: [FLINK-6496] Port SSl config parameters to ConfigO...

[zentol]

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3855#discussion_r124973760
  
--- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java
 ---
@@ -35,6 +35,7 @@
 import org.apache.flink.configuration.ConfigConstants;
--- End diff --

no :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3855: [FLINK-6496] Port SSl config parameters to ConfigO...

[tzulitai]

Github user tzulitai commented on a diff in the pull request:

https://github.com/apache/flink/pull/3855#discussion_r124970162
  
--- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java
 ---
@@ -35,6 +35,7 @@
 import org.apache.flink.configuration.ConfigConstants;
--- End diff --

This should violate checkstyle. Import non used anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3855: [FLINK-6496] Port SSl config parameters to ConfigO...

[tzulitai]

Github user tzulitai commented on a diff in the pull request:

https://github.com/apache/flink/pull/3855#discussion_r124969948
  
--- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala ---
@@ -26,7 +26,7 @@ import akka.actor._
 import akka.pattern.{ask => akkaAsk}
 import com.typesafe.config.{Config, ConfigFactory}
 import org.apache.flink.api.common.time.Time
-import org.apache.flink.configuration.{AkkaOptions, ConfigConstants, 
Configuration}
+import org.apache.flink.configuration.{AkkaOptions, ConfigConstants, 
Configuration, SecurityOptions}
--- End diff --

`ConfigConstants` can be removed from the imports.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3855: [FLINK-6496] Port SSl config parameters to ConfigO...

[tzulitai]

Github user tzulitai commented on a diff in the pull request:

https://github.com/apache/flink/pull/3855#discussion_r124970218
  
--- Diff: 
flink-runtime/src/test/scala/org/apache/flink/runtime/akka/AkkaSslITCase.scala 
---
@@ -20,8 +20,8 @@ package org.apache.flink.runtime.akka
 
 import akka.actor.ActorSystem
 import akka.testkit.{ImplicitSender, TestKit}
-import org.apache.flink.configuration.{AkkaOptions, ConfigConstants, 
Configuration}
-import org.apache.flink.runtime.testingUtils.{TestingCluster, 
TestingUtils, ScalaTestingUtils}
+import org.apache.flink.configuration.{AkkaOptions, ConfigConstants, 
Configuration, SecurityOptions}
--- End diff --

Remove `ConfigConstants`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3855: [FLINK-6496] Port SSl config parameters to ConfigO...

[zentol]

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/3855

[FLINK-6496] Port SSl config parameters to ConfigOptions

This PR ports all SSL config parameters to config options.

The PR contains 1 commit for each ported parameter.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 6496_config_ssl

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3855.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3855


commit 71cd8224e1d58a8705963ae89dfae34040ac9e74
Author: zentol 
Date:   2017-05-09T08:46:18Z

SecurityOptions#SSL_ENABLED

commit 85bf02f24e2308c095ab3e62fa267a5be5d0e3ff
Author: zentol 
Date:   2017-05-09T08:51:54Z

SecurityOptions#SSL_KEYSTORE

commit 3a7f14da54ad023135271c58a36ede4bc94a929a
Author: zentol 
Date:   2017-05-09T08:58:36Z

SecurityOptions#SSL_KEYSTORE_PASSWORD

commit 7fb4a5291b9361f97222bbfc8ea2c372256c6a4c
Author: zentol 
Date:   2017-05-09T09:29:06Z

SecurityOptions#SSL_KEY_PASSWORD

commit df6c02081d284cfde05492715e7f8bdc1483f2ce
Author: zentol 
Date:   2017-05-09T09:32:40Z

SecurityOptions#SSL_TRUSTSTORE

commit 6b59bf82a077eeec72b922e01d76c00974b5ebef
Author: zentol 
Date:   2017-05-09T09:37:15Z

SecurityOptions#SSL_TRUSTSTORE_PASSWORD

commit 7ada12d31db11a8caf422b6553ee20cf6312eed4
Author: zentol 
Date:   2017-05-09T09:40:49Z

SecurityOptions#SSL_PROTOCOL

commit 37efea483302d57260483ea32f351f8d2efaf1a4
Author: zentol 
Date:   2017-05-09T09:43:44Z

SecurityOptions#SSL_ALGORITHMS

commit fa0e90f0768f41c3ef6024bf2a5980fecc2eca88
Author: zentol 
Date:   2017-05-09T09:46:18Z

SecurityOptions#SSL_VERIFY_HOSTNAME




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---