[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4133 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4133#discussion_r122389818
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -652,6 +653,21 @@ case class WindowAggregate(
case ValidationSuccess => // ok
}
+// validate property
+if (propertyExpressions.nonEmpty) {
+ resolvedWindowAggregate.window match {
+case TumblingGroupWindow(_, _, size) if isRowCountLiteral(size) =>
+ failValidation("Window start and Window end are not accessed " +
+ "on row-counts Tumbling window.")
--- End diff --
Thank you @sunjincheng121 @fhueske for the suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4133#discussion_r122388804
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -652,6 +653,21 @@ case class WindowAggregate(
case ValidationSuccess => // ok
}
+// validate property
+if (propertyExpressions.nonEmpty) {
+ resolvedWindowAggregate.window match {
+case TumblingGroupWindow(_, _, size) if isRowCountLiteral(size) =>
+ failValidation("Window start and Window end are not accessed " +
+ "on row-counts Tumbling window.")
--- End diff --
How about `"Window start and Window end cannot be selected for a row-count
Tumbing window."`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4133#discussion_r122378782
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -652,6 +653,21 @@ case class WindowAggregate(
case ValidationSuccess => // ok
}
+// validate property
+if (propertyExpressions.nonEmpty) {
+ resolvedWindowAggregate.window match {
+case TumblingGroupWindow(_, _, size) if isRowCountLiteral(size) =>
+ failValidation("Window start and Window end are not accessed " +
+ "on row-counts Tumbling window.")
+
+case SlidingGroupWindow(_, _, size, _) if isRowCountLiteral(size)
=>
+ failValidation("Window start and Window end are not accessed " +
+ "on row-counts Sliding window.")
--- End diff --
`row-counts` -> `row-count`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4133#discussion_r122378757
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -652,6 +653,21 @@ case class WindowAggregate(
case ValidationSuccess => // ok
}
+// validate property
+if (propertyExpressions.nonEmpty) {
+ resolvedWindowAggregate.window match {
+case TumblingGroupWindow(_, _, size) if isRowCountLiteral(size) =>
+ failValidation("Window start and Window end are not accessed " +
+ "on row-counts Tumbling window.")
--- End diff --
`row-counts` -> `row-count`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4133
[FLINK-6930] [table] Forbid selecting window start/end on row-based
Tumble/Slide windows
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wuchong/flink forbid-rowbased-window-start
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4133.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4133
commit 4cf422acd25b18ebc285ace542d49ebc646707db
Author: Jark Wu
Date: 2017-06-16T03:49:31Z
[FLINK-6930] [table] Forbid selecting window start/end on row-based
Tumble/Slide windows
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
