[GitHub] flink pull request #4160: {FLINK-6965] Include snappy-java in flink-dist

2017-07-11 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4160


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4160: {FLINK-6965] Include snappy-java in flink-dist

2017-06-26 Thread zentol 
Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/4160#discussion_r123971846
  
--- Diff: tools/travis_mvn_watchdog.sh ---
@@ -182,6 +182,13 @@ check_shaded_artifacts() {
exit 1
fi
 
+   SNAPPY=`cat allClasses | grep '^org/xerial/snappy' | wc -l`
+   if [ AVRO == "0" ]; then
--- End diff --

yes! nice catch...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4160: {FLINK-6965] Include snappy-java in flink-dist

2017-06-25 Thread packet23 
Github user packet23 commented on a diff in the pull request:

https://github.com/apache/flink/pull/4160#discussion_r123909436
  
--- Diff: tools/travis_mvn_watchdog.sh ---
@@ -182,6 +182,13 @@ check_shaded_artifacts() {
exit 1
fi
 
+   SNAPPY=`cat allClasses | grep '^org/xerial/snappy' | wc -l`
+   if [ AVRO == "0" ]; then
--- End diff --

Should it not read
```bash
if [ $SNAPPY == "0" ]; then
   # bail out
fi
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4160: {FLINK-6965] Include snappy-java in flink-dist

2017-06-21 Thread zentol 
Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/4160#discussion_r123341447
  
--- Diff: flink-core/pom.xml ---
@@ -79,13 +79,12 @@ under the License.

org.apache.avro
avro
-   
-   
-   
-   org.xerial.snappy
-   snappy-java
-   
-   
+   
+
+   
--- End diff --

for the avro/snappy case, no. This PR should work as is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4160: {FLINK-6965] Include snappy-java in flink-dist

2017-06-21 Thread tzulitai 
Github user tzulitai commented on a diff in the pull request:

https://github.com/apache/flink/pull/4160#discussion_r123298637
  
--- Diff: flink-core/pom.xml ---
@@ -79,13 +79,12 @@ under the License.

org.apache.avro
avro
-   
-   
-   
-   org.xerial.snappy
-   snappy-java
-   
-   
+   
+
+   
--- End diff --

Side question: is a fix also required for connectors to correctly use the 
user classloader in such cases?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4160: {FLINK-6965] Include snappy-java in flink-dist

2017-06-21 Thread zentol 
GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/4160

{FLINK-6965] Include snappy-java in flink-dist

This PR adds removes the snappy dependency exclusion from flink-core.

Without this dependency Flink components that work with avro, and thus 
potentially snappy, fail when loading snappy. This also happens if snappy is 
provided in the user-jar since the flink component doesn't use the user class 
loader.

To prevent this dependency from being removed again in the future by 
accident i modified `checkShadedArtifacts()` function in the travis scripts to 
check for the presence of the dependency.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 6965

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4160


commit f0e757776c45382cfc28daefe321d819d5a4a75c
Author: zentol 
Date:   2017-06-21T14:18:34Z

{FLINK-6965] Include snappy-java in flink-dist




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---