GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4498
[FLINK-7387] [rpc] Require RpcEndpoints to directly implement RpcGateways
## What is the purpose of the change
This commit changes the relation between `RpcEndpoints` and `RpcGateways`.
From now on,
the `RpcEndpoints` have to implement the `RpcGateways` they want to support
instead of
coupling it loosely via a type parameter. In order to obtain self gateway a
new
method `RpcEndpoint#getSelfGateway(Class)` has been introduced. This method
can be used
to obtain the `RpcGateway` type at run time to talk to the `RpcEndpoint`
asynchronously.
All existing `RpcEndpoints` have been adapted to the new model. This
basically means
that they now return a CompletableFuture instead of X.
## Brief change log
- Introduce `RpcServer` to encapsulate functionality previously contained
in `RpcEndpoint's` self gateway
- Adapt `RpcService` to start `RpcServer` with correct type bounds
- Let `RpcEndpoints` implement their respective `RpcGateways`
- Remove `RpcCompletenessTest` and `RpcMethod`
## Verifying this change
This change is already covered by existing tests:
- `AsyncCallsTest`, `AkkaRpcServiceTest`, `AkkaRpcActorTest`
This change added tests and can be verified as follows:
- Added `RpcEndpointTest` to ensure that extending `RpcEndpoints` works
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes (but only Flip-6))
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink rpcRework
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4498.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4498
commit 858b27b96bf40377dba73a11bcd31d488b9a68cc
Author: Till Rohrmann
Date: 2017-08-08T12:43:47Z
[FLINK-7387] [rpc] Require RpcEndpoints to directly implement RpcGateways
This commit changes the relation between RpcEndpoints and RpcGateways. From
now on,
the RpcEndpoints have to implement the RpcGateways they want to support
instead of
coupling it loosely via a type parameter. In order to obtain self gateway a
new
method RpcEndpoint#getSelfGateway(Class) has been introduced. This method
can be used
to obtain the RpcGateway type at run time to talk to the RpcEndpoint
asynchronously.
All existing RpcEndpoints have been adapted to the new model. This
basically means
that they now return a CompletableFuture instead of X.
Add RpcEndpointTest
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
