[GitHub] flink pull request #4777: [FLINK-7739] Enable dependency convergence

[pnowojski]

Github user pnowojski commented on a diff in the pull request:

https://github.com/apache/flink/pull/4777#discussion_r143480344
  
--- Diff: flink-core/pom.xml ---
@@ -77,6 +88,12 @@ under the License.

org.apache.commons
commons-compress
+   
+   
--- End diff --

`avro` is pulling `xz` as well

```
[INFO] +- org.apache.avro:avro:jar:1.8.2:compile
[INFO] |  +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
[INFO] |  +- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile
[INFO] |  +- com.thoughtworks.paranamer:paranamer:jar:2.7:compile
[INFO] |  \- org.tukaani:xz:jar:1.5:compile
```


---

[GitHub] flink pull request #4777: [FLINK-7739] Enable dependency convergence

[StephanEwen]

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/4777#discussion_r143253601
  
--- Diff: flink-core/pom.xml ---
@@ -77,6 +88,12 @@ under the License.

org.apache.commons
commons-compress
+   
+   
--- End diff --

This seems to be an exclusion without replacement. By accident?


---

[GitHub] flink pull request #4777: [FLINK-7739] Enable dependency convergence

[StephanEwen]

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/4777#discussion_r143252870
  
--- Diff: flink-core/pom.xml ---
@@ -63,9 +63,20 @@ under the License.

com.esotericsoftware.kryo
kryo
+   
--- End diff --

I think if you add a dependency in the same pom (as below) you don't need 
the exclusion any more.


---

[GitHub] flink pull request #4777: [FLINK-7739] Enable dependency convergence

[StephanEwen]

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/4777#discussion_r143253445
  
--- Diff: pom.xml ---
@@ -1181,7 +1204,7 @@ under the License.

org.apache.maven.plugins
maven-enforcer-plugin
-   1.4.1
+   
${enforcer.version}
--- End diff --

How about defining the plugin in the plugin management section, rather than 
using a variable? I think that is the more maintainable solution in the log run.


---