[GitHub] flink pull request #4874: [hotfix] [docs] Update the description of time-win...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4874


---

[GitHub] flink pull request #4874: [hotfix] [docs] Update the description of time-win...

[fhueske]

Github user fhueske commented on a diff in the pull request:

https://github.com/apache/flink/pull/4874#discussion_r146069345
  
--- Diff: docs/dev/table/sql.md ---
@@ -400,15 +400,14 @@ FROM Orders LEFT JOIN Product ON Orders.productId = 
Product.id
   
 Note: Time-windowed joins are a subset of regular joins 
that can be processed in a streaming fashion.
 
-A time-windowed join requires a special join condition that 
bounds the time on both sides. This can be done by either two appropriate range 
predicates ( , =, =, ) or a BETWEEN 
predicate that compares the time 
attributes of both input tables. The following rules apply for time 
predicates:
+A time-windowed join requires an equi-join predicate and a 
special join condition that bounds the time on both sides. Such a condition can 
be defined by two appropriate range predicates (, =, =, 
) that compare the time 
attributes of both input tables. The following rules apply for time 
predicates:
--- End diff --

two range predicates or a `BETWEEN` predicate. `BETWEEN` is not available 
in Table API yet.


---

[GitHub] flink pull request #4874: [hotfix] [docs] Update the description of time-win...

[xccui]

GitHub user xccui opened a pull request:

https://github.com/apache/flink/pull/4874

[hotfix] [docs] Update the description of time-windowed join for SQL doc

## What is the purpose of the change

This PR updates the description of time-windowed join in the SQL doc page.

## Brief change log

  - Synchronize the description of time-windowed join from the tableApi doc 
page.

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (*no*)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (*no*)
  - The serializers: (*no*)
  - The runtime per-record code paths (performance sensitive): (*no*)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (*no*)

## Documentation

  - Does this pull request introduce a new feature? (*no*)
  - If yes, how is the feature documented? (*docs*)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xccui/flink tempDoc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4874.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4874


commit 4abb0bb46cf14dea5e17614bd7bc1d2864c67e68
Author: Xingcan Cui 
Date:   2017-10-20T14:52:52Z

[hotfix] [docs] Synchronize the description of time-windowed join from 
tableApi




---