[GitHub] flink pull request #5156: [FLINK-8079][tests] Stop end-to-end test execution...

2018-01-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/5156


---


[GitHub] flink pull request #5156: [FLINK-8079][tests] Stop end-to-end test execution...

2018-01-08 Thread zentol
Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/5156#discussion_r160148368
  
--- Diff: tools/travis_mvn_watchdog.sh ---
@@ -543,35 +543,45 @@ case $TEST in
printf "Running end-to-end tests\n"
printf 
"==\n"
 
-   printf 
"\n==\n"
-   printf "Running Wordcount end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_batch_wordcount.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running Kafka end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_streaming_kafka010.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running class loading end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_streaming_classloader.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running Shaded Hadoop S3A end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_shaded_hadoop_s3a.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running Shaded Presto S3 end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_shaded_presto_s3.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
+   if [ $EXIT_CODE == 0 ]; then
+   printf 
"\n==\n"
+   printf "Running Wordcount end-to-end test\n"
+   printf 
"==\n"
+   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_batch_wordcount.sh
+   EXIT_CODE=$(($EXIT_CODE+$?))
--- End diff --

jup we can simplify things now.


---


[GitHub] flink pull request #5156: [FLINK-8079][tests] Stop end-to-end test execution...

2017-12-20 Thread greghogan
Github user greghogan commented on a diff in the pull request:

https://github.com/apache/flink/pull/5156#discussion_r158037581
  
--- Diff: tools/travis_mvn_watchdog.sh ---
@@ -543,35 +543,45 @@ case $TEST in
printf "Running end-to-end tests\n"
printf 
"==\n"
 
-   printf 
"\n==\n"
-   printf "Running Wordcount end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_batch_wordcount.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running Kafka end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_streaming_kafka010.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running class loading end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_streaming_classloader.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running Shaded Hadoop S3A end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_shaded_hadoop_s3a.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running Shaded Presto S3 end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_shaded_presto_s3.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
+   if [ $EXIT_CODE == 0 ]; then
+   printf 
"\n==\n"
+   printf "Running Wordcount end-to-end test\n"
+   printf 
"==\n"
+   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_batch_wordcount.sh
+   EXIT_CODE=$(($EXIT_CODE+$?))
--- End diff --

If `$EXIT_CODE == 0` then why not simply set `EXIT_CODE=$?`?


---


[GitHub] flink pull request #5156: [FLINK-8079][tests] Stop end-to-end test execution...

2017-12-12 Thread zentol
GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/5156

[FLINK-8079][tests] Stop end-to-end test execution after first failure

## What is the purpose of the change

This PR modifies the travis maven script to stop the execution of 
end-to-end tests once the first failure was detected.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 8079

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5156


commit 3faf3707a3134cfdd40bfa0870d4e3e01579e10b
Author: zentol 
Date:   2017-12-12T13:04:34Z

[FLINK-8079][tests] Stop end-to-end test execution after first failure




---