[GitHub] flink pull request #5478: [FLINK-8647] [flip6] Introduce JobMasterConfigurat...

[tillrohrmann]

Github user tillrohrmann closed the pull request at:

https://github.com/apache/flink/pull/5478


---

[GitHub] flink pull request #5478: [FLINK-8647] [flip6] Introduce JobMasterConfigurat...

[tillrohrmann]

Github user tillrohrmann commented on a diff in the pull request:

https://github.com/apache/flink/pull/5478#discussion_r168171127
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
 ---
@@ -698,7 +707,7 @@ else if (numConsumers == 0) {
executor);
 
// double check to resolve race conditions
-   if(consumerVertex.getExecutionState() == 
RUNNING){
+   if (consumerVertex.getExecutionState() == 
RUNNING){
consumerVertex.sendPartitionInfos();
--- End diff --

Good catch @zhangminglei. Will fix it.


---

[GitHub] flink pull request #5478: [FLINK-8647] [flip6] Introduce JobMasterConfigurat...

[zhangminglei]

Github user zhangminglei commented on a diff in the pull request:

https://github.com/apache/flink/pull/5478#discussion_r168166947
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
 ---
@@ -698,7 +707,7 @@ else if (numConsumers == 0) {
executor);
 
// double check to resolve race conditions
-   if(consumerVertex.getExecutionState() == 
RUNNING){
+   if (consumerVertex.getExecutionState() == 
RUNNING){
consumerVertex.sendPartitionInfos();
--- End diff --

It seems missing a space after ```if``` statement.


---

[GitHub] flink pull request #5478: [FLINK-8647] [flip6] Introduce JobMasterConfigurat...

[tillrohrmann]

GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/5478

[FLINK-8647] [flip6] Introduce JobMasterConfiguration

## What is the purpose of the change

This commit introduces a JobMasterConfiguration which contains JobMaster 
specific
configuration settings.

This PR is based on #5475.

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  - The S3 file system connector: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink 
introduceJobMasterConfiguration

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5478.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5478


commit 74bad98878a10bade8a1c5730b962599f479c6d8
Author: Till Rohrmann 
Date:   2018-02-13T11:41:44Z

[FLINK-8643] [flip6] Use JobManagerOptions#SLOT_REQUEST_TIMEOUT in 
ExecutionGraph

This commit changes the initialization of the ExecutionGraph to use the
JobManagerOptions#SLOT_REQUEST_TIMEOUT for the slot allocation. Furthermore,
it changes the behaviour of the SlotPool#ProviderAndOwner implementation 
such
that the timeout is given to it via the SlotProvider#allocateSlot call.

commit ac83405419330762fce0ef307089609a993749e5
Author: Till Rohrmann 
Date:   2018-02-13T12:18:01Z

[hotfix] [flip6] Remove unnecessary timeout from SlotPool

commit 5fb9ba3b5f36a8486365dc3055f6a460d758e093
Author: Till Rohrmann 
Date:   2018-02-13T14:33:11Z

[FLINK-8647] [flip6] Introduce JobMasterConfiguration

This commit introduces a JobMasterConfiguration which contains JobMaster 
specific
configuration settings.




---