[GitHub] flink pull request #5542: [FLINK-8703][tests] Migrate tests from LocalFlinkM...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5542 ---
[GitHub] flink pull request #5542: [FLINK-8703][tests] Migrate tests from LocalFlinkM...
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5542#discussion_r169714628
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/BigUserProgramJobSubmitITCase.java
---
@@ -43,40 +40,27 @@
/**
* Integration test that verifies that a user program with a big(ger)
payload is successfully
* submitted and run.
+ *
+ * This test fails for non-flip6 cluster due to job submission payload
being too large, see [FLINK-7285].
*/
-@Ignore("Fails on job submission payload being too large - [FLINK-7285]")
+@Category(Flip6.class)
public class BigUserProgramJobSubmitITCase extends TestLogger {
//
// The mini cluster that is shared across tests
//
- private static final int DEFAULT_PARALLELISM = 1;
-
- private static LocalFlinkMiniCluster cluster;
-
- private static final Logger LOG =
LoggerFactory.getLogger(BigUserProgramJobSubmitITCase.class);
+ @ClassRule
+ public static final MiniClusterResource MINI_CLUSTER_RESOURCE = new
MiniClusterResource(
+ new MiniClusterResource.MiniClusterResourceConfiguration(
+ new Configuration(),
+ 1,
+ 1));
//
// Cluster setup & teardown
//
- @BeforeClass
- public static void setup() throws Exception {
- // make sure we do not use a singleActorSystem for the tests
- // (therefore, we cannot simply inherit from
StreamingMultipleProgramsTestBase)
--- End diff --
maybe it does succeed exactly because of that. If everything runs in the
same actorSystem the messagesa ren't subject to the `akka.framesize` limit.
---
[GitHub] flink pull request #5542: [FLINK-8703][tests] Migrate tests from LocalFlinkM...
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/5542#discussion_r169648970
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/BigUserProgramJobSubmitITCase.java
---
@@ -43,40 +40,27 @@
/**
* Integration test that verifies that a user program with a big(ger)
payload is successfully
* submitted and run.
+ *
+ * This test fails for non-flip6 cluster due to job submission payload
being too large, see [FLINK-7285].
*/
-@Ignore("Fails on job submission payload being too large - [FLINK-7285]")
+@Category(Flip6.class)
public class BigUserProgramJobSubmitITCase extends TestLogger {
//
// The mini cluster that is shared across tests
//
- private static final int DEFAULT_PARALLELISM = 1;
-
- private static LocalFlinkMiniCluster cluster;
-
- private static final Logger LOG =
LoggerFactory.getLogger(BigUserProgramJobSubmitITCase.class);
+ @ClassRule
+ public static final MiniClusterResource MINI_CLUSTER_RESOURCE = new
MiniClusterResource(
+ new MiniClusterResource.MiniClusterResourceConfiguration(
+ new Configuration(),
+ 1,
+ 1));
//
// Cluster setup & teardown
//
- @BeforeClass
- public static void setup() throws Exception {
- // make sure we do not use a singleActorSystem for the tests
- // (therefore, we cannot simply inherit from
StreamingMultipleProgramsTestBase)
--- End diff --
Doesn't the `MiniClusterResource` always start the cluster with a single
actor system? I'm wondering why this test succeeds then.
---
[GitHub] flink pull request #5542: [FLINK-8703][tests] Migrate tests from LocalFlinkM...
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/5542#discussion_r169647902
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/BigUserProgramJobSubmitITCase.java
---
@@ -43,40 +40,27 @@
/**
* Integration test that verifies that a user program with a big(ger)
payload is successfully
* submitted and run.
+ *
+ * This test fails for non-flip6 cluster due to job submission payload
being too large, see [FLINK-7285].
*/
-@Ignore("Fails on job submission payload being too large - [FLINK-7285]")
+@Category(Flip6.class)
--- End diff --
Ah, and you're marking it as `Flip6` because it doesn't succeed with the
legacy components?
---
[GitHub] flink pull request #5542: [FLINK-8703][tests] Migrate tests from LocalFlinkM...
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5542#discussion_r169623190
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/BigUserProgramJobSubmitITCase.java
---
@@ -43,40 +40,27 @@
/**
* Integration test that verifies that a user program with a big(ger)
payload is successfully
* submitted and run.
+ *
+ * This test fails for non-flip6 cluster due to job submission payload
being too large, see [FLINK-7285].
*/
-@Ignore("Fails on job submission payload being too large - [FLINK-7285]")
+@Category(Flip6.class)
--- End diff --
this test actually succeeds with Flip6 so i figured we may just as well
enable it.
---
[GitHub] flink pull request #5542: [FLINK-8703][tests] Migrate tests from LocalFlinkM...
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5542 [FLINK-8703][tests] Migrate tests from LocalFlinkMiniCluster to MiniClusterResource ## What is the purpose of the change This PR contains the second batch of test ports from `LocalFlinkMiniCluster` to `MiniClusterResource`. No port required changes to `MiniClusterResource`. Each test has it's own commit and is self-contained. If a test was not explicitly creating a configuration and the number of taskmanagers/slots matched the settings in `AbstractTestBase` the test was modified to extend that. Otherwise, a separate `MiniClusterResource` `@ClassRule`/`@Rule` was created. ## Verifying this change This change is covered by existing tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 8703b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5542.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5542 commit 038dc7ef91159dc8099b35c74164dd7331e3c5fa Author: zentol Date: 2018-02-20T17:02:32Z [FLINK-8703][tests] Port CustomDistributionITCase to MiniClusterResource commit b7e52de03ad19f61a6c2cc07b40a115e14ae2ca0 Author: zentol Date: 2018-02-20T17:02:51Z [FLINK-8703][tests] Port BigUserProgramJobSubmitITCase to MiniClusterResource commit 4d9b92b97384b5cffed6fe95c0463ba8113584ef Author: zentol Date: 2018-02-20T17:03:08Z [FLINK-8703][tests] Port scala FlinkTestBase to MiniClusterResource commit 9268219bf1069d4d70f1a662993ee5db41df1e2d Author: zentol Date: 2018-02-20T17:05:28Z [FLINK-8703][tests] Port ScalaStreamingMultipleProgramsTestBase to MiniClusterResource commit cb099561877517babb2a6d248b9dc34098701d78 Author: zentol Date: 2018-02-20T17:24:17Z [FLINK-8703][tests] Port AbstractEventTimeWindowCheckpointingITCase to MiniClusterResource commit 70a9ad0e38a3673038096721e35b92f24b7f1798 Author: zentol Date: 2018-02-20T17:33:22Z [FLINK-8703][tests] Port IPv6HostnamesITCase to MiniClusterResource ---
