[GitHub] flink pull request #5904: [FLINK-9249][build] Add convenience profile for sk...

2018-05-02 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/5904


---

[GitHub] flink pull request #5904: [FLINK-9249][build] Add convenience profile for sk...

2018-04-24 Thread zhangminglei 
Github user zhangminglei commented on a diff in the pull request:

https://github.com/apache/flink/pull/5904#discussion_r183922637
  
--- Diff: pom.xml ---
@@ -636,6 +636,63 @@ under the License.
 

 
+   
+   fast
+   
+   
+   fast
+   
+   
+   
+   
+   
+   
+   
org.apache.rat
+   
apache-rat-plugin
+   
+   
true
+   
+   
+   
+   
org.apache.maven.plugins
+   
maven-checkstyle-plugin
+   
+   
true
+   
--- End diff --

That sounds nice.


---

[GitHub] flink pull request #5904: [FLINK-9249][build] Add convenience profile for sk...

2018-04-24 Thread zentol 
Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/5904#discussion_r183841885
  
--- Diff: pom.xml ---
@@ -636,6 +636,63 @@ under the License.
 

 
+   
+   fast
+   
+   
+   fast
+   
+   
+   
+   
+   
+   
+   
org.apache.rat
+   
apache-rat-plugin
+   
+   
true
+   
+   
+   
+   
org.apache.maven.plugins
+   
maven-checkstyle-plugin
+   
+   
true
+   
--- End diff --

got nothing to do `.travis.yml`. The `travis_mvn_watchdog.sh` script uses 
differet settings for each build, one of which builds all of Flink with all 
plugins enabled, (so called "misc.")


---

[GitHub] flink pull request #5904: [FLINK-9249][build] Add convenience profile for sk...

2018-04-24 Thread zhangminglei 
Github user zhangminglei commented on a diff in the pull request:

https://github.com/apache/flink/pull/5904#discussion_r183790505
  
--- Diff: pom.xml ---
@@ -636,6 +636,63 @@ under the License.
 

 
+   
+   fast
+   
+   
+   fast
+   
+   
+   
+   
+   
+   
+   
org.apache.rat
+   
apache-rat-plugin
+   
+   
true
+   
+   
+   
+   
org.apache.maven.plugins
+   
maven-checkstyle-plugin
+   
+   
true
+   
--- End diff --

That's good. I think this works because of ```.travis.yml``` enable it at 
least. Correct ?


---

[GitHub] flink pull request #5904: [FLINK-9249][build] Add convenience profile for sk...

2018-04-24 Thread zentol 
Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/5904#discussion_r183787514
  
--- Diff: pom.xml ---
@@ -636,6 +636,63 @@ under the License.
 

 
+   
+   fast
+   
+   
+   fast
+   
+   
+   
+   
+   
+   
+   
org.apache.rat
+   
apache-rat-plugin
+   
+   
true
+   
+   
+   
+   
org.apache.maven.plugins
+   
maven-checkstyle-plugin
+   
+   
true
+   
--- End diff --

we still verify everything at least once on travis.


---

[GitHub] flink pull request #5904: [FLINK-9249][build] Add convenience profile for sk...

2018-04-24 Thread W4anD0eR96 
Github user W4anD0eR96 commented on a diff in the pull request:

https://github.com/apache/flink/pull/5904#discussion_r183741162
  
--- Diff: pom.xml ---
@@ -636,6 +636,63 @@ under the License.
 

 
+   
+   fast
+   
+   
+   fast
+   
+   
+   
+   
+   
+   
+   
org.apache.rat
+   
apache-rat-plugin
+   
+   
true
+   
+   
+   
+   
org.apache.maven.plugins
+   
maven-checkstyle-plugin
+   
+   
true
+   
--- End diff --

+1 not skip plugins on tarvis. LGTM make it fast local building.


---

[GitHub] flink pull request #5904: [FLINK-9249][build] Add convenience profile for sk...

2018-04-24 Thread zhangminglei 
Github user zhangminglei commented on a diff in the pull request:

https://github.com/apache/flink/pull/5904#discussion_r183735405
  
--- Diff: pom.xml ---
@@ -636,6 +636,63 @@ under the License.
 

 
+   
+   fast
+   
+   
+   fast
+   
+   
+   
+   
+   
+   
+   
org.apache.rat
+   
apache-rat-plugin
+   
+   
true
+   
+   
+   
+   
org.apache.maven.plugins
+   
maven-checkstyle-plugin
+   
+   
true
+   
--- End diff --

If we skip this plugin, Will it affect the format or style of the code of 
people's PR will merge to flink? 


---

[GitHub] flink pull request #5904: [FLINK-9249][build] Add convenience profile for sk...

2018-04-24 Thread zentol 
GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/5904

[FLINK-9249][build] Add convenience profile for skipping non-essential 
plugins

## What is the purpose of the change

This PR adds a convenience profile for skipping non-essential plugins when 
building Flink.
Disabled plugins:
* rat
* checkstyle
* scalastyle
* enforcer
* japicmp
* javadoc

The PR also modifies the travis script to make use of the profile.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 9249

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5904.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5904


commit e95fb53fa09492a167f0641fe9252cc927010577
Author: zentol 
Date:   2018-04-24T11:13:39Z

[FLINK-9249][build] Add convenience profile for skipping non-essential 
plugins




---