[GitHub] pnowojski commented on issue #6299: [FLINK-9713][table][sql] Support processing time versioned joins

2018-09-21 Thread GitBox
pnowojski commented on issue #6299: [FLINK-9713][table][sql] Support processing 
time versioned joins
URL: https://github.com/apache/flink/pull/6299#issuecomment-423503610
 
 
   Travis is green - merging


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pnowojski commented on issue #6299: [FLINK-9713][table][sql] Support processing time versioned joins

2018-09-21 Thread GitBox
pnowojski commented on issue #6299: [FLINK-9713][table][sql] Support processing 
time versioned joins
URL: https://github.com/apache/flink/pull/6299#issuecomment-423448194
 
 
   Thanks for the review @twalthr :) I'm pushing latest update. Will merge it 
once it's green.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pnowojski commented on issue #6299: [FLINK-9713][table][sql] Support processing time versioned joins

2018-09-20 Thread GitBox
pnowojski commented on issue #6299: [FLINK-9713][table][sql] Support processing 
time versioned joins
URL: https://github.com/apache/flink/pull/6299#issuecomment-423247190
 
 
   Yes, you were right `TemporalTableReference` was not needed after cleaning 
up `.rowtime` usages. Applied changes, please check the `fixup` commits :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services