[GitHub] sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView
sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView URL: https://github.com/apache/flink/pull/7201#issuecomment-450044090 Merging.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView
sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView URL: https://github.com/apache/flink/pull/7201#issuecomment-449792220 @dianfu thanks for the updated! I like this way of harness testing, it can cover codegen logic! +1 to merged. Bests, Jincheng This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView
sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView URL: https://github.com/apache/flink/pull/7201#issuecomment-447734443 @dianfu the FLINK-11074 has been merged, I am very grateful if you can add the harness in current PR. Bests, Jincheng This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView
sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView URL: https://github.com/apache/flink/pull/7201#issuecomment-445091806 Hi @twalthr @walterddr @dianfu I totally agree that any changes will be covered by the test case！Thanks @dianfu file the [FLINK-11074](https://issues.apache.org/jira/browse/FLINK-11074)， we can focus on FLINK-11074 then back to this changes as well. Thanks, Jincheng This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
