[GitHub] xccui commented on a change in pull request #7357: [hotfix] [table] Fix a bound problem for array validation
xccui commented on a change in pull request #7357: [hotfix] [table] Fix a bound
problem for array validation
URL: https://github.com/apache/flink/pull/7357#discussion_r244004641
##
File path:
flink-libraries/flink-table-common/src/main/java/org/apache/flink/table/descriptors/DescriptorProperties.java
##
@@ -1134,7 +1134,7 @@ public void validateArray(String key, Consumer
elementValidation, int mi
}
// validate array elements
- for (int i = 0; i < maxIndex; i++) {
Review comment:
Well, maybe I should create a JIRA issue for these problems. Will close this
PR.
Thanks for looking into this, @hequn8128!
Best, Xingcan
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] xccui commented on a change in pull request #7357: [hotfix] [table] Fix a bound problem for array validation
xccui commented on a change in pull request #7357: [hotfix] [table] Fix a bound
problem for array validation
URL: https://github.com/apache/flink/pull/7357#discussion_r243887869
##
File path:
flink-libraries/flink-table-common/src/main/java/org/apache/flink/table/descriptors/DescriptorProperties.java
##
@@ -1134,7 +1134,7 @@ public void validateArray(String key, Consumer
elementValidation, int mi
}
// validate array elements
- for (int i = 0; i < maxIndex; i++) {
+ for (int i = 0; i < maxIndex + 1; i++) {
Review comment:
Thanks for your suggestion, @sunjincheng121.
I'll change to the "less than and equal to" symbol.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
