[GitHub] yanghua commented on a change in pull request #6445: [FLINK-8302][Table API & SQL] Add SHIFT_LEFT and SHIFT_RIGHT

2018-07-28 Thread GitBox 
yanghua commented on a change in pull request #6445: [FLINK-8302][Table API & 
SQL] Add SHIFT_LEFT and SHIFT_RIGHT
URL: https://github.com/apache/flink/pull/6445#discussion_r205958595
 
 

 ##
 File path: docs/dev/table/tableApi.md
 ##
 @@ -3598,6 +3598,28 @@ numeric1 % numeric2
   
 
 
+
+  
+{% highlight scala %}
+shiftLeft(numeric1, numeric2)
 
 Review comment:
   add Java doc for shiftLeft


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yanghua commented on a change in pull request #6445: [FLINK-8302][Table API & SQL] Add SHIFT_LEFT and SHIFT_RIGHT

2018-07-28 Thread GitBox 
yanghua commented on a change in pull request #6445: [FLINK-8302][Table API & 
SQL] Add SHIFT_LEFT and SHIFT_RIGHT
URL: https://github.com/apache/flink/pull/6445#discussion_r205958632
 
 

 ##
 File path: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
 ##
 @@ -831,6 +831,16 @@ trait ImplicitExpressionOperations {
 */
   def notBetween(lowerBound: Expression, upperBound: Expression) =
 NotBetween(expr, lowerBound, upperBound)
+
+  /*
+   * Left shift
 
 Review comment:
   provide more detail and end with "." looks better to me


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yanghua commented on a change in pull request #6445: [FLINK-8302][Table API & SQL] Add SHIFT_LEFT and SHIFT_RIGHT

2018-07-28 Thread GitBox 
yanghua commented on a change in pull request #6445: [FLINK-8302][Table API & 
SQL] Add SHIFT_LEFT and SHIFT_RIGHT
URL: https://github.com/apache/flink/pull/6445#discussion_r205958635
 
 

 ##
 File path: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
 ##
 @@ -831,6 +831,16 @@ trait ImplicitExpressionOperations {
 */
   def notBetween(lowerBound: Expression, upperBound: Expression) =
 NotBetween(expr, lowerBound, upperBound)
+
+  /*
+   * Left shift
+   */
+  def shiftLeft(right: Expression) = ShiftLeft(expr, right)
+
+  /*
+   * Right shift
 
 Review comment:
   provide more detail and end with "." looks better to me


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yanghua commented on a change in pull request #6445: [FLINK-8302][Table API & SQL] Add SHIFT_LEFT and SHIFT_RIGHT

2018-07-28 Thread GitBox 
yanghua commented on a change in pull request #6445: [FLINK-8302][Table API & 
SQL] Add SHIFT_LEFT and SHIFT_RIGHT
URL: https://github.com/apache/flink/pull/6445#discussion_r205958599
 
 

 ##
 File path: docs/dev/table/tableApi.md
 ##
 @@ -3598,6 +3598,28 @@ numeric1 % numeric2
   
 
 
+
+  
+{% highlight scala %}
+shiftLeft(numeric1, numeric2)
+{% endhighlight %}
+  
+  
+Returns numeric1 shifted left of numeric2. The result 
is numeric1 << numeric2 
+  
+
+
+
+  
+{% highlight scala %}
+shiftRight(numeric1, numeric2)
 
 Review comment:
   add Java doc for shiftRight


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services