[GitHub] yanghua commented on a change in pull request #6738: [FLINK-10126] There should be a Scala DataSource
yanghua commented on a change in pull request #6738: [FLINK-10126] There should be a Scala DataSource URL: https://github.com/apache/flink/pull/6738#discussion_r226576646 ## File path: pom.xml ## @@ -1613,6 +1613,7 @@ under the License. org.apache.flink.api.scala.hadoop.mapred.HadoopOutputFormat org.apache.flink.api.scala.hadoop.mapreduce.HadoopInputFormat org.apache.flink.api.scala.hadoop.mapreduce.HadoopOutputFormat + org.apache.flink.api.scala.ExecutionEnvironment Review comment: @tillrohrmann Before I change it, do I want to hear your opinion (adding a reflection-based manual test?) remains the same? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yanghua commented on a change in pull request #6738: [FLINK-10126] There should be a Scala DataSource
yanghua commented on a change in pull request #6738: [FLINK-10126] There should be a Scala DataSource URL: https://github.com/apache/flink/pull/6738#discussion_r224751954 ## File path: pom.xml ## @@ -1613,6 +1613,7 @@ under the License. org.apache.flink.api.scala.hadoop.mapred.HadoopOutputFormat org.apache.flink.api.scala.hadoop.mapreduce.HadoopInputFormat org.apache.flink.api.scala.hadoop.mapreduce.HadoopOutputFormat + org.apache.flink.api.scala.ExecutionEnvironment Review comment: @tillrohrmann I am thinking that since we are doing this will break the compatibility of the API, can we try to think about my original implementation again(To maintain the existing implementation, just add two APIs to the `DataSet`.)? If your idea is still not considered, then in some sense the existing test code used to test the use of these APIs. If we change these API interfaces in the future and need to change the client program, then this shows that there is a problem with our approach. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yanghua commented on a change in pull request #6738: [FLINK-10126] There should be a Scala DataSource
yanghua commented on a change in pull request #6738: [FLINK-10126] There should be a Scala DataSource URL: https://github.com/apache/flink/pull/6738#discussion_r224421090 ## File path: pom.xml ## @@ -1613,6 +1613,7 @@ under the License. org.apache.flink.api.scala.hadoop.mapred.HadoopOutputFormat org.apache.flink.api.scala.hadoop.mapreduce.HadoopInputFormat org.apache.flink.api.scala.hadoop.mapreduce.HadoopOutputFormat + org.apache.flink.api.scala.ExecutionEnvironment Review comment: However, existing programs that use these APIs are compatible. But the japicmp always reports error. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yanghua commented on a change in pull request #6738: [FLINK-10126] There should be a Scala DataSource
yanghua commented on a change in pull request #6738: [FLINK-10126] There should be a Scala DataSource URL: https://github.com/apache/flink/pull/6738#discussion_r224419588 ## File path: pom.xml ## @@ -1613,6 +1613,7 @@ under the License. org.apache.flink.api.scala.hadoop.mapred.HadoopOutputFormat org.apache.flink.api.scala.hadoop.mapreduce.HadoopInputFormat org.apache.flink.api.scala.hadoop.mapreduce.HadoopOutputFormat + org.apache.flink.api.scala.ExecutionEnvironment Review comment: I just tried mark those changed API with annotation (Experimental and PublicEvolving) but still report incompatibility error (the former annotation reports `METHOD_RETURN_TYPE_CHANGED` and the second annotation reports `METHOD_REMOVED`). Just like the PR #6266 . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yanghua commented on a change in pull request #6738: [FLINK-10126] There should be a Scala DataSource
yanghua commented on a change in pull request #6738: [FLINK-10126] There should be a Scala DataSource URL: https://github.com/apache/flink/pull/6738#discussion_r223569915 ## File path: pom.xml ## @@ -1613,6 +1613,7 @@ under the License. org.apache.flink.api.scala.hadoop.mapred.HadoopOutputFormat org.apache.flink.api.scala.hadoop.mapreduce.HadoopInputFormat org.apache.flink.api.scala.hadoop.mapreduce.HadoopOutputFormat + org.apache.flink.api.scala.ExecutionEnvironment Review comment: I temporarily added it to the exclusion list so that Travis can continue compiling and verifying other changes. cc @tillrohrmann and @StephanEwen This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
