[GitHub] zentol commented on issue #6452: [FLINK-9739] Regression in supported filesystems for RocksDB
zentol commented on issue #6452: [FLINK-9739] Regression in supported filesystems for RocksDB URL: https://github.com/apache/flink/pull/6452#issuecomment-412561511 When would a relative path make sense, and wouldn't this always result in effectively random behavior? I would be fine with dropping support for schemes; if we either reject or ignore schemes anyway we may as well be explicit about it up-front. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zentol commented on issue #6452: [FLINK-9739] Regression in supported filesystems for RocksDB
zentol commented on issue #6452: [FLINK-9739] Regression in supported filesystems for RocksDB URL: https://github.com/apache/flink/pull/6452#issuecomment-409131603 In order to restore the previous behavior we will have to go with the proposed solution. Please also adjust the error message to include the path. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zentol commented on issue #6452: [FLINK-9739] Regression in supported filesystems for RocksDB
zentol commented on issue #6452: [FLINK-9739] Regression in supported filesystems for RocksDB URL: https://github.com/apache/flink/pull/6452#issuecomment-408851714 Note that this of course could break setups where people actually use `:` as a separate :/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zentol commented on issue #6452: [FLINK-9739] Regression in supported filesystems for RocksDB
zentol commented on issue #6452: [FLINK-9739] Regression in supported filesystems for RocksDB URL: https://github.com/apache/flink/pull/6452#issuecomment-408851475 yes that would be my suggestion. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zentol commented on issue #6452: [FLINK-9739] Regression in supported filesystems for RocksDB
zentol commented on issue #6452: [FLINK-9739] Regression in supported filesystems for RocksDB URL: https://github.com/apache/flink/pull/6452#issuecomment-408846731 I'm well aware that `:` was explicitly introduced to support multiple file paths, my point is that it (in hindsight) wasn't a good choice, as other options delimiters exist `,|;` that are less ambiguous. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zentol commented on issue #6452: [FLINK-9739] Regression in supported filesystems for RocksDB
zentol commented on issue #6452: [FLINK-9739] Regression in supported filesystems for RocksDB URL: https://github.com/apache/flink/pull/6452#issuecomment-408833311 Looks like splitting on `:` was intentional (see #2482). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
