[GitHub] zentol commented on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file
zentol commented on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file URL: https://github.com/apache/flink/pull/6542#issuecomment-429609834 My opinion hasn't changed, I still don't think that it is worth it. Separating the HistoryServer from your cluster environment is already trivial: just copy flink-dist to separate locations. The downside here is you end up with a plethora of unused jars in the HistoryServer copy, but I'd argue that the HistoryServer shouldn't be bundled with flink-dist in such a messy way and instead be distributed as a standalone application. However this shouldn't be discussed in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zentol commented on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file
zentol commented on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file URL: https://github.com/apache/flink/pull/6542#issuecomment-412622673 well I still like the idea of separate config files, but the JIRA discussion happened more than a year ago, _before we even had released the HistoryServer_. Now we have to think about backwards compatibility and will thus naturally end up adding complexity. I'm not sure if this is really worth it, especially so since this issue has never been raised again since the HS was released. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zentol commented on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file
zentol commented on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file URL: https://github.com/apache/flink/pull/6542#issuecomment-412590513 That strategy is already implemented, but it doesn't really address backwards compatibility imo. I would assume that when people upgrade they'll end up with the default `flink-historyserver-conf.yaml` being present in `conf` overwriting everything in `flink-conf.yaml`. We could comment out everything in in the HS config file, always read both and prioritize contents in the HS config. This wouldn't affect old users (we could also guide them with logging messages if settings are found in `flink-conf.yaml`, nor should it affect new users as either a) they have to set a key anyway or b) a sane default handles this case. Still, I'm wondering whether there's really a benefit here. If we start splitting config files I'd prefer if we'd to the same for the client. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zentol commented on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file
zentol commented on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file URL: https://github.com/apache/flink/pull/6542#issuecomment-412430748 I don't think we should do this _now_. It seems like there's little to gain at this point, since we would still have to support configuration via `flink-conf.yaml` to not break every existing setup (like this PR does). Given that there's no overlap between HistoryServer and cluster options there's also little chance of accidentally messing up the configuration for the other one. Besides that this PR is untested (yet again!). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
