Re: [PR] [FLINK-30535][Test] Customize TtlTimeProvider in state benchmarks [flink]
Myasuka merged PR #23985: URL: https://github.com/apache/flink/pull/23985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30535][Test] Customize TtlTimeProvider in state benchmarks [flink]
Zakelly commented on code in PR #23985:
URL: https://github.com/apache/flink/pull/23985#discussion_r1436084300
##
flink-test-utils-parent/flink-test-utils/src/test/java/org/apache/flink/state/benchmark/StateBackendBenchmarkUtils.java:
##
@@ -216,7 +225,7 @@ private static HeapKeyedStateBackend
createHeapKeyedStateBackend(File root
return backendBuilder.build();
}
-private static File prepareDirectory(String prefix, File parentDir) throws
IOException {
+public static File prepareDirectory(String prefix, File parentDir) throws
IOException {
Review Comment:
Like I said in description:
> Also by the way, the StateBackendBenchmarkUtils#prepareDirectory is made
public for the de-duplication of code in RescalingBenchmarkBase in state
benchmarks.
You may see the [`RescalingBenchmarkBase#prepareDirectory`
](https://github.com/apache/flink-benchmarks/blob/e0d922cb30c3cee827cec05981befae28ec4daa3/src/main/java/org/apache/flink/state/benchmark/RescalingBenchmarkBase.java#L66).
I want to do some code abstraction there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-30535][Test] Customize TtlTimeProvider in state benchmarks [flink]
Myasuka commented on code in PR #23985:
URL: https://github.com/apache/flink/pull/23985#discussion_r1436070483
##
flink-test-utils-parent/flink-test-utils/src/test/java/org/apache/flink/state/benchmark/StateBackendBenchmarkUtils.java:
##
@@ -216,7 +225,7 @@ private static HeapKeyedStateBackend
createHeapKeyedStateBackend(File root
return backendBuilder.build();
}
-private static File prepareDirectory(String prefix, File parentDir) throws
IOException {
+public static File prepareDirectory(String prefix, File parentDir) throws
IOException {
Review Comment:
Why we need to make this method public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
