Re: [PR] [FLINK-35148][core] Improve InstantiationUtil for checking nullary pu… [flink]

[via GitHub]

xintongsong merged PR #24675:
URL: https://github.com/apache/flink/pull/24675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-35148][core] Improve InstantiationUtil for checking nullary pu… [flink]

[via GitHub]

liuml07 commented on PR #24675:
URL: https://github.com/apache/flink/pull/24675#issuecomment-2073998465

   @xintongsong Could you please take a quick look at this for me? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-35148][core] Improve InstantiationUtil for checking nullary pu… [flink]

[via GitHub]

flinkbot commented on PR #24675:
URL: https://github.com/apache/flink/pull/24675#issuecomment-2062593439

   
   ## CI report:
   
   * fc79b8051c60e2628b2098e82bc945f79b08a3d3 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-35148][core] Improve InstantiationUtil for checking nullary pu… [flink]

[via GitHub]

liuml07 commented on PR #24675:
URL: https://github.com/apache/flink/pull/24675#issuecomment-2062592367

   @snuyanzin could you take a look? Thanks,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] [FLINK-35148][core] Improve InstantiationUtil for checking nullary pu… [flink]

[via GitHub]

liuml07 opened a new pull request, #24675:
URL: https://github.com/apache/flink/pull/24675

   …blic constructor
   
   
   
   ## What is the purpose of the change
   
   https://issues.apache.org/jira/browse/FLINK-35148
   
   InstantiationUtil#hasPublicNullaryConstructor checks whether the given class 
has a public nullary constructor. The implementation can be improved a bit: the 
`Modifier#isPublic` check within the for-loop can be skipped as the 
Class#getConstructors() only returns public constructors.
   
   We can also add a negative unit test for this.
   
   
   ## Brief change log
   
   - Skip the `Modifier#isPublic` check
   - Use Java stream
   - Add negative unit test
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as 
`InstantiationUtilTest`. This change added a new negative test in that class.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (yes / **no**)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
 - The serializers: (yes / **no** / don't know)
 - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
 - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (yes / **no**)
 - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org