Re: [PR] Adding JDBC Connector v3.2.0 [flink-web]

2024-06-07 Thread via GitHub


dannycranmer merged PR #734:
URL: https://github.com/apache/flink-web/pull/734


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Adding JDBC Connector v3.2.0 [flink-web]

2024-05-22 Thread via GitHub


leonardBang commented on code in PR #734:
URL: https://github.com/apache/flink-web/pull/734#discussion_r1609837483


##
docs/data/flink_connectors.yml:
##
@@ -51,11 +51,11 @@ hbase:
   compatibility: ["1.16.x", "1.17.x"]
 
 jdbc:
-  name: "Apache Flink JDBC Connector 3.1.2"
-  source_release_url: 
"https://www.apache.org/dyn/closer.lua/flink/flink-connector-jdbc-3.1.2/flink-connector-jdbc-3.1.2-src.tgz;
-  source_release_asc_url: 
"https://downloads.apache.org/flink/flink-connector-jdbc-3.1.2/flink-connector-jdbc-3.1.2-src.tgz.asc;
-  source_release_sha512_url: 
"https://downloads.apache.org/flink/flink-connector-jdbc-3.1.2/flink-connector-jdbc-3.1.2-src.tgz.sha512;
-  compatibility: ["1.16.x", "1.17.x", "1.18.x"]
+  name: "Apache Flink JDBC Connector 3.2.0"
+  source_release_url: 
"https://www.apache.org/dyn/closer.lua/flink/flink-connector-jdbc-3.2.0/flink-connector-jdbc-3.2.0-src.tgz;
+  source_release_asc_url: 
"https://downloads.apache.org/flink/flink-connector-jdbc-3.2.0/flink-connector-jdbc-3.2.0-src.tgz.asc;
+  source_release_sha512_url: 
"https://downloads.apache.org/flink/flink-connector-jdbc-3.2.0/flink-connector-jdbc-3.2.0-src.tgz.sha512;
+  compatibility: ["1.18.x", "1.19.x"]

Review Comment:
   The bylaws requires supporting at least two versions, 3 versions is not 
necessary 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Adding JDBC Connector v3.2.0 [flink-web]

2024-04-18 Thread via GitHub


Samrat002 commented on code in PR #734:
URL: https://github.com/apache/flink-web/pull/734#discussion_r1571145570


##
docs/data/flink_connectors.yml:
##
@@ -51,11 +51,11 @@ hbase:
   compatibility: ["1.16.x", "1.17.x"]
 
 jdbc:
-  name: "Apache Flink JDBC Connector 3.1.2"
-  source_release_url: 
"https://www.apache.org/dyn/closer.lua/flink/flink-connector-jdbc-3.1.2/flink-connector-jdbc-3.1.2-src.tgz;
-  source_release_asc_url: 
"https://downloads.apache.org/flink/flink-connector-jdbc-3.1.2/flink-connector-jdbc-3.1.2-src.tgz.asc;
-  source_release_sha512_url: 
"https://downloads.apache.org/flink/flink-connector-jdbc-3.1.2/flink-connector-jdbc-3.1.2-src.tgz.sha512;
-  compatibility: ["1.16.x", "1.17.x", "1.18.x"]
+  name: "Apache Flink JDBC Connector 3.2.0"
+  source_release_url: 
"https://www.apache.org/dyn/closer.lua/flink/flink-connector-jdbc-3.2.0/flink-connector-jdbc-3.2.0-src.tgz;
+  source_release_asc_url: 
"https://downloads.apache.org/flink/flink-connector-jdbc-3.2.0/flink-connector-jdbc-3.2.0-src.tgz.asc;
+  source_release_sha512_url: 
"https://downloads.apache.org/flink/flink-connector-jdbc-3.2.0/flink-connector-jdbc-3.2.0-src.tgz.sha512;
+  compatibility: ["1.18.x", "1.19.x"]

Review Comment:
   [NIT]
   Reduced supported versions in JDBC connector: Previously 3 versions (1.16.x, 
1.17.x, 1.18.x), now 2 (1.18.x, 1.19.x). Any specific reason for the change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Adding JDBC Connector v3.2.0 [flink-web]

2024-04-18 Thread via GitHub


Samrat002 commented on code in PR #734:
URL: https://github.com/apache/flink-web/pull/734#discussion_r1571145570


##
docs/data/flink_connectors.yml:
##
@@ -51,11 +51,11 @@ hbase:
   compatibility: ["1.16.x", "1.17.x"]
 
 jdbc:
-  name: "Apache Flink JDBC Connector 3.1.2"
-  source_release_url: 
"https://www.apache.org/dyn/closer.lua/flink/flink-connector-jdbc-3.1.2/flink-connector-jdbc-3.1.2-src.tgz;
-  source_release_asc_url: 
"https://downloads.apache.org/flink/flink-connector-jdbc-3.1.2/flink-connector-jdbc-3.1.2-src.tgz.asc;
-  source_release_sha512_url: 
"https://downloads.apache.org/flink/flink-connector-jdbc-3.1.2/flink-connector-jdbc-3.1.2-src.tgz.sha512;
-  compatibility: ["1.16.x", "1.17.x", "1.18.x"]
+  name: "Apache Flink JDBC Connector 3.2.0"
+  source_release_url: 
"https://www.apache.org/dyn/closer.lua/flink/flink-connector-jdbc-3.2.0/flink-connector-jdbc-3.2.0-src.tgz;
+  source_release_asc_url: 
"https://downloads.apache.org/flink/flink-connector-jdbc-3.2.0/flink-connector-jdbc-3.2.0-src.tgz.asc;
+  source_release_sha512_url: 
"https://downloads.apache.org/flink/flink-connector-jdbc-3.2.0/flink-connector-jdbc-3.2.0-src.tgz.sha512;
+  compatibility: ["1.18.x", "1.19.x"]

Review Comment:
   [NIT]
   Earlier jdbc connector used to support 3 versions (1.16.x , 1.17.x and 
1.18.x) 
   now it supports only 2 ( 1.18.x and 1.19.x) versions only. any specific 
reason ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Adding JDBC Connector v3.2.0 [flink-web]

2024-04-17 Thread via GitHub


dannycranmer opened a new pull request, #734:
URL: https://github.com/apache/flink-web/pull/734

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org