Re: [PR] Fix problem due to HBaseRowDataLookupFunction returned to reuse objects [flink-connector-hbase]
ferenc-csaky commented on PR #20: URL: https://github.com/apache/flink-connector-hbase/pull/20#issuecomment-2074636836 @Tan-JiaLiang I think it is okay to take over. We can keep the separate commits, so the original change will keep its author, even the commit msg can be modified while the original author remains the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix problem due to HBaseRowDataLookupFunction returned to reuse objects [flink-connector-hbase]
Tan-JiaLiang commented on PR #20: URL: https://github.com/apache/flink-connector-hbase/pull/20#issuecomment-2073877197 @MartijnVisser @ferenc-csaky It doesn't look like he's had time to deal with the problem, and I'd like to take it on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix problem due to HBaseRowDataLookupFunction returned to reuse objects [flink-connector-hbase]
Tan-JiaLiang commented on PR #20: URL: https://github.com/apache/flink-connector-hbase/pull/20#issuecomment-2066268025 @Jackson-xky This is a serious problem in the hbase lookup join. Are you still working on it? I'd be happy to help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix problem due to HBaseRowDataLookupFunction returned to reuse objects [flink-connector-hbase]
MartijnVisser commented on PR #20: URL: https://github.com/apache/flink-connector-hbase/pull/20#issuecomment-1807900127 @ferenc-csaky WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix problem due to HBaseRowDataLookupFunction returned to reuse objects [flink-connector-hbase]
Jackson-xky commented on PR #20: URL: https://github.com/apache/flink-connector-hbase/pull/20#issuecomment-1763957874 HBaseRowDataLookupFunction. The returned result is the Collections in the lookup. SingletonList (serde. ConvertToNewRow (result). The default convertToNewRow method is used here, and the same object is reused internally. When lookup.cache is enabled, the cache results will only be the same object, resulting in confusion. You can avoid this by default by using convertToNewRow to return a new object -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
