[jira] [Comment Edited] (FLINK-12348) Use TableConfig in api module to replace TableConfig in blink-planner module.
[
https://issues.apache.org/jira/browse/FLINK-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833789#comment-16833789
]
Jark Wu edited comment on FLINK-12348 at 5/6/19 12:50 PM:
--
+1 provide methods for frequently used properties.
Regarding to the naming of properties, I think you raised a good point, this is
what I want to discuss next. I think it's nice to follow descriptor properties,
actually we also use this pattern in Blink properties.
Regarding to the hierarchy of properties, we split the options into following
in Blink:
* {{sql.exec.xxx}} for runtime
* {{sql.optimizer.xxx}} for optimizer
* {{sql.resource.xxx}} for resource, e.g. memory, parallelism, cpu
* {{sql.codegen.xxx}} for codegen
I'm not sure there should be a planner hierarchy. IMO, planner is a little
broad for users, it seems that it includes optimizer, codegen, resource, etc..
Maybe we should draft a google doc to list all the properties will be added in
the near future (mostly from Blink planner, shall we go through every property
name from Blink?). So that we can have an overview of properties to have a
better hierarchy. And we can continue the discussion in the doc.
was (Author: jark):
+1 provide methods for frequently used properties.
Regarding to the naming of properties, I think you raised a good point, this is
what I want to discuss next. I think it's nice to follow descriptor properties,
actually we also use this pattern in Blink properties.
Regarding to the hierarchy of properties, we split the options into following
in Blink:
* {{sql.exec.xxx}} for runtime
* {{sql.optimizer.xxx}} for optimizer
* {{sql.resource.xxx}} for resource, e.g. memory, parallelism, cpu
* {{sql.codegen.xxx}} for codegen
I'm not sure there should be a planner hierarchy. IMO, planner is a little
broad for users, it seems that it includes optimizer, codegen, resource, etc..
Maybe we should draft a google doc to list all the properties will be added in
the near future (mostly from Blink planner, shall we go through every property
name from Blink?). So that we can have an overview of properties to have a
better hierarchy.
> Use TableConfig in api module to replace TableConfig in blink-planner module.
> -
>
> Key: FLINK-12348
> URL: https://issues.apache.org/jira/browse/FLINK-12348
> Project: Flink
> Issue Type: Task
> Components: Table SQL / API
>Reporter: Jing Zhang
>Assignee: Jing Zhang
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Since TableConfig already moved to API module in
> [FLINK-11067|https://issues.apache.org/jira/browse/FLINK-11067], TableConfig
> in blink-planner-module should not exist anymore. The issue aims to remove
> the TableConfig in blink-planner-module, use TableConfig in API module
> instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (FLINK-12348) Use TableConfig in api module to replace TableConfig in blink-planner module.
[
https://issues.apache.org/jira/browse/FLINK-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833738#comment-16833738
]
Timo Walther edited comment on FLINK-12348 at 5/6/19 12:00 PM:
---
Yes, we should only have a single location for those properties. And a
string-string map should be used for interoperability with YAML, JSON etc.
However, we should provide some methods for setting frequently used properties
with nice Javadocs in the string-string map. Setting and getting a timezone is
a good example.
Regarding the naming of those properties, it would be nice to follow the
guidelines mentioned in
{{org.apache.flink.table.descriptors.DescriptorProperties}}. So for [~jark]'s
example:
{code}
sql.time-zone: UTC
sql.planner.codegen.max-length: 64000
{code}
We should make it visible for users which is more planner, runtime, or API/SQL
related in the property hierarchy.
was (Author: twalthr):
Yes, we should only have a single location for those properties. And a
string-string map should be used for interoperability with YAML, JSON etc.
However, we should provide some methods for setting frequently used properties
with nice Javadocs in the string-string map. Setting and getting a timezone is
a good example.
> Use TableConfig in api module to replace TableConfig in blink-planner module.
> -
>
> Key: FLINK-12348
> URL: https://issues.apache.org/jira/browse/FLINK-12348
> Project: Flink
> Issue Type: Task
> Components: Table SQL / API
>Reporter: Jing Zhang
>Assignee: Jing Zhang
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Since TableConfig already moved to API module in
> [FLINK-11067|https://issues.apache.org/jira/browse/FLINK-11067], TableConfig
> in blink-planner-module should not exist anymore. The issue aims to remove
> the TableConfig in blink-planner-module, use TableConfig in API module
> instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (FLINK-12348) Use TableConfig in api module to replace TableConfig in blink-planner module.
[ https://issues.apache.org/jira/browse/FLINK-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827800#comment-16827800 ] Jing Zhang edited comment on FLINK-12348 at 4/28/19 3:09 AM: - IMO, `TableConfigOptions` should also exist in API module, although TableConfigOptions now only works for Blink table planner and Blink table runtime. [~jark] [~ykt836]What do you think? was (Author: jinyu.zj): IMO, `TableConfigOptions` should also exist in API module, although TableConfigOptions now only works for Blink table planner and Blink table runtime. [~jark] What do you think? > Use TableConfig in api module to replace TableConfig in blink-planner module. > - > > Key: FLINK-12348 > URL: https://issues.apache.org/jira/browse/FLINK-12348 > Project: Flink > Issue Type: Task > Components: Table SQL / API >Reporter: Jing Zhang >Assignee: Jing Zhang >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Since TableConfig already moved to API module in > [FLINK-11067|https://issues.apache.org/jira/browse/FLINK-11067], TableConfig > in blink-planner-module should not exist anymore. The issue aims to remove > the TableConfig in blink-planner-module, use TableConfig in API module > instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
