[jira] [Comment Edited] (FLINK-22655) When using -i option to initialize SQL Client session It should be possible to annotate the script with --

2021-05-28 Thread Jark Wu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353131#comment-17353131
 ] 

Jark Wu edited comment on FLINK-22655 at 5/28/21, 10:04 AM:


Fixed in 
 - master: a1da49d8cd79f5685fda2c6fa086d9d5e1ae8f22
 - release-1.13: 8d62fe8e5130575f92c6d3c7b5411fce9752e9f7


was (Author: jark):
Fixed in 
 - master: a1da49d8cd79f5685fda2c6fa086d9d5e1ae8f22
 - release-1.13: TODO

> When using -i  option to initialize SQL Client session It should be 
> possible to annotate the script with --
> -
>
> Key: FLINK-22655
> URL: https://issues.apache.org/jira/browse/FLINK-22655
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: JasonLee
>Assignee: Shengkai Fang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0, 1.13.2
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (FLINK-22655) When using -i option to initialize SQL Client session It should be possible to annotate the script with --

2021-05-13 Thread Shengkai Fang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344287#comment-17344287
 ] 

Shengkai Fang edited comment on FLINK-22655 at 5/14/21, 3:42 AM:
-

I think the main reason is the {{ExtendedParser}} has no ablity to process the 
statement with comments. To escape from this error, you may need to add `;` 
after the comment. I will give a fix soon.


was (Author: fsk119):
I think the main reason is the {{ExtendedParser}} has no ablity to process the 
statement with comments. To escape from this error, you may need to add `;` 
after the statement. I will give a fix soon.

> When using -i  option to initialize SQL Client session It should be 
> possible to annotate the script with --
> -
>
> Key: FLINK-22655
> URL: https://issues.apache.org/jira/browse/FLINK-22655
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: JasonLee
>Assignee: Shengkai Fang
>Priority: Major
> Fix For: 1.14.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (FLINK-22655) When using -i option to initialize SQL Client session It should be possible to annotate the script with --

2021-05-13 Thread JasonLee (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344270#comment-17344270
 ] 

JasonLee edited comment on FLINK-22655 at 5/14/21, 2:55 AM:


Hi ShengKai,Sorry I made a mistake last night. I used --  not - There is no 
more log information, the client only throws out one sentence


was (Author: jasonlee):
Hi ShengKai,Sorry I made a mistake last night. I used –-  not - There is no 
more log information, the client only throws out one sentence

> When using -i  option to initialize SQL Client session It should be 
> possible to annotate the script with --
> -
>
> Key: FLINK-22655
> URL: https://issues.apache.org/jira/browse/FLINK-22655
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: JasonLee
>Assignee: Shengkai Fang
>Priority: Major
> Fix For: 1.14.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (FLINK-22655) When using -i option to initialize SQL Client session It should be possible to annotate the script with --

2021-05-13 Thread JasonLee (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344270#comment-17344270
 ] 

JasonLee edited comment on FLINK-22655 at 5/14/21, 2:54 AM:


Hi ShengKai,Sorry I made a mistake last night. I used –-  not - There is no 
more log information, the client only throws out one sentence


was (Author: jasonlee):
Hi ShengKai,Sorry I made a mistake last night. I used -- not - There is no more 
log information, the client only throws out one sentence

> When using -i  option to initialize SQL Client session It should be 
> possible to annotate the script with --
> -
>
> Key: FLINK-22655
> URL: https://issues.apache.org/jira/browse/FLINK-22655
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: JasonLee
>Assignee: Shengkai Fang
>Priority: Major
> Fix For: 1.14.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (FLINK-22655) When using -i option to initialize SQL Client session It should be possible to annotate the script with --

2021-05-13 Thread Shengkai Fang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344261#comment-17344261
 ] 

Shengkai Fang edited comment on FLINK-22655 at 5/14/21, 2:44 AM:
-

Hi, [~JasonLee]. Could you offer the LOG for more details?  In SQL Client, we 
use {{---}} to comment out the lines. But you use only one {{--}} here.


was (Author: fsk119):
Hi, [~JasonLee]. Could you offer the LOG for more details?  In SQL Client, we 
use {{--}} to comment out the lines. But you use only one {{-}} here.

> When using -i  option to initialize SQL Client session It should be 
> possible to annotate the script with --
> -
>
> Key: FLINK-22655
> URL: https://issues.apache.org/jira/browse/FLINK-22655
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: JasonLee
>Assignee: Shengkai Fang
>Priority: Major
> Fix For: 1.14.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)