[jira] [Comment Edited] (FLINK-23544) Window TVF Supports session window
[ https://issues.apache.org/jira/browse/FLINK-23544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17408775#comment-17408775 ] JING ZHANG edited comment on FLINK-23544 at 9/2/21, 12:26 PM: -- [~godfreyhe] [~twalthr] [~jark] Hi all, I'm so sorry about introduce syntax error in the pr. I agree with you to revert the session window TVF in 1.14, and continue to add correct syntax of Window TVF in 1.15. I would track the issue in FLINK-24024 I would try to follow up the CALCITE-4337. was (Author: qingru zhang): [~godfreyhe] [~twalthr] [~jark] Hi all, I agree with you to revert the session window TVF in 1.14, and continue to add correct syntax of Window TVF in 1.15. I would track the issue in FLINK-24024 I would try to follow up the CALCITE-4337. > Window TVF Supports session window > -- > > Key: FLINK-23544 > URL: https://issues.apache.org/jira/browse/FLINK-23544 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: JING ZHANG >Assignee: JING ZHANG >Priority: Minor > Labels: pull-request-available > Fix For: 1.14.0 > > > Window TVF would support SESSION window in the following case: > # SESSION Window TVF followed by Window Aggregate, in this case SESSION > window TVF would be pulled up into WindowAggregate, so Window assigner would > happen in WindowAggrgeate > > *Note, SESSION window TVF only works in limited cases currently, the > following user cases is not supported yet:* > # *SESSION WINDOW TVF followed by Window JOIN* > # *SESSION WINDOW TVF followed by Window RANK*** > *BESIDES, SESSION window Aggregate does not support the following performance > improvement yet:* > 1. Split Distinct Aggregation > 2. Local-global Aggregation > 3. Mini-batch Aggregate -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (FLINK-23544) Window TVF Supports session window
[ https://issues.apache.org/jira/browse/FLINK-23544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17408775#comment-17408775 ] JING ZHANG edited comment on FLINK-23544 at 9/2/21, 12:23 PM: -- [~godfreyhe] [~twalthr] [~jark] Hi all, I agree with you to revert the session window TVF in 1.14, and continue to add correct syntax of Window TVF in 1.15. I would track the issue in FLINK-24024 I would try to follow up the CALCITE-4337. was (Author: qingru zhang): [~godfreyhe] [~twalthr] [~jark] Hi all, I agree with you to revert the session window TVF in 1.14, and continue to add correct syntax of Window TVF in 1.15. I would track the issue in [FLINK-24024|https://issues.apache.org/jira/browse/FLINK-24024] > Window TVF Supports session window > -- > > Key: FLINK-23544 > URL: https://issues.apache.org/jira/browse/FLINK-23544 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: JING ZHANG >Assignee: JING ZHANG >Priority: Minor > Labels: pull-request-available > Fix For: 1.14.0 > > > Window TVF would support SESSION window in the following case: > # SESSION Window TVF followed by Window Aggregate, in this case SESSION > window TVF would be pulled up into WindowAggregate, so Window assigner would > happen in WindowAggrgeate > > *Note, SESSION window TVF only works in limited cases currently, the > following user cases is not supported yet:* > # *SESSION WINDOW TVF followed by Window JOIN* > # *SESSION WINDOW TVF followed by Window RANK*** > *BESIDES, SESSION window Aggregate does not support the following performance > improvement yet:* > 1. Split Distinct Aggregation > 2. Local-global Aggregation > 3. Mini-batch Aggregate -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (FLINK-23544) Window TVF Supports session window
[ https://issues.apache.org/jira/browse/FLINK-23544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407770#comment-17407770 ] godfrey he edited comment on FLINK-23544 at 9/1/21, 2:33 AM: - [~twalthr] I didn't realize the syntax mistake when reviewing this pr, so sorry about that +1 to only expose the standard syntax, and revert the pr. was (Author: godfreyhe): [~twalthr] I didn't realize the syntax mistake when reviewing this pr, so sorry about that +1 to only expose the correct syntax. > Window TVF Supports session window > -- > > Key: FLINK-23544 > URL: https://issues.apache.org/jira/browse/FLINK-23544 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: JING ZHANG >Assignee: JING ZHANG >Priority: Minor > Labels: pull-request-available > Fix For: 1.14.0 > > > Window TVF would support SESSION window in the following case: > # SESSION Window TVF followed by Window Aggregate, in this case SESSION > window TVF would be pulled up into WindowAggregate, so Window assigner would > happen in WindowAggrgeate > > *Note, SESSION window TVF only works in limited cases currently, the > following user cases is not supported yet:* > # *SESSION WINDOW TVF followed by Window JOIN* > # *SESSION WINDOW TVF followed by Window RANK*** > *BESIDES, SESSION window Aggregate does not support the following performance > improvement yet:* > 1. Split Distinct Aggregation > 2. Local-global Aggregation > 3. Mini-batch Aggregate -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (FLINK-23544) Window TVF Supports session window
[ https://issues.apache.org/jira/browse/FLINK-23544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407205#comment-17407205 ] Timo Walther edited comment on FLINK-23544 at 8/31/21, 9:41 AM: If we want to fix this issue properly we need to wait for CALCITE-4337. We have put it on our internal team roadmap but with lower priority, any help here would be highly appreciated. Esp. by people that are more familiar with the Calcite code base. I would vote for reverting this change. It is not compliant with SQL and we cannot afford a third syntax for session windows once CALCITE-4337 is implemented. Users have an alternative using the old session windows for 1.14. But we should aim to fix this for 1.15. was (Author: twalthr): If we want to fix this issue properly we need to wait for CALCITE-4337. We have put it on our internal team roadmap but with lower priority, any help here would be highly appreciated. Esp. by people that are more familiar with the Calcite code base. I would vote for reverting this change. It is not compliant with SQL and we cannot effort a third syntax for session windows once CALCITE-4337 is implemented. Users have an alternative using the old session windows for 1.14. But we should aim to fix this for 1.15. > Window TVF Supports session window > -- > > Key: FLINK-23544 > URL: https://issues.apache.org/jira/browse/FLINK-23544 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: JING ZHANG >Assignee: JING ZHANG >Priority: Minor > Labels: pull-request-available > Fix For: 1.14.0 > > > Window TVF would support SESSION window in the following case: > # SESSION Window TVF followed by Window Aggregate, in this case SESSION > window TVF would be pulled up into WindowAggregate, so Window assigner would > happen in WindowAggrgeate > > *Note, SESSION window TVF only works in limited cases currently, the > following user cases is not supported yet:* > # *SESSION WINDOW TVF followed by Window JOIN* > # *SESSION WINDOW TVF followed by Window RANK*** > *BESIDES, SESSION window Aggregate does not support the following performance > improvement yet:* > 1. Split Distinct Aggregation > 2. Local-global Aggregation > 3. Mini-batch Aggregate -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (FLINK-23544) Window TVF Supports session window
[ https://issues.apache.org/jira/browse/FLINK-23544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407205#comment-17407205 ] Timo Walther edited comment on FLINK-23544 at 8/31/21, 9:40 AM: If we want to fix this issue properly we need to wait for CALCITE-4337. We have put it on our internal team roadmap but with lower priority, any help here would be highly appreciated. Esp. by people that are more familiar with the Calcite code base. I would vote for reverting this change. It is not compliant with SQL and we cannot effort a third syntax for session windows once CALCITE-4337 is implemented. Users have an alternative using the old session windows for 1.14. But we should aim to fix this for 1.15. was (Author: twalthr): If we want to fix this issue properly we need to wait for CALCITE-4337. We have put it on our internal team roadmap but lower priority, any help here would be highly appreciated. Esp. by people that are more familiar with the Calcite code base. I would vote for reverting this change. It is not compliant with SQL and we cannot effort a third syntax for session windows once CALCITE-4337 is implemented. Users have an alternative using the old session windows for 1.14. But we should aim to fix this for 1.15. > Window TVF Supports session window > -- > > Key: FLINK-23544 > URL: https://issues.apache.org/jira/browse/FLINK-23544 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: JING ZHANG >Assignee: JING ZHANG >Priority: Minor > Labels: pull-request-available > Fix For: 1.14.0 > > > Window TVF would support SESSION window in the following case: > # SESSION Window TVF followed by Window Aggregate, in this case SESSION > window TVF would be pulled up into WindowAggregate, so Window assigner would > happen in WindowAggrgeate > > *Note, SESSION window TVF only works in limited cases currently, the > following user cases is not supported yet:* > # *SESSION WINDOW TVF followed by Window JOIN* > # *SESSION WINDOW TVF followed by Window RANK*** > *BESIDES, SESSION window Aggregate does not support the following performance > improvement yet:* > 1. Split Distinct Aggregation > 2. Local-global Aggregation > 3. Mini-batch Aggregate -- This message was sent by Atlassian Jira (v8.3.4#803005)
