[
https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802490#comment-17802490
]
Shengkai Fang edited comment on FLINK-33490 at 1/4/24 7:28 AM:
---
Hi, [~martijnvisser]. Thanks a lot for your patience and response.
To be honest, I must admit that this change will affect a small portion of
users. As shown in the examples in the table above, if there are columns with
the same name in a table, an error will be thrown, but we have deliberately
refined the error message to show the location of the conflicting column names
as clearly as possible. In fact, we scanned the impact of this fix on our
internal use and found that less than 3% of jobs were affected. Moreover, this
fix has been merged into the commercial branch for over a month now, and to
date, we have not received any user feedback on this issue. Therefore, I
believe the impact of this change is manageable.
I agree with you that FLINK-33740 is not needed; it would be better to modify
this ticket to be about document improvements. cc [~xuyangzhong]
was (Author: fsk119):
Hi, [~martijnvisser]. Thanks a lot for your patience and response.
To be honest, I must admit that this change will affect a small portion of
users. As shown in the examples in the table above, if there are columns with
the same name in a table, an error will be thrown, but we have deliberately
refined the error message to show the location of the conflicting column names
as clearly as possible. In fact, we scanned the impact of this fix on our
internal use and found that less than 0.5% of jobs were affected. Moreover,
this fix has been merged into the commercial branch for over a month now, and
to date, we have not received any user feedback on this issue. Therefore, I
believe the impact of this change is manageable.
I agree with you that FLINK-33740 is not needed; it would be better to modify
this ticket to be about document improvements. cc [~xuyangzhong]
> Validate the name conflicts when creating view
> --
>
> Key: FLINK-33490
> URL: https://issues.apache.org/jira/browse/FLINK-33490
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.19.0
>Reporter: Shengkai Fang
>Assignee: xuyang
>Priority: Major
> Labels: pull-request-available
>
> We should forbid
> ```
> CREATE VIEW id_view AS
> SELECT id, uid AS id FROM id_table
> ```
> As the SQL standards states,
> If is specified, then:
> i) If any two columns in the table specified by the have
> equivalent s, or if any column of that table has an
> implementation-dependent name, then a shall be specified.
> ii) Equivalent s shall not be specified more than once in the
> .
> Many databases also throw exception when view name conflicts, e.g. mysql,
> postgres.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
