[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644913#comment-16644913 ] ASF GitHub Bot commented on FLINK-10012: yanghua commented on issue #6475: [FLINK-10012] Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#issuecomment-428554348 @zentol Is there a need for Python-related PR? If not, can we consider closing it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Sub-task > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585698#comment-16585698 ] ASF GitHub Bot commented on FLINK-10012: yanghua commented on issue #6475: [FLINK-10012] Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#issuecomment-414256997 hi @zentol Can you tell me what is your idea about the Flink Python API? Should we continue to enhance it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Sub-task > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581021#comment-16581021 ] ASF GitHub Bot commented on FLINK-10012: yanghua commented on issue #6475: [FLINK-10012] Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#issuecomment-413184723 @zentol about this PR, is there anything need to modify? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Sub-task > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579653#comment-16579653 ] ASF GitHub Bot commented on FLINK-10012: yanghua commented on issue #6475: [FLINK-10012] Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#issuecomment-412836298 @zentol updated This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Sub-task > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[
https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579556#comment-16579556
]
ASF GitHub Bot commented on FLINK-10012:
zentol commented on a change in pull request #6475: [FLINK-10012] Add
setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
URL: https://github.com/apache/flink/pull/6475#discussion_r209890119
##
File path:
flink-libraries/flink-streaming-python/src/test/java/org/apache/flink/streaming/python/api/PythonStreamBinderTest.java
##
@@ -63,7 +63,7 @@ private static Path findUtilsModule() {
@Test
public void testProgram() throws Exception {
- Path testEntryPoint = new Path(getBaseTestPythonDir(),
"examples/word_count.py");
+ Path testEntryPoint = new Path(getBaseTestPythonDir(),
"run_all_tests.py");
Review comment:
nice catch, but please move this into a separate commit.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
> --
>
> Key: FLINK-10012
> URL: https://issues.apache.org/jira/browse/FLINK-10012
> Project: Flink
> Issue Type: Sub-task
> Components: Python API
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579557#comment-16579557 ] ASF GitHub Bot commented on FLINK-10012: zentol commented on a change in pull request #6475: [FLINK-10012] Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#discussion_r209891304 ## File path: flink-libraries/flink-streaming-python/src/test/python/org/apache/flink/streaming/python/api/test_stream_execution_env.py ## @@ -0,0 +1,30 @@ + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from org.apache.flink.streaming.api import TimeCharacteristic Review comment: double space after `import`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Sub-task > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579520#comment-16579520 ] ASF GitHub Bot commented on FLINK-10012: tillrohrmann commented on issue #6475: [FLINK-10012] Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#issuecomment-412812237 Thanks for the improving Flink's Python API @yanghua. As far as I can tell, the changes look good to me. I would additionally like to hear @zentol opinion whether the test is enough. There is no discussion/proposal yet how to proceed with Flink's Python support. There are, however, ideas how it could be tackled. One idea is to offer Python support through Beam, because the Python functionality in Beam is quite advanced and would allow people to run all kinds of Python libraries in their UDFs. Nothing is set in stone yet, but please keep in mind that Flink's own Python API might be affected by this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Sub-task > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578188#comment-16578188 ] ASF GitHub Bot commented on FLINK-10012: StefanRRichter commented on issue #6475: [FLINK-10012] Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#issuecomment-412497988 @tillrohrmann maybe you could please comment on this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Sub-task > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578183#comment-16578183 ] ASF GitHub Bot commented on FLINK-10012: zentol commented on issue #6475: [FLINK-10012] Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#issuecomment-412497674 @StefanRRichter I'm not aware of any such discussion taking place on the public or pmc-private mailing lists. Until that happens we most certainly will not outright reject contributions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Sub-task > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578172#comment-16578172 ] ASF GitHub Bot commented on FLINK-10012: yanghua commented on issue #6475: [FLINK-10012] Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#issuecomment-412495391 @StefanRRichter I don't mean to make users motivated to use it, but to say that the Python API has a matching standard (such as specific version) with the Java/Scala API for users who might be using it. OK, if the community doesn't plan to improve it. However, I recommend giving a clear description in the Python section of the official documentation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Sub-task > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578165#comment-16578165 ] ASF GitHub Bot commented on FLINK-10012: StefanRRichter commented on issue #6475: [FLINK-10012] Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#issuecomment-412493850 @yanghua I somewhat disagree. It is not a regression that we would need to fix, and why give users incentives to start/continue using an API that will soon be replaced? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Sub-task > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578157#comment-16578157 ] ASF GitHub Bot commented on FLINK-10012: yanghua commented on issue #6475: [FLINK-10012] Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#issuecomment-412493074 @StefanRRichter OK, I respect this decision, but since Flink already provides the Python API, I think a better option is to match Flink's Python API with a specific version of the DataStream API, and then we give a declaration on the documentation: Python api only supports which version, and will not be updated or upgraded. Instead of supporting a semi-finished product that cannot be explained. I want to enhance it, mainly because multiple users ask questions about the Python API on the mailing list. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Sub-task > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578151#comment-16578151 ] ASF GitHub Bot commented on FLINK-10012: StefanRRichter commented on issue #6475: [FLINK-10012] Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#issuecomment-412491024 @yanghua I had a few discussions with PMC members and the plans for Flink's Python support are centered around Apache Beam. While Flink's own Python API is not yet deprecated in a strict sense, I think it does not make much sense anymore to enhance it. For this reason, my suggestion would be to close the PRs and JIRAs about enhancing the Flink Python API and not put any more efforts into it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Sub-task > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572911#comment-16572911 ] ASF GitHub Bot commented on FLINK-10012: yanghua commented on issue #6475: [FLINK-10012] Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#issuecomment-411340866 @StefanRRichter can you review this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Sub-task > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569439#comment-16569439 ] ASF GitHub Bot commented on FLINK-10012: yanghua commented on issue #6475: [FLINK-10012] Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#issuecomment-410514508 @zentol added python test case, can you review this PR again? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Sub-task > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568130#comment-16568130 ] ASF GitHub Bot commented on FLINK-10012: yanghua commented on issue #6475: [FLINK-10012] Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#issuecomment-410232217 @zentol can you review this, so that I can start other issues and reuse the test file? thanks~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Sub-task > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10012) Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API
[ https://issues.apache.org/jira/browse/FLINK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566634#comment-16566634 ] ASF GitHub Bot commented on FLINK-10012: zentol commented on issue #6475: [FLINK-10012] Support setStreamTimeCharacteristic for Python API URL: https://github.com/apache/flink/pull/6475#issuecomment-409891504 If you're suggesting something like FLINK-1926 for streaming, sure, go ahead. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add setStreamTimeCharacteristic/getStreamTimeCharacteristic for Python API > -- > > Key: FLINK-10012 > URL: https://issues.apache.org/jira/browse/FLINK-10012 > Project: Flink > Issue Type: Improvement > Components: Python API >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
