[jira] [Commented] (FLINK-10211) Time indicators are not always materialised for LogicalJoin

2018-08-30 Thread Piotr Nowojski (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597185#comment-16597185
 ] 

Piotr Nowojski commented on FLINK-10211:


[~xccui] it looks so. I have discovered those bugs after looking at the code 
(not from faulty queries), so I'm not 100% sure if the symptoms of those two 
bugs are as described in https://issues.apache.org/jira/browse/FLINK-8897 . 
This https://issues.apache.org/jira/browse/FLINK-10211 join bug probably can 
cause it, however the other issue 
(https://issues.apache.org/jira/browse/FLINK-10210) with LogicalCorrelate is an 
not covered in https://issues.apache.org/jira/browse/FLINK-8897 

> Time indicators are not always materialised for LogicalJoin
> ---
>
> Key: FLINK-10211
> URL: https://issues.apache.org/jira/browse/FLINK-10211
> Project: Flink
>  Issue Type: Bug
>  Components: Table API & SQL
>Affects Versions: 1.6.0
>Reporter: Piotr Nowojski
>Priority: Major
>
> Currently 
> {{org.apache.flink.table.calcite.RelTimeIndicatorConverter#visit(LogicalJoin)}}
>  correctly handles only windowed joins. Output of non windowed joins 
> shouldn't contain any time indicators.
> CC [~twalthr]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10211) Time indicators are not always materialised for LogicalJoin

2018-08-24 Thread Xingcan Cui (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591587#comment-16591587
 ] 

Xingcan Cui commented on FLINK-10211:
-

Hi [~pnowojski], I guess the two tickets you just filed are related to 
FLINK-8897, right?

> Time indicators are not always materialised for LogicalJoin
> ---
>
> Key: FLINK-10211
> URL: https://issues.apache.org/jira/browse/FLINK-10211
> Project: Flink
>  Issue Type: Bug
>  Components: Table API & SQL
>Affects Versions: 1.6.0
>Reporter: Piotr Nowojski
>Priority: Major
>
> Currently 
> {{org.apache.flink.table.calcite.RelTimeIndicatorConverter#visit(LogicalJoin)}}
>  correctly handles only windowed joins. Output of non windowed joins 
> shouldn't contain any time indicators.
> CC [~twalthr]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)