[jira] [Commented] (FLINK-10378) Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE

2018-09-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630429#comment-16630429
 ] 

ASF GitHub Bot commented on FLINK-10378:


zentol closed pull request #6722: [FLINK-10378] [github] Comment out contribute 
guide from PULL_REQUEST_TEMPLATE
URL: https://github.com/apache/flink/pull/6722
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 62da82a1ee9..a017732dc52 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,4 +1,4 @@
-
+
 
 ## What is the purpose of the change
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE
> 
>
> Key: FLINK-10378
> URL: https://issues.apache.org/jira/browse/FLINK-10378
> Project: Flink
>  Issue Type: Improvement
>  Components: GitHub
>Reporter: tison
>Assignee: tison
>Priority: Major
>  Labels: pull-request-available
>
> Explicitly comment out contribute guide from PULL_REQUEST_TEMPLATE by .
> This is a hint to contributor that such message is as information and would 
> not appear at the final content, as a side effect also reduce the work the a 
> contributor delete such text every time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FLINK-10378) Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE

2018-09-21 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623911#comment-16623911
 ] 

ASF GitHub Bot commented on FLINK-10378:


TisonKun commented on issue #6722: [FLINK-10378] [github] Comment out 
contribute guide from PULL_REQUEST_TEMPLATE
URL: https://github.com/apache/flink/pull/6722#issuecomment-423611886
 
 
   @StephanEwen travis-ci must fail on other issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE
> 
>
> Key: FLINK-10378
> URL: https://issues.apache.org/jira/browse/FLINK-10378
> Project: Flink
>  Issue Type: Improvement
>  Components: GitHub
>Reporter: tison
>Assignee: tison
>Priority: Major
>  Labels: pull-request-available
>
> Explicitly comment out contribute guide from PULL_REQUEST_TEMPLATE by .
> This is a hint to contributor that such message is as information and would 
> not appear at the final content, as a side effect also reduce the work the a 
> contributor delete such text every time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FLINK-10378) Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622303#comment-16622303
 ] 

ASF GitHub Bot commented on FLINK-10378:


TisonKun commented on issue #6722: [FLINK-10378] [github] Hide/Comment out 
contribute guide from PULL_REQUEST_TEMPLATE
URL: https://github.com/apache/flink/pull/6722#issuecomment-423248081
 
 
   @StephanEwen sure


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE
> 
>
> Key: FLINK-10378
> URL: https://issues.apache.org/jira/browse/FLINK-10378
> Project: Flink
>  Issue Type: Improvement
>  Components: GitHub
>Reporter: 陈梓立
>Assignee: 陈梓立
>Priority: Major
>  Labels: pull-request-available
>
> Explicitly comment out contribute guide from PULL_REQUEST_TEMPLATE by .
> This is a hint to contributor that such message is as information and would 
> not appear at the final content, as a side effect also reduce the work the a 
> contributor delete such text every time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FLINK-10378) Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622295#comment-16622295
 ] 

ASF GitHub Bot commented on FLINK-10378:


StephanEwen commented on issue #6722: [FLINK-10378] [github] Hide/Comment out 
contribute guide from PULL_REQUEST_TEMPLATE
URL: https://github.com/apache/flink/pull/6722#issuecomment-423247012
 
 
   Putting a comment across the contents is fine.
   
   Can you put the other changes into a separate issue? I am not sure about 
those.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE
> 
>
> Key: FLINK-10378
> URL: https://issues.apache.org/jira/browse/FLINK-10378
> Project: Flink
>  Issue Type: Improvement
>  Components: GitHub
>Reporter: 陈梓立
>Assignee: 陈梓立
>Priority: Major
>  Labels: pull-request-available
>
> Explicitly comment out contribute guide from PULL_REQUEST_TEMPLATE by .
> This is a hint to contributor that such message is as information and would 
> not appear at the final content, as a side effect also reduce the work the a 
> contributor delete such text every time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FLINK-10378) Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622100#comment-16622100
 ] 

ASF GitHub Bot commented on FLINK-10378:


TisonKun commented on issue #6722: [FLINK-10378] [github] Hide/Comment out 
contribute guide from PULL_REQUEST_TEMPLATE
URL: https://github.com/apache/flink/pull/6722#issuecomment-423195180
 
 
   cc @StephanEwen @fhueske @tweise 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE
> 
>
> Key: FLINK-10378
> URL: https://issues.apache.org/jira/browse/FLINK-10378
> Project: Flink
>  Issue Type: Improvement
>  Components: GitHub
>Reporter: 陈梓立
>Assignee: 陈梓立
>Priority: Major
>  Labels: pull-request-available
>
> Explicitly comment out contribute guide from PULL_REQUEST_TEMPLATE by .
> This is a hint to contributor that such message is as information and would 
> not appear at the final content, as a side effect also reduce the work the a 
> contributor delete such text every time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FLINK-10378) Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622092#comment-16622092
 ] 

ASF GitHub Bot commented on FLINK-10378:


TisonKun commented on a change in pull request #6722: [FLINK-10378] [github] 
Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE
URL: https://github.com/apache/flink/pull/6722#discussion_r219173779
 
 

 ##
 File path: .github/PULL_REQUEST_TEMPLATE.md
 ##
 @@ -1,14 +1,13 @@
+
> Key: FLINK-10378
> URL: https://issues.apache.org/jira/browse/FLINK-10378
> Project: Flink
>  Issue Type: Improvement
>  Components: GitHub
>Reporter: 陈梓立
>Assignee: 陈梓立
>Priority: Major
>  Labels: pull-request-available
>
> Explicitly comment out contribute guide from PULL_REQUEST_TEMPLATE by .
> This is a hint to contributor that such message is as information and would 
> not appear at the final content, as a side effect also reduce the work the a 
> contributor delete such text every time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FLINK-10378) Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622091#comment-16622091
 ] 

ASF GitHub Bot commented on FLINK-10378:


TisonKun commented on a change in pull request #6722: [FLINK-10378] [github] 
Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE
URL: https://github.com/apache/flink/pull/6722#discussion_r219173213
 
 

 ##
 File path: .github/PULL_REQUEST_TEMPLATE.md
 ##
 @@ -1,14 +1,13 @@
+
> Key: FLINK-10378
> URL: https://issues.apache.org/jira/browse/FLINK-10378
> Project: Flink
>  Issue Type: Improvement
>  Components: GitHub
>Reporter: 陈梓立
>Assignee: 陈梓立
>Priority: Major
>  Labels: pull-request-available
>
> Explicitly comment out contribute guide from PULL_REQUEST_TEMPLATE by .
> This is a hint to contributor that such message is as information and would 
> not appear at the final content, as a side effect also reduce the work the a 
> contributor delete such text every time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FLINK-10378) Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622089#comment-16622089
 ] 

ASF GitHub Bot commented on FLINK-10378:


TisonKun commented on a change in pull request #6722: [FLINK-10378] [github] 
Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE
URL: https://github.com/apache/flink/pull/6722#discussion_r219173213
 
 

 ##
 File path: .github/PULL_REQUEST_TEMPLATE.md
 ##
 @@ -1,14 +1,13 @@
+
> Key: FLINK-10378
> URL: https://issues.apache.org/jira/browse/FLINK-10378
> Project: Flink
>  Issue Type: Improvement
>  Components: GitHub
>Reporter: 陈梓立
>Assignee: 陈梓立
>Priority: Major
>  Labels: pull-request-available
>
> Explicitly comment out contribute guide from PULL_REQUEST_TEMPLATE by .
> This is a hint to contributor that such message is as information and would 
> not appear at the final content, as a side effect also reduce the work the a 
> contributor delete such text every time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FLINK-10378) Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE

2018-09-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622084#comment-16622084
 ] 

ASF GitHub Bot commented on FLINK-10378:


TisonKun commented on a change in pull request #6722: [FLINK-10378] [github] 
Hide/Comment out contribute guide from PULL_REQUEST_TEMPLATE
URL: https://github.com/apache/flink/pull/6722#discussion_r219172408
 
 

 ##
 File path: .github/PULL_REQUEST_TEMPLATE.md
 ##
 @@ -1,14 +1,13 @@
+
> Key: FLINK-10378
> URL: https://issues.apache.org/jira/browse/FLINK-10378
> Project: Flink
>  Issue Type: Improvement
>  Components: GitHub
>Reporter: 陈梓立
>Assignee: 陈梓立
>Priority: Major
>  Labels: pull-request-available
>
> Explicitly comment out contribute guide from PULL_REQUEST_TEMPLATE by .
> This is a hint to contributor that such message is as information and would 
> not appear at the final content, as a side effect also reduce the work the a 
> contributor delete such text every time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)