[jira] [Commented] (FLINK-10405) Port JobManagerFailsITCase to new code base

2018-10-16 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652551#comment-16652551
 ] 

ASF GitHub Bot commented on FLINK-10405:


tillrohrmann closed pull request #6841: [FLINK-10405] [tests] Port 
JobManagerFailsITCase to new code base
URL: https://github.com/apache/flink/pull/6841
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureBatchRecoveryITCase.java
 
b/flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java
similarity index 98%
rename from 
flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureBatchRecoveryITCase.java
rename to 
flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java
index 9e9ce076197..ec3f1e1b9d3 100644
--- 
a/flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureBatchRecoveryITCase.java
+++ 
b/flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java
@@ -93,7 +93,7 @@
  */
 @SuppressWarnings("serial")
 @RunWith(Parameterized.class)
-public class JobManagerHAProcessFailureBatchRecoveryITCase extends TestLogger {
+public class JobManagerHAProcessFailureRecoveryITCase extends TestLogger {
 
private static ZooKeeperTestEnvironment zooKeeper;
 
@@ -131,7 +131,7 @@ public static void tearDown() throws Exception {
 
private final ExecutionMode executionMode;
 
-   public JobManagerHAProcessFailureBatchRecoveryITCase(ExecutionMode 
executionMode) {
+   public JobManagerHAProcessFailureRecoveryITCase(ExecutionMode 
executionMode) {
this.executionMode = executionMode;
}
 
@@ -369,9 +369,9 @@ public void run() {
leaderRetrievalService.stop();
}
 
-   for (DispatcherProcess jmProces : dispatcherProcesses) {
-   if (jmProces != null) {
-   jmProces.destroy();
+   for (DispatcherProcess dispatcherProcess : 
dispatcherProcesses) {
+   if (dispatcherProcess != null) {
+   dispatcherProcess.destroy();
}
}
 
diff --git 
a/flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/jobmanager/JobManagerFailsITCase.scala
 
b/flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/jobmanager/JobManagerFailsITCase.scala
deleted file mode 100644
index 5c9b1fb0c23..000
--- 
a/flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/jobmanager/JobManagerFailsITCase.scala
+++ /dev/null
@@ -1,148 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.api.scala.runtime.jobmanager
-
-import akka.actor.ActorSystem
-import akka.testkit.{ImplicitSender, TestKit}
-import org.apache.flink.configuration.{ConfigConstants, Configuration, 
JobManagerOptions, TaskManagerOptions}
-import org.apache.flink.runtime.akka.{AkkaUtils, ListeningBehaviour}
-import org.apache.flink.runtime.jobgraph.{JobGraph, JobVertex}
-import org.apache.flink.runtime.messages.Acknowledge
-import org.apache.flink.runtime.messages.JobManagerMessages._
-import 
org.apache.flink.runtime.testingUtils.TestingJobManagerMessages.NotifyWhenAtLeastNumTaskManagerAreRegistered
-import org.apache.flink.runtime.testingUtils.TestingMessages.DisableDisconnect
-import org.apache.flink.runtime.testingUtils.{ScalaTestingUtils, 
TestingCluster, TestingUtils}
-import org.apache.flink.runtime.testtasks.{BlockingNoOpInvokable, 
NoOpInvokable}
-import org.junit.runner.RunWith
-import org.scalatest.junit.JUnitRunner
-import org.scalatest.{BeforeAndAfterAll, Matchers, WordSpecLike}
-
-@RunWith(classOf[JUnitRunner])

[jira] [Commented] (FLINK-10405) Port JobManagerFailsITCase to new code base

2018-10-16 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651655#comment-16651655
 ] 

ASF GitHub Bot commented on FLINK-10405:


tillrohrmann commented on a change in pull request #6841: [FLINK-10405] [tests] 
Port JobManagerFailsITCase to new code base
URL: https://github.com/apache/flink/pull/6841#discussion_r225532357
 
 

 ##
 File path: 
flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java
 ##
 @@ -325,6 +325,21 @@ public void run() {
dispatcherProcesses[1] = new DispatcherProcess(1, 
config);
dispatcherProcesses[1].startProcess();
 
+   // get new dispatcher gateway
+   
leaderListener.waitForNewLeader(deadline.timeLeft().toMillis());
+
+   leaderAddress = leaderListener.getAddress();
+   leaderId = leaderListener.getLeaderSessionID();
+
+   final CompletableFuture 
newDispatcherGatewayFuture = rpcService.connect(
+   leaderAddress,
+   DispatcherId.fromUuid(leaderId),
+   DispatcherGateway.class);
+   final DispatcherGateway newDispatcherGateway = 
newDispatcherGatewayFuture.get();
+
+   // Wait for all task managers to connect to the new 
leading job manager
+   waitForTaskManagers(numberOfTaskManagers, 
newDispatcherGateway, deadline.timeLeft());
 
 Review comment:
   Great @TisonKun.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Port JobManagerFailsITCase to new code base
> ---
>
> Key: FLINK-10405
> URL: https://issues.apache.org/jira/browse/FLINK-10405
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests
>Affects Versions: 1.7.0
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Port {{JobManagerFailsITCase}} to new code base.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10405) Port JobManagerFailsITCase to new code base

2018-10-16 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651648#comment-16651648
 ] 

ASF GitHub Bot commented on FLINK-10405:


TisonKun commented on a change in pull request #6841: [FLINK-10405] [tests] 
Port JobManagerFailsITCase to new code base
URL: https://github.com/apache/flink/pull/6841#discussion_r225530276
 
 

 ##
 File path: 
flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java
 ##
 @@ -325,6 +325,21 @@ public void run() {
dispatcherProcesses[1] = new DispatcherProcess(1, 
config);
dispatcherProcesses[1].startProcess();
 
+   // get new dispatcher gateway
+   
leaderListener.waitForNewLeader(deadline.timeLeft().toMillis());
+
+   leaderAddress = leaderListener.getAddress();
+   leaderId = leaderListener.getLeaderSessionID();
+
+   final CompletableFuture 
newDispatcherGatewayFuture = rpcService.connect(
+   leaderAddress,
+   DispatcherId.fromUuid(leaderId),
+   DispatcherGateway.class);
+   final DispatcherGateway newDispatcherGateway = 
newDispatcherGatewayFuture.get();
+
+   // Wait for all task managers to connect to the new 
leading job manager
+   waitForTaskManagers(numberOfTaskManagers, 
newDispatcherGateway, deadline.timeLeft());
 
 Review comment:
   Done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Port JobManagerFailsITCase to new code base
> ---
>
> Key: FLINK-10405
> URL: https://issues.apache.org/jira/browse/FLINK-10405
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests
>Affects Versions: 1.7.0
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Port {{JobManagerFailsITCase}} to new code base.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10405) Port JobManagerFailsITCase to new code base

2018-10-16 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651640#comment-16651640
 ] 

ASF GitHub Bot commented on FLINK-10405:


tillrohrmann commented on a change in pull request #6841: [FLINK-10405] [tests] 
Port JobManagerFailsITCase to new code base
URL: https://github.com/apache/flink/pull/6841#discussion_r225528980
 
 

 ##
 File path: 
flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java
 ##
 @@ -325,6 +325,21 @@ public void run() {
dispatcherProcesses[1] = new DispatcherProcess(1, 
config);
dispatcherProcesses[1].startProcess();
 
+   // get new dispatcher gateway
+   
leaderListener.waitForNewLeader(deadline.timeLeft().toMillis());
+
+   leaderAddress = leaderListener.getAddress();
+   leaderId = leaderListener.getLeaderSessionID();
+
+   final CompletableFuture 
newDispatcherGatewayFuture = rpcService.connect(
+   leaderAddress,
+   DispatcherId.fromUuid(leaderId),
+   DispatcherGateway.class);
+   final DispatcherGateway newDispatcherGateway = 
newDispatcherGatewayFuture.get();
+
+   // Wait for all task managers to connect to the new 
leading job manager
+   waitForTaskManagers(numberOfTaskManagers, 
newDispatcherGateway, deadline.timeLeft());
 
 Review comment:
   Yes, I would be in favour of this @TisonKun.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Port JobManagerFailsITCase to new code base
> ---
>
> Key: FLINK-10405
> URL: https://issues.apache.org/jira/browse/FLINK-10405
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests
>Affects Versions: 1.7.0
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Port {{JobManagerFailsITCase}} to new code base.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10405) Port JobManagerFailsITCase to new code base

2018-10-16 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651639#comment-16651639
 ] 

ASF GitHub Bot commented on FLINK-10405:


tillrohrmann commented on a change in pull request #6841: [FLINK-10405] [tests] 
Port JobManagerFailsITCase to new code base
URL: https://github.com/apache/flink/pull/6841#discussion_r225528980
 
 

 ##
 File path: 
flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java
 ##
 @@ -325,6 +325,21 @@ public void run() {
dispatcherProcesses[1] = new DispatcherProcess(1, 
config);
dispatcherProcesses[1].startProcess();
 
+   // get new dispatcher gateway
+   
leaderListener.waitForNewLeader(deadline.timeLeft().toMillis());
+
+   leaderAddress = leaderListener.getAddress();
+   leaderId = leaderListener.getLeaderSessionID();
+
+   final CompletableFuture 
newDispatcherGatewayFuture = rpcService.connect(
+   leaderAddress,
+   DispatcherId.fromUuid(leaderId),
+   DispatcherGateway.class);
+   final DispatcherGateway newDispatcherGateway = 
newDispatcherGatewayFuture.get();
+
+   // Wait for all task managers to connect to the new 
leading job manager
+   waitForTaskManagers(numberOfTaskManagers, 
newDispatcherGateway, deadline.timeLeft());
 
 Review comment:
   Yes, I would be in favour of this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Port JobManagerFailsITCase to new code base
> ---
>
> Key: FLINK-10405
> URL: https://issues.apache.org/jira/browse/FLINK-10405
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests
>Affects Versions: 1.7.0
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Port {{JobManagerFailsITCase}} to new code base.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10405) Port JobManagerFailsITCase to new code base

2018-10-15 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650342#comment-16650342
 ] 

ASF GitHub Bot commented on FLINK-10405:


TisonKun commented on a change in pull request #6841: [FLINK-10405] [tests] 
Port JobManagerFailsITCase to new code base
URL: https://github.com/apache/flink/pull/6841#discussion_r225202176
 
 

 ##
 File path: 
flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java
 ##
 @@ -325,6 +325,21 @@ public void run() {
dispatcherProcesses[1] = new DispatcherProcess(1, 
config);
dispatcherProcesses[1].startProcess();
 
+   // get new dispatcher gateway
+   
leaderListener.waitForNewLeader(deadline.timeLeft().toMillis());
+
+   leaderAddress = leaderListener.getAddress();
+   leaderId = leaderListener.getLeaderSessionID();
+
+   final CompletableFuture 
newDispatcherGatewayFuture = rpcService.connect(
+   leaderAddress,
+   DispatcherId.fromUuid(leaderId),
+   DispatcherGateway.class);
+   final DispatcherGateway newDispatcherGateway = 
newDispatcherGatewayFuture.get();
+
+   // Wait for all task managers to connect to the new 
leading job manager
+   waitForTaskManagers(numberOfTaskManagers, 
newDispatcherGateway, deadline.timeLeft());
 
 Review comment:
   @tillrohrmann So I revert this change to proceed this pull request?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Port JobManagerFailsITCase to new code base
> ---
>
> Key: FLINK-10405
> URL: https://issues.apache.org/jira/browse/FLINK-10405
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests
>Affects Versions: 1.7.0
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Port {{JobManagerFailsITCase}} to new code base.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10405) Port JobManagerFailsITCase to new code base

2018-10-15 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649931#comment-16649931
 ] 

ASF GitHub Bot commented on FLINK-10405:


TisonKun commented on a change in pull request #6841: [FLINK-10405] [tests] 
Port JobManagerFailsITCase to new code base
URL: https://github.com/apache/flink/pull/6841#discussion_r225089055
 
 

 ##
 File path: 
flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java
 ##
 @@ -325,6 +325,21 @@ public void run() {
dispatcherProcesses[1] = new DispatcherProcess(1, 
config);
dispatcherProcesses[1].startProcess();
 
+   // get new dispatcher gateway
+   
leaderListener.waitForNewLeader(deadline.timeLeft().toMillis());
+
+   leaderAddress = leaderListener.getAddress();
+   leaderId = leaderListener.getLeaderSessionID();
+
+   final CompletableFuture 
newDispatcherGatewayFuture = rpcService.connect(
+   leaderAddress,
+   DispatcherId.fromUuid(leaderId),
+   DispatcherGateway.class);
+   final DispatcherGateway newDispatcherGateway = 
newDispatcherGatewayFuture.get();
+
+   // Wait for all task managers to connect to the new 
leading job manager
+   waitForTaskManagers(numberOfTaskManagers, 
newDispatcherGateway, deadline.timeLeft());
 
 Review comment:
   Yes of course. I saw the removed test "A TaskManager detect a lost 
connection to the JobManager and try to reconnect to it" explicitly asserts 
this and thus add this block. I am not opposite to revert it since it is 
implicitly 
asserted if the jobs finishes successfully.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Port JobManagerFailsITCase to new code base
> ---
>
> Key: FLINK-10405
> URL: https://issues.apache.org/jira/browse/FLINK-10405
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests
>Affects Versions: 1.7.0
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Port {{JobManagerFailsITCase}} to new code base.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10405) Port JobManagerFailsITCase to new code base

2018-10-15 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649925#comment-16649925
 ] 

ASF GitHub Bot commented on FLINK-10405:


tillrohrmann commented on a change in pull request #6841: [FLINK-10405] [tests] 
Port JobManagerFailsITCase to new code base
URL: https://github.com/apache/flink/pull/6841#discussion_r225087527
 
 

 ##
 File path: 
flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java
 ##
 @@ -325,6 +325,21 @@ public void run() {
dispatcherProcesses[1] = new DispatcherProcess(1, 
config);
dispatcherProcesses[1].startProcess();
 
+   // get new dispatcher gateway
+   
leaderListener.waitForNewLeader(deadline.timeLeft().toMillis());
+
+   leaderAddress = leaderListener.getAddress();
+   leaderId = leaderListener.getLeaderSessionID();
+
+   final CompletableFuture 
newDispatcherGatewayFuture = rpcService.connect(
+   leaderAddress,
+   DispatcherId.fromUuid(leaderId),
+   DispatcherGateway.class);
+   final DispatcherGateway newDispatcherGateway = 
newDispatcherGatewayFuture.get();
+
+   // Wait for all task managers to connect to the new 
leading job manager
+   waitForTaskManagers(numberOfTaskManagers, 
newDispatcherGateway, deadline.timeLeft());
 
 Review comment:
   Why do we have to add this code block? Shouldn't this implicitly be asserted 
if the jobs finishes successfully?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Port JobManagerFailsITCase to new code base
> ---
>
> Key: FLINK-10405
> URL: https://issues.apache.org/jira/browse/FLINK-10405
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests
>Affects Versions: 1.7.0
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Port {{JobManagerFailsITCase}} to new code base.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10405) Port JobManagerFailsITCase to new code base

2018-10-14 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649708#comment-16649708
 ] 

ASF GitHub Bot commented on FLINK-10405:


TisonKun opened a new pull request #6841: [FLINK-10405] [tests] Port 
JobManagerFailsITCase to new code base
URL: https://github.com/apache/flink/pull/6841
 
 
   
   
   ## What is the purpose of the change
   
   Port `JobManagerFailsITCase` to new code base. Basically I think that 
taskmanager can connect to the new `Dispatcher` and the whole job goes into a 
clean state after Dispatcher(old jobmanager somehow) fails is covered by 
`JobManagerHAProcessFailureBatchRecoveryITCase`. In fact, it is not only for 
batch but covers streaming. So just use it and add a bit verification.
   
   ## Brief change log
   
   - Remove `JobManagerFailsITCase.scala`
   - Verify number of taskmanager to cover that taskmanager would connect to 
the new `Dispatcher`.
   
   
   ## Verifying this change
   
   This change is itself a test.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (**no**)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (**no**)
 - The serializers: (**no**)
 - The runtime per-record code paths (performance sensitive): (**no**)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (**no**)
 - The S3 file system connector: (**no**)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (**no**)
 - If yes, how is the feature documented? (**not applicable**)
   
   cc @tillrohrmann @GJL 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Port JobManagerFailsITCase to new code base
> ---
>
> Key: FLINK-10405
> URL: https://issues.apache.org/jira/browse/FLINK-10405
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests
>Affects Versions: 1.7.0
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Port {{JobManagerFailsITCase}} to new code base.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10405) Port JobManagerFailsITCase to new code base

2018-10-06 Thread Till Rohrmann (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640796#comment-16640796
 ] 

Till Rohrmann commented on FLINK-10405:
---

The {{DispatcherProcess}} is the Flip-6 version of the {{JobManagerProcess}} 
and can be used to start a standalone {{Dispatcher}}. You can use it for tests 
as the {{JobManagerHAProcessFailureBatchRecoveryITCase}} does.

> Port JobManagerFailsITCase to new code base
> ---
>
> Key: FLINK-10405
> URL: https://issues.apache.org/jira/browse/FLINK-10405
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests
>Affects Versions: 1.7.0
>Reporter: tison
>Assignee: tison
>Priority: Major
> Fix For: 1.7.0
>
>
> Port {{JobManagerFailsITCase}} to new code base.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10405) Port JobManagerFailsITCase to new code base

2018-09-29 Thread tison (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632975#comment-16632975
 ] 

tison commented on FLINK-10405:
---

In FLIP-6, TM would try to reconnect JM 
https://github.com/apache/flink/commit/63d4819e197b1df1651157fd8f86c8ca0540d0b1

> Port JobManagerFailsITCase to new code base
> ---
>
> Key: FLINK-10405
> URL: https://issues.apache.org/jira/browse/FLINK-10405
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests
>Affects Versions: 1.7.0
>Reporter: tison
>Assignee: tison
>Priority: Major
> Fix For: 1.7.0
>
>
> Port {{JobManagerFailsITCase}} to new code base.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10405) Port JobManagerFailsITCase to new code base

2018-09-26 Thread tison (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628335#comment-16628335
 ] 

tison commented on FLINK-10405:
---

cc [~trohrm...@apache.org] is {{DispatcherProcess}} introduced with the purpose 
I state above?

> Port JobManagerFailsITCase to new code base
> ---
>
> Key: FLINK-10405
> URL: https://issues.apache.org/jira/browse/FLINK-10405
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests
>Affects Versions: 1.7.0
>Reporter: tison
>Assignee: tison
>Priority: Major
> Fix For: 1.7.0
>
>
> Port {{JobManagerFailsITCase}} to new code base.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10405) Port JobManagerFailsITCase to new code base

2018-09-26 Thread tison (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628331#comment-16628331
 ] 

tison commented on FLINK-10405:
---

The porting job would take advantage from FLINK-10403 
https://github.com/apache/flink/pull/6751/commits/df034e1ca192a74962da2792deef7b3c78de047c

It introduces a test utils {{DispatcherProcess}}, which, on JM failure, could 
start a new one and take over. IIRC {{MiniCluster}} does not provide such 
feature.

> Port JobManagerFailsITCase to new code base
> ---
>
> Key: FLINK-10405
> URL: https://issues.apache.org/jira/browse/FLINK-10405
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests
>Affects Versions: 1.7.0
>Reporter: tison
>Assignee: tison
>Priority: Major
> Fix For: 1.7.0
>
>
> Port {{JobManagerFailsITCase}} to new code base.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)