[jira] [Commented] (FLINK-10553) Unified sink and source table name in SQL statement
[ https://issues.apache.org/jira/browse/FLINK-10553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334083#comment-17334083 ] Flink Jira Bot commented on FLINK-10553: This issue was marked "stale-assigned" and has not received an update in 7 days. It is now automatically unassigned. If you are still working on it, you can assign it to yourself again. Please also give an update about the status of the work. > Unified sink and source table name in SQL statement > --- > > Key: FLINK-10553 > URL: https://issues.apache.org/jira/browse/FLINK-10553 > Project: Flink > Issue Type: Bug > Components: Table SQL / API >Affects Versions: 1.6.0, 1.7.0 >Reporter: wangsan >Assignee: wangsan >Priority: Major > Labels: pull-request-available, stale-assigned > Time Spent: 10m > Remaining Estimate: 0h > > Since sink table can now be registered using ExternalCatalog, just the same > as source table, the source and sink name in SQL statement should also be > treated equally. Now we can only use `catalog.database.table` for sink table > (enclosed in back-ticks as a identifier), this is not consistent with source > table name (do not treat the whole name as a identifier). > *INSERT INTO catalog.database.sinktable SELECT ... FROM > catalog.database.sourcetable* should be supported . -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-10553) Unified sink and source table name in SQL statement
[ https://issues.apache.org/jira/browse/FLINK-10553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323455#comment-17323455 ] Flink Jira Bot commented on FLINK-10553: This issue is assigned but has not received an update in 7 days so it has been labeled "stale-assigned". If you are still working on the issue, please give an update and remove the label. If you are no longer working on the issue, please unassign so someone else may work on it. In 7 days the issue will be automatically unassigned. > Unified sink and source table name in SQL statement > --- > > Key: FLINK-10553 > URL: https://issues.apache.org/jira/browse/FLINK-10553 > Project: Flink > Issue Type: Bug > Components: Table SQL / API >Affects Versions: 1.6.0, 1.7.0 >Reporter: wangsan >Assignee: wangsan >Priority: Major > Labels: pull-request-available, stale-assigned > Time Spent: 10m > Remaining Estimate: 0h > > Since sink table can now be registered using ExternalCatalog, just the same > as source table, the source and sink name in SQL statement should also be > treated equally. Now we can only use `catalog.database.table` for sink table > (enclosed in back-ticks as a identifier), this is not consistent with source > table name (do not treat the whole name as a identifier). > *INSERT INTO catalog.database.sinktable SELECT ... FROM > catalog.database.sourcetable* should be supported . -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-10553) Unified sink and source table name in SQL statement
[ https://issues.apache.org/jira/browse/FLINK-10553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650824#comment-16650824 ] ASF GitHub Bot commented on FLINK-10553: xuefuz commented on issue #6847: [FLINK-10553] [sql] Unified sink and source table name in SQL statement URL: https://github.com/apache/flink/pull/6847#issuecomment-430020997 Hi Jerry, Thanks for fixing this. Your changes seems good. However, I have a side question: do we expect that the external catalog understands the notation of "catalog.db.table", that's is, three level hierarchy, or it just take the table name literally. From InMemoryExternalCatalog, it seems to me the catalog doesn't seem doing anything interpretation on the given table name. I'm not sure if I missed anything. (Nothing wrong about your changes, but just about my understanding.) Thanks, Xuefu This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unified sink and source table name in SQL statement > --- > > Key: FLINK-10553 > URL: https://issues.apache.org/jira/browse/FLINK-10553 > Project: Flink > Issue Type: Bug > Components: Table API SQL >Affects Versions: 1.6.0, 1.7.0 >Reporter: wangsan >Assignee: wangsan >Priority: Major > Labels: pull-request-available > > Since sink table can now be registered using ExternalCatalog, just the same > as source table, the source and sink name in SQL statement should also be > treated equally. Now we can only use `catalog.database.table` for sink table > (enclosed in back-ticks as a identifier), this is not consistent with source > table name (do not treat the whole name as a identifier). > *INSERT INTO catalog.database.sinktable SELECT ... FROM > catalog.database.sourcetable* should be supported . -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10553) Unified sink and source table name in SQL statement
[ https://issues.apache.org/jira/browse/FLINK-10553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650409#comment-16650409 ] ASF GitHub Bot commented on FLINK-10553: jrthe42 opened a new pull request #6847: [FLINK-10553] [sql] Unified sink and source table name in SQL statement URL: https://github.com/apache/flink/pull/6847 ## What is the purpose of the change This pull request solves a bug in flink SQL statement, in which sink table name in INSERT INTO clause can only be enclosed in back-ticks. The sink table name should be consisted with source table name in FROM clause. ## Verifying this change This change is already covered by existing tests, such as *ExternalCatalogInsertTest#testBatchSQL*, *ExternalCatalogInsertTest#testStreamSQL*. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unified sink and source table name in SQL statement > --- > > Key: FLINK-10553 > URL: https://issues.apache.org/jira/browse/FLINK-10553 > Project: Flink > Issue Type: Bug > Components: Table API SQL >Affects Versions: 1.6.0, 1.7.0 >Reporter: wangsan >Assignee: wangsan >Priority: Major > Labels: pull-request-available > > Since sink table can now be registered using ExternalCatalog, just the same > as source table, the source and sink name in SQL statement should also be > treated equally. Now we can only use `catalog.database.table` for sink table > (enclosed in back-ticks as a identifier), this is not consistent with source > table name (do not treat the whole name as a identifier). > *INSERT INTO catalog.database.sinktable SELECT ... FROM > catalog.database.sourcetable* should be supported . -- This message was sent by Atlassian JIRA (v7.6.3#76005)
