[jira] [Commented] (FLINK-10964) sql-client throws exception when paging through finished batch query
[
https://issues.apache.org/jira/browse/FLINK-10964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716340#comment-16716340
]
vinoyang commented on FLINK-10964:
--
[~twalthr] when you have time, can you help to review the PR of this issue? By
analyzing the source code, I found that the ResultRestore has been emptied at
the time of cancelQuery. The main problem with this exception is that when
stopping the retrieval thread, it still tries to call cancelQuery regardless of
the running state of the job.
> sql-client throws exception when paging through finished batch query
> -
>
> Key: FLINK-10964
> URL: https://issues.apache.org/jira/browse/FLINK-10964
> Project: Flink
> Issue Type: Bug
> Components: SQL Client
>Reporter: Seth Wiesman
>Assignee: vinoyang
>Priority: Major
> Labels: pull-request-available
>
> When paging through a batch query in state 'Finished' the sql client throws
> the following exception:
> {code:java}
> org.apache.flink.table.client.gateway.SqlExecutionException: Could not find a
> result with result identifier '0c7dce30d287fdd13b934fbefe5a38d1'.{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10964) sql-client throws exception when paging through finished batch query
[
https://issues.apache.org/jira/browse/FLINK-10964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713955#comment-16713955
]
ASF GitHub Bot commented on FLINK-10964:
yanghua opened a new pull request #7265: [FLINK-10964] SQL-client throws
exception when paging through finished batch query
URL: https://github.com/apache/flink/pull/7265
## What is the purpose of the change
*This pull request fixes SQL-client throws exception when paging through
finished batch query*
## Brief change log
- *Fix SQL-client throws exception when paging through finished batch
query*
## Verifying this change
This change added tests and can be verified as follows:
- *testRetrieveBoundedStreamQueryExecutionChangelog()*
- *testRetrieveBoundedStreamQueryExecutionTable()*
- *testRetrieveResultAfterBatchQueryFinished*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ **not documented**)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> sql-client throws exception when paging through finished batch query
> -
>
> Key: FLINK-10964
> URL: https://issues.apache.org/jira/browse/FLINK-10964
> Project: Flink
> Issue Type: Bug
> Components: SQL Client
>Reporter: Seth Wiesman
>Assignee: vinoyang
>Priority: Major
> Labels: pull-request-available
>
> When paging through a batch query in state 'Finished' the sql client throws
> the following exception:
> {code:java}
> org.apache.flink.table.client.gateway.SqlExecutionException: Could not find a
> result with result identifier '0c7dce30d287fdd13b934fbefe5a38d1'.{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10964) sql-client throws exception when paging through finished batch query
[
https://issues.apache.org/jira/browse/FLINK-10964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711334#comment-16711334
]
vinoyang commented on FLINK-10964:
--
[~twalthr] Thank you for providing more information. I personally do not tend
to introduce the timer, there are already a lot of configuration items, we can
delete the result of the job directly when calling cacelQuery.
> sql-client throws exception when paging through finished batch query
> -
>
> Key: FLINK-10964
> URL: https://issues.apache.org/jira/browse/FLINK-10964
> Project: Flink
> Issue Type: Bug
> Components: SQL Client
>Reporter: Seth Wiesman
>Assignee: vinoyang
>Priority: Major
>
> When paging through a batch query in state 'Finished' the sql client throws
> the following exception:
> {code:java}
> org.apache.flink.table.client.gateway.SqlExecutionException: Could not find a
> result with result identifier '0c7dce30d287fdd13b934fbefe5a38d1'.{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10964) sql-client throws exception when paging through finished batch query
[
https://issues.apache.org/jira/browse/FLINK-10964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711232#comment-16711232
]
Timo Walther commented on FLINK-10964:
--
I can give more information here. The issue is rather a conceptual problem.
Currently, we only maintain results until a job has finished. If the job is
bounded (for batch or streaming with bounded sources), the result store is
cleaned up even though the CLI still wants to page through the result. A
solution would be:
- keep results in {{ResultStore}} even if query has been stopped
- delete result when {{Executor#cancelQuery}} is called
- or by a timeout that has been specified using the "execution" properties
(meaning we need a timer service in the result store).
> sql-client throws exception when paging through finished batch query
> -
>
> Key: FLINK-10964
> URL: https://issues.apache.org/jira/browse/FLINK-10964
> Project: Flink
> Issue Type: Bug
> Components: SQL Client
>Reporter: Seth Wiesman
>Assignee: vinoyang
>Priority: Major
>
> When paging through a batch query in state 'Finished' the sql client throws
> the following exception:
> {code:java}
> org.apache.flink.table.client.gateway.SqlExecutionException: Could not find a
> result with result identifier '0c7dce30d287fdd13b934fbefe5a38d1'.{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10964) sql-client throws exception when paging through finished batch query
[
https://issues.apache.org/jira/browse/FLINK-10964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711188#comment-16711188
]
vinoyang commented on FLINK-10964:
--
[~sjwiesman] Can you provide more details and context about the exception?
thanks.
> sql-client throws exception when paging through finished batch query
> -
>
> Key: FLINK-10964
> URL: https://issues.apache.org/jira/browse/FLINK-10964
> Project: Flink
> Issue Type: Bug
> Components: SQL Client
>Reporter: Seth Wiesman
>Assignee: vinoyang
>Priority: Major
>
> When paging through a batch query in state 'Finished' the sql client throws
> the following exception:
> {code:java}
> org.apache.flink.table.client.gateway.SqlExecutionException: Could not find a
> result with result identifier '0c7dce30d287fdd13b934fbefe5a38d1'.{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
