[jira] [Commented] (FLINK-11039) LogicalExchange and HashPartitioner realization
[ https://issues.apache.org/jira/browse/FLINK-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716238#comment-16716238 ] ASF GitHub Bot commented on FLINK-11039: ambition119 closed pull request #7202: [FLINK-11039] LogicalExchange and HashPartitioner realization URL: https://github.com/apache/flink/pull/7202 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > LogicalExchange and HashPartitioner realization > --- > > Key: FLINK-11039 > URL: https://issues.apache.org/jira/browse/FLINK-11039 > Project: Flink > Issue Type: Improvement > Components: Table API SQL >Affects Versions: 1.6.2, 1.7.0 >Reporter: ambition >Priority: Minor > Labels: pull-request-available > Fix For: 1.7.0 > > > RelTimeIndicatorConverter.visit(exchange: LogicalExchange) function > realization. > FlinkLogicalExchange realization > org.apache.calcite.rel.logical.LogicalExchange. > HashPartitioner is Partitioner that implements hash-based partitioning using > Java's `Object.hashCode`. support org.apache.calcite.rel.RelDistribution.Type > HASH_DISTRIBUTED -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11039) LogicalExchange and HashPartitioner realization
[
https://issues.apache.org/jira/browse/FLINK-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715635#comment-16715635
]
Fabian Hueske commented on FLINK-11039:
---
Hi [~ambition],
I still don't understand the purpose of this issue.
Can you share a query that fails due to missing support of {{LogicalExchange}}?
Thank you,
Fabian
> LogicalExchange and HashPartitioner realization
> ---
>
> Key: FLINK-11039
> URL: https://issues.apache.org/jira/browse/FLINK-11039
> Project: Flink
> Issue Type: Improvement
> Components: Table API SQL
>Affects Versions: 1.6.2, 1.7.0
>Reporter: ambition
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> RelTimeIndicatorConverter.visit(exchange: LogicalExchange) function
> realization.
> FlinkLogicalExchange realization
> org.apache.calcite.rel.logical.LogicalExchange.
> HashPartitioner is Partitioner that implements hash-based partitioning using
> Java's `Object.hashCode`. support org.apache.calcite.rel.RelDistribution.Type
> HASH_DISTRIBUTED
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11039) LogicalExchange and HashPartitioner realization
[ https://issues.apache.org/jira/browse/FLINK-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714470#comment-16714470 ] ASF GitHub Bot commented on FLINK-11039: ambition119 commented on issue #7202: [FLINK-11039] LogicalExchange and HashPartitioner realization URL: https://github.com/apache/flink/pull/7202#issuecomment-445745340 > Could you update the description of this PR? That is needed as context for a proper review. It was implemented as RelTimeIndicatorConverter.visit(exchange: LogicalExchange) function. Then found this function cannot be used directly in SQL statements, just this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > LogicalExchange and HashPartitioner realization > --- > > Key: FLINK-11039 > URL: https://issues.apache.org/jira/browse/FLINK-11039 > Project: Flink > Issue Type: Improvement > Components: Table API SQL >Affects Versions: 1.6.2, 1.7.0 >Reporter: ambition >Priority: Minor > Labels: pull-request-available > Fix For: 1.7.0 > > > RelTimeIndicatorConverter.visit(exchange: LogicalExchange) function > realization. > FlinkLogicalExchange realization > org.apache.calcite.rel.logical.LogicalExchange. > HashPartitioner is Partitioner that implements hash-based partitioning using > Java's `Object.hashCode`. support org.apache.calcite.rel.RelDistribution.Type > HASH_DISTRIBUTED -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11039) LogicalExchange and HashPartitioner realization
[ https://issues.apache.org/jira/browse/FLINK-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714448#comment-16714448 ] ASF GitHub Bot commented on FLINK-11039: StephanEwen commented on issue #7202: [FLINK-11039] LogicalExchange and HashPartitioner realization URL: https://github.com/apache/flink/pull/7202#issuecomment-445738751 Could you update the description of this PR? That is needed as context for a proper review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > LogicalExchange and HashPartitioner realization > --- > > Key: FLINK-11039 > URL: https://issues.apache.org/jira/browse/FLINK-11039 > Project: Flink > Issue Type: Improvement > Components: Table API SQL >Affects Versions: 1.6.2, 1.7.0 >Reporter: ambition >Priority: Minor > Labels: pull-request-available > Fix For: 1.7.0 > > > RelTimeIndicatorConverter.visit(exchange: LogicalExchange) function > realization. > FlinkLogicalExchange realization > org.apache.calcite.rel.logical.LogicalExchange. > HashPartitioner is Partitioner that implements hash-based partitioning using > Java's `Object.hashCode`. support org.apache.calcite.rel.RelDistribution.Type > HASH_DISTRIBUTED -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11039) LogicalExchange and HashPartitioner realization
[
https://issues.apache.org/jira/browse/FLINK-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708459#comment-16708459
]
Fabian Hueske commented on FLINK-11039:
---
Please correct me, if I'm wrong, but this is only relevant if we do physical
planning?
Right now, we manually convert the logical plan into a DataSet/DataStream
program, i.e., physical translation happens (to some extend) in the
{{translateToPlan()}} method. We won't see LogicalExchange nodes during
optimization.
So, is this part of a larger effort to move to physical optimization? If so,
this should be thoroughly discussed, IMO.
Best, Fabian
> LogicalExchange and HashPartitioner realization
> ---
>
> Key: FLINK-11039
> URL: https://issues.apache.org/jira/browse/FLINK-11039
> Project: Flink
> Issue Type: Improvement
> Components: Table API SQL
>Affects Versions: 1.6.2, 1.7.0
>Reporter: ambition
>Priority: Minor
> Fix For: 1.7.0
>
>
> RelTimeIndicatorConverter.visit(exchange: LogicalExchange) function
> realization.
> FlinkLogicalExchange realization
> org.apache.calcite.rel.logical.LogicalExchange.
> HashPartitioner is Partitioner that implements hash-based partitioning using
> Java's `Object.hashCode`. support org.apache.calcite.rel.RelDistribution.Type
> HASH_DISTRIBUTED
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11039) LogicalExchange and HashPartitioner realization
[ https://issues.apache.org/jira/browse/FLINK-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706717#comment-16706717 ] ambition commented on FLINK-11039: -- It was originally implemented as RelTimeIndicatorConverter.visit(exchange: LogicalExchange) function. But this function cannot be used directly in SQL statements, any distributed engine has Shuffle/Hash/Range/Broadcast operator to shuffle their data with other deamons in the runtime system. so this function helps to implement changes to these operations. > LogicalExchange and HashPartitioner realization > --- > > Key: FLINK-11039 > URL: https://issues.apache.org/jira/browse/FLINK-11039 > Project: Flink > Issue Type: Improvement > Components: Table API SQL >Affects Versions: 1.6.2, 1.7.0 >Reporter: ambition >Priority: Minor > Fix For: 1.7.0 > > > FlinkLogicalExchange realization > org.apache.calcite.rel.logical.LogicalExchange. > HashPartitioner is Partitioner that implements hash-based partitioning using > Java's `Object.hashCode`. support org.apache.calcite.rel.RelDistribution.Type > HASH_DISTRIBUTED -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11039) LogicalExchange and HashPartitioner realization
[ https://issues.apache.org/jira/browse/FLINK-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706089#comment-16706089 ] Jark Wu commented on FLINK-11039: - Hi [~ambition], could you explain more about why we need to introduce LogicalExchange node and what the benefit from this? > LogicalExchange and HashPartitioner realization > --- > > Key: FLINK-11039 > URL: https://issues.apache.org/jira/browse/FLINK-11039 > Project: Flink > Issue Type: Improvement > Components: Table API SQL >Affects Versions: 1.6.2, 1.7.0 >Reporter: ambition >Priority: Minor > Fix For: 1.7.0 > > > FlinkLogicalExchange realization > org.apache.calcite.rel.logical.LogicalExchange. > HashPartitioner is Partitioner that implements hash-based partitioning using > Java's `Object.hashCode`. support org.apache.calcite.rel.RelDistribution.Type > HASH_DISTRIBUTED -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11039) LogicalExchange and HashPartitioner realization
[ https://issues.apache.org/jira/browse/FLINK-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705710#comment-16705710 ] ambition commented on FLINK-11039: -- pull request links [PR7202|https://github.com/apache/flink/pull/7202] > LogicalExchange and HashPartitioner realization > --- > > Key: FLINK-11039 > URL: https://issues.apache.org/jira/browse/FLINK-11039 > Project: Flink > Issue Type: Improvement > Components: Table API SQL >Affects Versions: 1.6.2, 1.7.0 >Reporter: ambition >Priority: Minor > Fix For: 1.7.0 > > > FlinkLogicalExchange realization > org.apache.calcite.rel.logical.LogicalExchange. > HashPartitioner is Partitioner that implements hash-based partitioning using > Java's `Object.hashCode`. support org.apache.calcite.rel.RelDistribution.Type > HASH_DISTRIBUTED -- This message was sent by Atlassian JIRA (v7.6.3#76005)
