[jira] [Commented] (FLINK-11041) ReinterpretDataStreamAsKeyedStreamITCase.testReinterpretAsKeyedStream failed on Travis
[
https://issues.apache.org/jira/browse/FLINK-11041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716838#comment-16716838
]
ASF GitHub Bot commented on FLINK-11041:
tillrohrmann closed pull request #7268: [FLINK-11041][test]
ReinterpretDataStreamAsKeyedStreamITCase source s…
URL: https://github.com/apache/flink/pull/7268
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/flink-streaming-java/src/test/java/org/apache/flink/streaming/api/datastream/ReinterpretDataStreamAsKeyedStreamITCase.java
b/flink-streaming-java/src/test/java/org/apache/flink/streaming/api/datastream/ReinterpretDataStreamAsKeyedStreamITCase.java
index 6a1b9ee75f7..ff28d1d 100644
---
a/flink-streaming-java/src/test/java/org/apache/flink/streaming/api/datastream/ReinterpretDataStreamAsKeyedStreamITCase.java
+++
b/flink-streaming-java/src/test/java/org/apache/flink/streaming/api/datastream/ReinterpretDataStreamAsKeyedStreamITCase.java
@@ -122,7 +122,9 @@ public RandomTupleSource(int numEvents, int numKeys) {
public void run(SourceContext> out)
throws Exception {
Random random = new Random(42);
while (--remainingEvents >= 0) {
- out.collect(new
Tuple2<>(random.nextInt(numKeys), 1));
+ synchronized (out.getCheckpointLock()) {
+ out.collect(new
Tuple2<>(random.nextInt(numKeys), 1));
+ }
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ReinterpretDataStreamAsKeyedStreamITCase.testReinterpretAsKeyedStream failed
> on Travis
> --
>
> Key: FLINK-11041
> URL: https://issues.apache.org/jira/browse/FLINK-11041
> Project: Flink
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.8.0
>Reporter: Till Rohrmann
>Assignee: Stefan Richter
>Priority: Critical
> Labels: pull-request-available, test-stability
> Fix For: 1.8.0
>
>
> {{ReinterpretDataStreamAsKeyedStreamITCase.testReinterpretAsKeyedStream}}
> failed on Travis:
> https://api.travis-ci.org/v3/job/461707550/log.txt
> https://travis-ci.org/apache/flink/jobs/461707550
> It seems that the test job is producing wrong results:
> {code}
> testReinterpretAsKeyedStream(org.apache.flink.streaming.api.datastream.ReinterpretDataStreamAsKeyedStreamITCase)
> Time elapsed: 8.357 sec <<< ERROR!
> org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
> at
> org.apache.flink.runtime.jobmaster.JobResult.toJobExecutionResult(JobResult.java:146)
> at
> org.apache.flink.runtime.minicluster.MiniCluster.executeJobBlocking(MiniCluster.java:647)
> at
> org.apache.flink.streaming.api.environment.LocalStreamEnvironment.execute(LocalStreamEnvironment.java:123)
> at
> org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.execute(StreamExecutionEnvironment.java:1510)
> at
> org.apache.flink.streaming.api.datastream.ReinterpretDataStreamAsKeyedStreamITCase.testReinterpretAsKeyedStream(ReinterpretDataStreamAsKeyedStreamITCase.java:107)
> Caused by: java.lang.AssertionError: expected:<300> but was:<301>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> org.apache.flink.streaming.api.datastream.ReinterpretDataStreamAsKeyedStreamITCase$ValidatingSink.close(ReinterpretDataStreamAsKeyedStreamITCase.java:295)
> at
> org.apache.flink.api.common.functions.util.FunctionUtils.closeFunction(FunctionUtils.java:43)
> at
> org.apache.flink.streaming.api.operators.AbstractUdfStreamOperator.close(AbstractUdfStreamOperator.java:109)
> at
> org.apache.flink.streaming.runtime.tasks.StreamTask.closeAllOperators(StreamTask.java:442)
> at
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:317)
> at org.apache.flink.runtime.taskmanager.Task.run(Task.java:704)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11041) ReinterpretDataStreamAsKeyedStreamITCase.testReinterpretAsKeyedStream failed on Travis
[
https://issues.apache.org/jira/browse/FLINK-11041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715174#comment-16715174
]
ASF GitHub Bot commented on FLINK-11041:
StefanRRichter opened a new pull request #7268: [FLINK-11041][test]
ReinterpretDataStreamAsKeyedStreamITCase source s…
URL: https://github.com/apache/flink/pull/7268
## What is the purpose of the change
This test fixes the flaky behavior of
`ReinterpretDataStreamAsKeyedStreamITCase`. the problem was that the test was
changed to also test failover, but the source did not use the checkpointing
lock.
## Brief change log
Hold checkpointing lock in the test's source function.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ReinterpretDataStreamAsKeyedStreamITCase.testReinterpretAsKeyedStream failed
> on Travis
> --
>
> Key: FLINK-11041
> URL: https://issues.apache.org/jira/browse/FLINK-11041
> Project: Flink
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.8.0
>Reporter: Till Rohrmann
>Priority: Critical
> Labels: pull-request-available, test-stability
> Fix For: 1.8.0
>
>
> {{ReinterpretDataStreamAsKeyedStreamITCase.testReinterpretAsKeyedStream}}
> failed on Travis:
> https://api.travis-ci.org/v3/job/461707550/log.txt
> https://travis-ci.org/apache/flink/jobs/461707550
> It seems that the test job is producing wrong results:
> {code}
> testReinterpretAsKeyedStream(org.apache.flink.streaming.api.datastream.ReinterpretDataStreamAsKeyedStreamITCase)
> Time elapsed: 8.357 sec <<< ERROR!
> org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
> at
> org.apache.flink.runtime.jobmaster.JobResult.toJobExecutionResult(JobResult.java:146)
> at
> org.apache.flink.runtime.minicluster.MiniCluster.executeJobBlocking(MiniCluster.java:647)
> at
> org.apache.flink.streaming.api.environment.LocalStreamEnvironment.execute(LocalStreamEnvironment.java:123)
> at
> org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.execute(StreamExecutionEnvironment.java:1510)
> at
> org.apache.flink.streaming.api.datastream.ReinterpretDataStreamAsKeyedStreamITCase.testReinterpretAsKeyedStream(ReinterpretDataStreamAsKeyedStreamITCase.java:107)
> Caused by: java.lang.AssertionError: expected:<300> but was:<301>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> org.apache.flink.streaming.api.datastream.ReinterpretDataStreamAsKeyedStreamITCase$ValidatingSink.close(ReinterpretDataStreamAsKeyedStreamITCase.java:295)
> at
> org.apache.flink.api.common.functions.util.FunctionUtils.closeFunction(FunctionUtils.java:43)
> at
> org.apache.flink.streaming.api.operators.AbstractUdfStreamOperator.close(AbstractUdfStreamOperator.java:109)
> at
> org.apache.flink.streaming.runtime.tasks.StreamTask.closeAllOperators(StreamTask.java:442)
> at
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:317)
> at org.apache.flink.runtime.taskmanager.Task.run(Task.java:704)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11041) ReinterpretDataStreamAsKeyedStreamITCase.testReinterpretAsKeyedStream failed on Travis
[
https://issues.apache.org/jira/browse/FLINK-11041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708320#comment-16708320
]
Till Rohrmann commented on FLINK-11041:
---
Another instance: https://api.travis-ci.org/v3/job/462744934/log.txt
> ReinterpretDataStreamAsKeyedStreamITCase.testReinterpretAsKeyedStream failed
> on Travis
> --
>
> Key: FLINK-11041
> URL: https://issues.apache.org/jira/browse/FLINK-11041
> Project: Flink
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.8.0
>Reporter: Till Rohrmann
>Priority: Critical
> Labels: test-stability
> Fix For: 1.8.0
>
>
> {{ReinterpretDataStreamAsKeyedStreamITCase.testReinterpretAsKeyedStream}}
> failed on Travis:
> https://api.travis-ci.org/v3/job/461707550/log.txt
> https://travis-ci.org/apache/flink/jobs/461707550
> It seems that the test job is producing wrong results:
> {code}
> testReinterpretAsKeyedStream(org.apache.flink.streaming.api.datastream.ReinterpretDataStreamAsKeyedStreamITCase)
> Time elapsed: 8.357 sec <<< ERROR!
> org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
> at
> org.apache.flink.runtime.jobmaster.JobResult.toJobExecutionResult(JobResult.java:146)
> at
> org.apache.flink.runtime.minicluster.MiniCluster.executeJobBlocking(MiniCluster.java:647)
> at
> org.apache.flink.streaming.api.environment.LocalStreamEnvironment.execute(LocalStreamEnvironment.java:123)
> at
> org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.execute(StreamExecutionEnvironment.java:1510)
> at
> org.apache.flink.streaming.api.datastream.ReinterpretDataStreamAsKeyedStreamITCase.testReinterpretAsKeyedStream(ReinterpretDataStreamAsKeyedStreamITCase.java:107)
> Caused by: java.lang.AssertionError: expected:<300> but was:<301>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> org.apache.flink.streaming.api.datastream.ReinterpretDataStreamAsKeyedStreamITCase$ValidatingSink.close(ReinterpretDataStreamAsKeyedStreamITCase.java:295)
> at
> org.apache.flink.api.common.functions.util.FunctionUtils.closeFunction(FunctionUtils.java:43)
> at
> org.apache.flink.streaming.api.operators.AbstractUdfStreamOperator.close(AbstractUdfStreamOperator.java:109)
> at
> org.apache.flink.streaming.runtime.tasks.StreamTask.closeAllOperators(StreamTask.java:442)
> at
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:317)
> at org.apache.flink.runtime.taskmanager.Task.run(Task.java:704)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
