[jira] [Commented] (FLINK-11852) Improve Processing function example
[
https://issues.apache.org/jira/browse/FLINK-11852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329509#comment-17329509
]
Flink Jira Bot commented on FLINK-11852:
This issue is assigned but has not received an update in 7 days so it has been
labeled "stale-assigned". If you are still working on the issue, please give an
update and remove the label. If you are no longer working on the issue, please
unassign so someone else may work on it. In 7 days the issue will be
automatically unassigned.
> Improve Processing function example
> ---
>
> Key: FLINK-11852
> URL: https://issues.apache.org/jira/browse/FLINK-11852
> Project: Flink
> Issue Type: Improvement
> Components: API / DataStream, Documentation
>Affects Versions: 1.7.2
>Reporter: Flavio Pompermaier
>Assignee: TANG Wen-hui
>Priority: Minor
> Labels: pull-request-available, stale-assigned
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In the processing function documentation
> ([https://ci.apache.org/projects/flink/flink-docs-stable/dev/stream/operators/process_function.html)]
> there's an "abusive" usage of the timers since a new timer is registered for
> every new tuple coming in. This could cause problems in terms of allocated
> objects and could burden the overall application.
> It could worth to mention this problem and remove useless timers, e.g.:
>
> {code:java}
> CountWithTimestamp current = state.value();
> if (current == null) {
> current = new CountWithTimestamp();
> current.key = value.f0;
> } else {
> ctx.timerService().deleteEventTimeTimer(current.lastModified + timeout);
> }{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-11852) Improve Processing function example
[
https://issues.apache.org/jira/browse/FLINK-11852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17321973#comment-17321973
]
Flavio Pompermaier commented on FLINK-11852:
I think it could be still useful
> Improve Processing function example
> ---
>
> Key: FLINK-11852
> URL: https://issues.apache.org/jira/browse/FLINK-11852
> Project: Flink
> Issue Type: Improvement
> Components: API / DataStream, Documentation
>Affects Versions: 1.7.2
>Reporter: Flavio Pompermaier
>Assignee: TANG Wen-hui
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In the processing function documentation
> ([https://ci.apache.org/projects/flink/flink-docs-stable/dev/stream/operators/process_function.html)]
> there's an "abusive" usage of the timers since a new timer is registered for
> every new tuple coming in. This could cause problems in terms of allocated
> objects and could burden the overall application.
> It could worth to mention this problem and remove useless timers, e.g.:
>
> {code:java}
> CountWithTimestamp current = state.value();
> if (current == null) {
> current = new CountWithTimestamp();
> current.key = value.f0;
> } else {
> ctx.timerService().deleteEventTimeTimer(current.lastModified + timeout);
> }{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-11852) Improve Processing function example
[
https://issues.apache.org/jira/browse/FLINK-11852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17321526#comment-17321526
]
Flink Jira Bot commented on FLINK-11852:
This issue and all of its Sub-Tasks have not been updated for 180 days. So, it
has been labeled "stale-minor". If you are still affected by this bug or are
still interested in this issue, please give an update and remove the label. In
7 days the issue will be closed automatically.
> Improve Processing function example
> ---
>
> Key: FLINK-11852
> URL: https://issues.apache.org/jira/browse/FLINK-11852
> Project: Flink
> Issue Type: Improvement
> Components: API / DataStream, Documentation
>Affects Versions: 1.7.2
>Reporter: Flavio Pompermaier
>Assignee: TANG Wen-hui
>Priority: Minor
> Labels: pull-request-available, stale-minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In the processing function documentation
> ([https://ci.apache.org/projects/flink/flink-docs-stable/dev/stream/operators/process_function.html)]
> there's an "abusive" usage of the timers since a new timer is registered for
> every new tuple coming in. This could cause problems in terms of allocated
> objects and could burden the overall application.
> It could worth to mention this problem and remove useless timers, e.g.:
>
> {code:java}
> CountWithTimestamp current = state.value();
> if (current == null) {
> current = new CountWithTimestamp();
> current.key = value.f0;
> } else {
> ctx.timerService().deleteEventTimeTimer(current.lastModified + timeout);
> }{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-11852) Improve Processing function example
[
https://issues.apache.org/jira/browse/FLINK-11852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061222#comment-17061222
]
Flavio Pompermaier commented on FLINK-11852:
I think the PR is good to merge..anyone taking care of it?
> Improve Processing function example
> ---
>
> Key: FLINK-11852
> URL: https://issues.apache.org/jira/browse/FLINK-11852
> Project: Flink
> Issue Type: Improvement
> Components: API / DataStream, Documentation
>Affects Versions: 1.7.2
>Reporter: Flavio Pompermaier
>Assignee: TANG Wen-hui
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In the processing function documentation
> ([https://ci.apache.org/projects/flink/flink-docs-stable/dev/stream/operators/process_function.html)]
> there's an "abusive" usage of the timers since a new timer is registered for
> every new tuple coming in. This could cause problems in terms of allocated
> objects and could burden the overall application.
> It could worth to mention this problem and remove useless timers, e.g.:
>
> {code:java}
> CountWithTimestamp current = state.value();
> if (current == null) {
> current = new CountWithTimestamp();
> current.key = value.f0;
> } else {
> ctx.timerService().deleteEventTimeTimer(current.lastModified + timeout);
> }{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-11852) Improve Processing function example
[
https://issues.apache.org/jira/browse/FLINK-11852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786624#comment-16786624
]
chunpinghe commented on FLINK-11852:
you are right,it's meaningful!
> Improve Processing function example
> ---
>
> Key: FLINK-11852
> URL: https://issues.apache.org/jira/browse/FLINK-11852
> Project: Flink
> Issue Type: Improvement
> Components: Documentation
>Affects Versions: 1.7.2
>Reporter: Flavio Pompermaier
>Priority: Minor
>
> In the processing function documentation
> ([https://ci.apache.org/projects/flink/flink-docs-stable/dev/stream/operators/process_function.html)]
> there's an "abusive" usage of the timers since a new timer is registered for
> every new tuple coming in. This could cause problems in terms of allocated
> objects and could burden the overall application.
> It could worth to mention this problem and remove useless timers, e.g.:
>
> {code:java}
> CountWithTimestamp current = state.value();
> if (current == null) {
> current = new CountWithTimestamp();
> current.key = value.f0;
> } else {
> ctx.timerService().deleteEventTimeTimer(current.lastModified + timeout);
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
