[jira] [Commented] (FLINK-13266) Relocate blink planner classes to avoid class clashes
[
https://issues.apache.org/jira/browse/FLINK-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891613#comment-16891613
]
Jark Wu commented on FLINK-13266:
-
[FLINK-13266][table] Relocate blink planner classes to avoid class clashes
Fixed in 1.10.0: c601cfd662c2839f8ebc81b80879ecce55a8cbaf
Fixed in 1.9.0: TODO
> Relocate blink planner classes to avoid class clashes
> -
>
> Key: FLINK-13266
> URL: https://issues.apache.org/jira/browse/FLINK-13266
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
>Affects Versions: 1.9.0
>Reporter: Jark Wu
>Assignee: godfrey he
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.9.0, 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We should have a list to relocate classes in {{flink-table-planner-blink}}
> and {{flink-table-runtime-blink}} to avoid class clashes to make both
> planners available in a lib directory.
> Note that, not all the classes can/should be relocated. For examples: calcite
> classes, {{PlannerExpressionParserImpl}} and so on.
> The relocation package name is up to discussion. A dedicated path is
> {{org.apache.flink.table.blink}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (FLINK-13266) Relocate blink planner classes to avoid class clashes
[
https://issues.apache.org/jira/browse/FLINK-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891612#comment-16891612
]
Jark Wu commented on FLINK-13266:
-
[FLINK-13266][table] Relocate blink runtime classes to avoid class clashes
Fixed in 1.10.0: 9a6ca547d6bd261730c46519f6bffa0b699ec218
Fixed in 1.9.0: TODO
> Relocate blink planner classes to avoid class clashes
> -
>
> Key: FLINK-13266
> URL: https://issues.apache.org/jira/browse/FLINK-13266
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
>Affects Versions: 1.9.0
>Reporter: Jark Wu
>Assignee: godfrey he
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.9.0, 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We should have a list to relocate classes in {{flink-table-planner-blink}}
> and {{flink-table-runtime-blink}} to avoid class clashes to make both
> planners available in a lib directory.
> Note that, not all the classes can/should be relocated. For examples: calcite
> classes, {{PlannerExpressionParserImpl}} and so on.
> The relocation package name is up to discussion. A dedicated path is
> {{org.apache.flink.table.blink}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (FLINK-13266) Relocate blink planner classes to avoid class clashes
[
https://issues.apache.org/jira/browse/FLINK-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891611#comment-16891611
]
Jark Wu commented on FLINK-13266:
-
[FLINK-13266][table] Move OptimizerConfigOptions & ExecutionConfigOptions to
table-api-java module
Fixed in 1.10.0: 66e55d60f819c5a1f809830190461fb6ac341b0b
Fixed in 1.9.0: TODO
> Relocate blink planner classes to avoid class clashes
> -
>
> Key: FLINK-13266
> URL: https://issues.apache.org/jira/browse/FLINK-13266
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
>Affects Versions: 1.9.0
>Reporter: Jark Wu
>Assignee: godfrey he
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.9.0, 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We should have a list to relocate classes in {{flink-table-planner-blink}}
> and {{flink-table-runtime-blink}} to avoid class clashes to make both
> planners available in a lib directory.
> Note that, not all the classes can/should be relocated. For examples: calcite
> classes, {{PlannerExpressionParserImpl}} and so on.
> The relocation package name is up to discussion. A dedicated path is
> {{org.apache.flink.table.blink}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (FLINK-13266) Relocate blink planner classes to avoid class clashes
[
https://issues.apache.org/jira/browse/FLINK-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891156#comment-16891156
]
Timo Walther commented on FLINK-13266:
--
[FLINK-13266][table] Port function-related descriptors to flink-table-common
Fixed in 1.9.0: 22538cc3827c3d483f4ca23fc52ae00b822706ba
Fixed in 1.10.0: 24f1dce1ceca35ef0177fa16648fd40cbcb52ded
> Relocate blink planner classes to avoid class clashes
> -
>
> Key: FLINK-13266
> URL: https://issues.apache.org/jira/browse/FLINK-13266
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
>Affects Versions: 1.9.0
>Reporter: Jark Wu
>Assignee: godfrey he
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.9.0, 1.10.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We should have a list to relocate classes in {{flink-table-planner-blink}}
> and {{flink-table-runtime-blink}} to avoid class clashes to make both
> planners available in a lib directory.
> Note that, not all the classes can/should be relocated. For examples: calcite
> classes, {{PlannerExpressionParserImpl}} and so on.
> The relocation package name is up to discussion. A dedicated path is
> {{org.apache.flink.table.blink}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (FLINK-13266) Relocate blink planner classes to avoid class clashes
[
https://issues.apache.org/jira/browse/FLINK-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891034#comment-16891034
]
Timo Walther commented on FLINK-13266:
--
[FLINK-13266][table] Port DataView related classes to flink-table-common
Fixed in 1.10.0: d1d2256e22742511faabb6e75c80af75a0a8a58b
Fixed in 1.9.0: 1aa011f03aec70df146dfa4feb27cc80a74c9dbf
> Relocate blink planner classes to avoid class clashes
> -
>
> Key: FLINK-13266
> URL: https://issues.apache.org/jira/browse/FLINK-13266
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
>Affects Versions: 1.9.0
>Reporter: Jark Wu
>Assignee: godfrey he
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.9.0, 1.10.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We should have a list to relocate classes in {{flink-table-planner-blink}}
> and {{flink-table-runtime-blink}} to avoid class clashes to make both
> planners available in a lib directory.
> Note that, not all the classes can/should be relocated. For examples: calcite
> classes, {{PlannerExpressionParserImpl}} and so on.
> The relocation package name is up to discussion. A dedicated path is
> {{org.apache.flink.table.blink}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (FLINK-13266) Relocate blink planner classes to avoid class clashes
[
https://issues.apache.org/jira/browse/FLINK-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890130#comment-16890130
]
Timo Walther commented on FLINK-13266:
--
[FLINK-13266] [table] move ExpressionParserException & UnresolvedException to
table-common module
Fixed in 1.9.0: f2db40bfb5db641e554e4f09b5f9d58969dac551
Fixed in 1.10.0: e504957ca359fbc62004b4bd1386640254780a36
[FLINK-13266] [table] remove definedTimeAttributes file in blink planner
Fixed in 1.9.0: 85636497642ccd054f4a09eb2aa1b2eed6b3ed88
Fixed in 1.10.0: 7ba22989f46444754f736ad3ef337736d5b2a9c4
[FLINK-13266][table-runtime-blink] remove Order class from table-runtime-blink
Fixed in 1.9.0: ac46ce93856563ace059eafce2d6e73988ae44cd
Fixed in 1.10.0: 768731d2707bf40fefba5481ed20f9c3c3ea1673
[FLINK-13266][table-common] Improve comment for FilterableTableTableSource
Fixed in 1.9.0: 5eda255740b7b5f8f0033ab5e57e7b2b20c909be
Fixed in 1.10.0: 71283e27e2b4ca5274f791d46e085b940b8cf215
> Relocate blink planner classes to avoid class clashes
> -
>
> Key: FLINK-13266
> URL: https://issues.apache.org/jira/browse/FLINK-13266
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
>Affects Versions: 1.9.0
>Reporter: Jark Wu
>Assignee: godfrey he
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.9.0, 1.10.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We should have a list to relocate classes in {{flink-table-planner-blink}}
> and {{flink-table-runtime-blink}} to avoid class clashes to make both
> planners available in a lib directory.
> Note that, not all the classes can/should be relocated. For examples: calcite
> classes, {{PlannerExpressionParserImpl}} and so on.
> The relocation package name is up to discussion. A dedicated path is
> {{org.apache.flink.table.blink}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (FLINK-13266) Relocate blink planner classes to avoid class clashes
[
https://issues.apache.org/jira/browse/FLINK-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889993#comment-16889993
]
Timo Walther commented on FLINK-13266:
--
Thanks for opening the PR [~godfreyhe]. I will take a look at the changes in
the PR.
> Relocate blink planner classes to avoid class clashes
> -
>
> Key: FLINK-13266
> URL: https://issues.apache.org/jira/browse/FLINK-13266
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
>Affects Versions: 1.9.0
>Reporter: Jark Wu
>Assignee: godfrey he
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.9.0, 1.10.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We should have a list to relocate classes in {{flink-table-planner-blink}}
> and {{flink-table-runtime-blink}} to avoid class clashes to make both
> planners available in a lib directory.
> Note that, not all the classes can/should be relocated. For examples: calcite
> classes, {{PlannerExpressionParserImpl}} and so on.
> The relocation package name is up to discussion. A dedicated path is
> {{org.apache.flink.table.blink}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (FLINK-13266) Relocate blink planner classes to avoid class clashes
[
https://issues.apache.org/jira/browse/FLINK-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886673#comment-16886673
]
godfrey he commented on FLINK-13266:
hi [~twalthr], [~jark] I have list the changes in
https://docs.google.com/document/d/15Z1Khy23DwDBp956yBzkMYkGdoQAU_QgBoJmFWSffow,
and look forward your feedback, thanks
> Relocate blink planner classes to avoid class clashes
> -
>
> Key: FLINK-13266
> URL: https://issues.apache.org/jira/browse/FLINK-13266
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
>Affects Versions: 1.9.0
>Reporter: Jark Wu
>Assignee: Jark Wu
>Priority: Blocker
> Fix For: 1.9.0
>
>
> We should have a list to relocate classes in {{flink-table-planner-blink}}
> and {{flink-table-runtime-blink}} to avoid class clashes to make both
> planners available in a lib directory.
> Note that, not all the classes can/should be relocated. For examples: calcite
> classes, {{PlannerExpressionParserImpl}} and so on.
> The relocation package name is up to discussion. A dedicated path is
> {{org.apache.flink.table.blink}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (FLINK-13266) Relocate blink planner classes to avoid class clashes
[
https://issues.apache.org/jira/browse/FLINK-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885754#comment-16885754
]
Jark Wu commented on FLINK-13266:
-
Hi [~twalthr], I think it's a good idea. However, the {{flink.table.planner}}
and {{flink.table.runtime}} have already been used for some purpose.
{{flink.table.planner}} is used for {{Planner}} relative classes. And
{{flink.table.runtime}} is used for runtime operators. And we have some other
packages which maybe not appropriate to put them in {{flink.table.planner}} or
{{flink.table.runtime}}, for example, {{flink.table.executor}},
{{flink.table.catalog}}, {{flink.table.codegen}}.
> Relocate blink planner classes to avoid class clashes
> -
>
> Key: FLINK-13266
> URL: https://issues.apache.org/jira/browse/FLINK-13266
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
>Affects Versions: 1.9.0
>Reporter: Jark Wu
>Assignee: Jark Wu
>Priority: Blocker
> Fix For: 1.9.0
>
>
> We should have a list to relocate classes in {{flink-table-planner-blink}}
> and {{flink-table-runtime-blink}} to avoid class clashes to make both
> planners available in a lib directory.
> Note that, not all the classes can/should be relocated. For examples: calcite
> classes, {{PlannerExpressionParserImpl}} and so on.
> The relocation package name is up to discussion. A dedicated path is
> {{org.apache.flink.table.blink}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (FLINK-13266) Relocate blink planner classes to avoid class clashes
[
https://issues.apache.org/jira/browse/FLINK-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885156#comment-16885156
]
Timo Walther commented on FLINK-13266:
--
I would not use {{org.apache.flink.table.blink}} in any package name. According
to FLIP-32, {{flink-table-planner-blink}} will be renamed to
{{flink-table-planner}} and {{flink-table-runtime}} at some point. So the
package names should already represent this in order to not cause more merge
conflicts in the future. How about {{org.apache.flink.table.planner}} and
{{org.apache.flink.table.runtime}}?
> Relocate blink planner classes to avoid class clashes
> -
>
> Key: FLINK-13266
> URL: https://issues.apache.org/jira/browse/FLINK-13266
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
>Affects Versions: 1.9.0
>Reporter: Jark Wu
>Assignee: Jark Wu
>Priority: Blocker
> Fix For: 1.9.0
>
>
> We should have a list to relocate classes in {{flink-table-planner-blink}}
> and {{flink-table-runtime-blink}} to avoid class clashes to make both
> planners available in a lib directory.
> Note that, not all the classes can/should be relocated. For examples: calcite
> classes, {{PlannerExpressionParserImpl}} and so on.
> The relocation package name is up to discussion. A dedicated path is
> {{org.apache.flink.table.blink}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
