[jira] [Commented] (FLINK-13936) NOTICE-binary is outdated
[ https://issues.apache.org/jira/browse/FLINK-13936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16924107#comment-16924107 ] Chesnay Schepler commented on FLINK-13936: -- Minor whitespace issue on 1.8: 1ebc30c5e5d9f49f4af715cedd9cf99478418f1c > NOTICE-binary is outdated > - > > Key: FLINK-13936 > URL: https://issues.apache.org/jira/browse/FLINK-13936 > Project: Flink > Issue Type: Bug > Components: Build System >Affects Versions: 1.8.2, 1.9.0, 1.10.0 >Reporter: Chesnay Schepler >Assignee: Chesnay Schepler >Priority: Blocker > Labels: pull-request-available > Fix For: 1.10.0, 1.9.1, 1.8.3 > > Time Spent: 40m > Remaining Estimate: 0h > > The NOTICE-binary wasn't updated for the click-event example, the state > processing API and changes to the table API packaging. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (FLINK-13936) NOTICE-binary is outdated
[ https://issues.apache.org/jira/browse/FLINK-13936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922298#comment-16922298 ] Till Rohrmann commented on FLINK-13936: --- Then let's only regenerate the file. +1 for the automatic check. > NOTICE-binary is outdated > - > > Key: FLINK-13936 > URL: https://issues.apache.org/jira/browse/FLINK-13936 > Project: Flink > Issue Type: Bug > Components: Build System >Affects Versions: 1.10.0 >Reporter: Chesnay Schepler >Priority: Blocker > Fix For: 1.10.0 > > > The NOTICE-binary wasn't updated for the click-event example, the state > processing API and changes to the table API packaging. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (FLINK-13936) NOTICE-binary is outdated
[
https://issues.apache.org/jira/browse/FLINK-13936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922290#comment-16922290
]
Chesnay Schepler commented on FLINK-13936:
--
I would have time to just regenerate the file, but not enough time to do this
in a way where the individual changes could be traced back to specific commits.
I already tried the latter and blew more time on that than I'd like to admit.
While doing that I noticed that it shouldn't be too difficult to add an
automatic check for this; if we modify {{collect_license_files.sh}} to add a
preamble (containing the entries for log4j/slf4j) we could just generate it on
Travis and fail if they differ.
> NOTICE-binary is outdated
> -
>
> Key: FLINK-13936
> URL: https://issues.apache.org/jira/browse/FLINK-13936
> Project: Flink
> Issue Type: Bug
> Components: Build System
>Affects Versions: 1.10.0
>Reporter: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.10.0
>
>
> The NOTICE-binary wasn't updated for the click-event example, the state
> processing API and changes to the table API packaging.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (FLINK-13936) NOTICE-binary is outdated
[ https://issues.apache.org/jira/browse/FLINK-13936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922287#comment-16922287 ] Till Rohrmann commented on FLINK-13936: --- Do you have time to tackle this issue [~Zentol] since it is a blocker issue. > NOTICE-binary is outdated > - > > Key: FLINK-13936 > URL: https://issues.apache.org/jira/browse/FLINK-13936 > Project: Flink > Issue Type: Bug > Components: Build System >Affects Versions: 1.10.0 >Reporter: Chesnay Schepler >Priority: Blocker > Fix For: 1.10.0 > > > The NOTICE-binary wasn't updated for the click-event example, the state > processing API and changes to the table API packaging. -- This message was sent by Atlassian Jira (v8.3.2#803003)
